Re: [E-devel] Magic checks before NULL checks in Eina

[David S. <on...@gm...>]

On Thu, 28 Jun 2012 06:53:55 +0100 Michael Blumenkrantz
<mic...@gm...> wrote:

> On Wed, 27 Jun 2012 23:43:23 -0300
> Raphael Kubo da Costa <rakuco@FreeBSD.org> wrote:
> 
> > Cedric BAIL <ced...@fr...> writes:
> > 
> > > I personally think that eina_iterator_free like any free function
> > > should just work fine with NULL. I was against at that time, but
> > > others won. So we do have this incoherency where some of our free
> > > function work with NULL and some don't.
> > 
> > So what can we do to improve the situation here (if it does need to
> > be improved)? Speaking more generically, what criteria are used to
> > decide that a function should be decorated with EINA_ARG_NONNULL
> > and/or have magic checks performed?
> > 
> 
> I am hugely in favor of having all _free() and _del() functions take
> NULL arguments without erroring.

I agree with that to.

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.