Re: [E-devel] E SVN: nash trunk/edje/src/lib

[Gustavo S. B. <bar...@pr...>]

On Thu, Mar 24, 2011 at 3:12 AM, Enlightenment SVN
<no-...@en...> wrote:
> Log:
> Edje: Minor: Reorder args to make it compatible with smart_clipper
>
> Author:       nash
> Date:         2011-03-23 20:12:39 -0700 (Wed, 23 Mar 2011)
> New Revision: 58054
> Trac:         http://trac.enlightenment.org/e/changeset/58054
>
> Modified:
>  trunk/edje/src/lib/edje_private.h
>
> Modified: trunk/edje/src/lib/edje_private.h
> ===================================================================
> --- trunk/edje/src/lib/edje_private.h   2011-03-24 02:29:55 UTC (rev 58053)
> +++ trunk/edje/src/lib/edje_private.h   2011-03-24 03:12:39 UTC (rev 58054)
> @@ -969,6 +969,8 @@
>
>  struct _Edje
>  {
> +   Evas_Object          *clipper; /* a big rect to clip this Edje to */
> +   Evas                 *evas; /* the Evas this Edje belongs to */

This is a bit dangerous and not recommended as you'd have to keep in
sync. Technically it's fine as they have the same layout, but I'd have
as first field:

struct _Edje
{
    Evas_Object_Smart_Clipped_Data base;
    ...
};

so if clipped requirements change, a new recompile would fix it automatically.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: bar...@gm...
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202