From: Gustavo S. B. <bar...@pr...> - 2009-09-01 21:24:04
|
On Tue, Sep 1, 2009 at 4:33 PM, Enlightenment SVN<no-...@en...> wrote: > Log: > Exalt: use eina_log > - print_error(__FILE__,__func__, __LINE__,"Can not create the log file: %s\n",EXALTD_LOGFILE); > + EINA_LOG_DOM_WARN(EXALT_LOG_DOMAIN,"Can not create the log file: %s\n",EXALTD_LOGFILE); as I said in my other mail, this is not the best practice, I'd recommend all users of eina_log to define their own 3 letter macros doing the proper code. It will make code smaller and more portable if we need further changes: #define WRN(...) EINA_LOG_DOM_WARN(EXALT_LOG_DOMAIN, __VA_ARGS__) then: WRN("Can not create the log file: %s\n",EXALTD_LOGFILE); you can use WARN if you wish. If you're writing a library, then just define these macros on your PRIVATE header so your WRN/DBG do not clash with user's definitions. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: bar...@gm... Skype: gsbarbieri Mobile: +55 (19) 9225-2202 |