From: <enl...@li...> - 2006-01-24 13:58:53
|
Enlightenment CVS committal Author : onefang Project : e17 Module : apps/e Dir : e17/apps/e/src/bin Modified Files: e_apps.c Log Message: When I cloned the pipe read stuff to make pipe error, I didn't realise that ECORE_FD_ERROR is not the stderr equivilant of ECORE_FD_READ. I just cloned, and changed READ's to ERROR's. imho ECORE_FD_ERROR is missnamed, and should at least be better documented. See man select_tut, especially the entry on exceptfds. =================================================================== RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_apps.c,v retrieving revision 1.117 retrieving revision 1.118 diff -u -3 -r1.117 -r1.118 --- e_apps.c 21 Jan 2006 15:39:03 -0000 1.117 +++ e_apps.c 24 Jan 2006 13:58:17 -0000 1.118 @@ -1875,8 +1875,8 @@ aut = E_NEW(E_App_Autopsy, 1); aut->app = a; aut->del = *ev; - aut->read = ecore_exe_event_data_get(ai->exe, ECORE_FD_READ); - aut->error = ecore_exe_event_data_get(ai->exe, ECORE_FD_ERROR); + aut->error = ecore_exe_event_data_get(ai->exe, ECORE_EXE_PIPE_ERROR); + aut->read = ecore_exe_event_data_get(ai->exe, ECORE_EXE_PIPE_READ); _e_app_error_dialog(NULL, aut); } if (ai->expire_timer) ecore_timer_del(ai->expire_timer); |