[E-devel] Re: E CVS: libs/ecore handyande

[Kim W. <ki...@wo...>]

enl...@li... wrote:
> Enlightenment CVS committal
> 
> Author  : handyande
> Project : e17
> Module  : libs/ecore
> 
> Dir     : e17/libs/ecore/src/lib/ecore_config
> 
> 
> Modified Files:
> 	ecore_config_ipc_ecore.c 
> 
> 
> Log Message:
> Not sure what this is for, but it _totally_ broke ecore_config and all apps that use it - bad kwo ;)
> I guess I misunderstand, but the correct fix should be put in instead...
> ===================================================================
> RCS file: /cvsroot/enlightenment/e17/libs/ecore/src/lib/ecore_config/ecore_config_ipc_ecore.c,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -3 -r1.3 -r1.4
> --- ecore_config_ipc_ecore.c	2 Mar 2005 07:06:34 -0000	1.3
> +++ ecore_config_ipc_ecore.c	4 Mar 2005 10:46:19 -0000	1.4
> @@ -19,7 +19,7 @@
>  #include "Ecore_Config.h"
>  #include "config.h"
>  
> -#if 0 /* FIXME - No prototypes? */
> +#if 1 /* FIXME - No prototypes? */
>  /*****************************************************************************/
>  
>  static int
> 

Yeah (at least partially) my mistake. I overlooked what goes on in
_ecore_config_ipc_init, dynamic loading, I assume.

Anyway, I think that any exported function should have a prototype in
some header file, to mark it as such.

/Kim