From: Carsten H. (T. R. <ra...@ra...> - 2004-12-21 00:12:44
|
On Mon, 20 Dec 2004 14:27:27 -0500 (EST) "Frederick Heckel" <fw...@sc...> babbled: > > > Frederick Heckel wrote: > >> On Fri, 17 Dec 2004 21:57:25 +0000 Andrew Elcock <an...@el...> > >> claimed: > >> > >>>It should not be listening to directories at all - see how it passes 0 > >>>as the recurse setup bit? anyhow all .eet icons will be moved to .eapp > >>>soon, so this code will change. > >>> > >>>as for null winclasses - if (winclass && ... > >>>is just wrong - if you have a null winclass the icon is not valid for > >>>engage, it requires winclass to function properly... > >> > >> > >> Fair enough. Since the directory nodes are structural, I'd suggest that > >> null checks on the app->winclass field may serve perfectly well to > >> ignore them as apps-- > > > > no - apps with no winclass != dirs > > But if dirs == apps with no winclass, dirs should be ignored as apps(but > recursing into them potentially adds new apps to the tree, and so serve as > structural nodes), and apps with no winclass == invalid, why not just put > a null check in to fix the problem of dirs causing crashes because they > have no winclass until the new code goes into the repository? well actually engage is inheriting e17 e_apps code there and e17considers subdirs important. e17's ibar does nothing with them - but i did intend to allow subdirs (some form of popout folder/list of apps) etc. but i haven't done any code for ibar to do it.. but it doesn't segv :) > (fwph) > > -- > Frederick Heckel > fw...@sc... > http://battletothedeath.net > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://productguide.itmanagersjournal.com/ > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... 裸好多 ra...@de... Tokyo, Japan (東京 日本) |