From: <pc...@zy...> - 2013-02-16 03:00:04
Attachments:
0001-efl-engines-Introduce-pixel_alpha_get.patch
|
Hi, Just follow a patch that fixes a bug with evas_object_precise_is_inside_set() users on OpenGL backend. The _pixel_alpha_get() function used in evas_object_image_is_inside() relies on engine_data pointer being *always* an RGBA_Image * - but that's not true on OpenGL backend, since that pointer will be a Evas_GL_Image * instead. Given that, evas_object_image_is_inside() won't be able to get alpha from the pixels of the image being handled. The patch introduces a pixel_alpha_get() function on engines, and it has been implemented for Software and OpenGL backend so far. Besides, please consider backporting this patch to Evas 1.7.x as well. |
From: <pc...@zy...> - 2013-02-16 03:33:18
Attachments:
0001-efl-engines-Introduce-pixel_alpha_get.patch
|
pc...@zy... (Paulo C. A. Cavalcanti Jr) writes: > Just follow a patch that fixes a bug with > evas_object_precise_is_inside_set() users on OpenGL backend. > > The _pixel_alpha_get() function used in evas_object_image_is_inside() > relies on engine_data pointer being *always* an RGBA_Image * - but > that's not true on OpenGL backend, since that pointer will be a > Evas_GL_Image * instead. Given that, evas_object_image_is_inside() won't > be able to get alpha from the pixels of the image being handled. > > The patch introduces a pixel_alpha_get() function on engines, and it has > been implemented for Software and OpenGL backend so far. > > Besides, please consider backporting this patch to Evas 1.7.x as well. Just updated the patch with an unused "if" that got removed. |
From: Cedric B. <ced...@fr...> - 2013-02-16 10:16:06
|
On Sat, Feb 16, 2013 at 4:32 AM, Paulo C. A. Cavalcanti Jr <pc...@zy...> wrote: > pc...@zy... (Paulo C. A. Cavalcanti Jr) writes: >> Just follow a patch that fixes a bug with >> evas_object_precise_is_inside_set() users on OpenGL backend. >> >> The _pixel_alpha_get() function used in evas_object_image_is_inside() >> relies on engine_data pointer being *always* an RGBA_Image * - but >> that's not true on OpenGL backend, since that pointer will be a >> Evas_GL_Image * instead. Given that, evas_object_image_is_inside() won't >> be able to get alpha from the pixels of the image being handled. >> >> The patch introduces a pixel_alpha_get() function on engines, and it has >> been implemented for Software and OpenGL backend so far. >> >> Besides, please consider backporting this patch to Evas 1.7.x as well. > > Just updated the patch with an unused "if" that got removed. Good for me, will be in svn^Wgit soon. -- Cedric BAIL |
From: Iván B. <sac...@gm...> - 2013-02-17 17:43:35
|
Your patches seem to be coming with DOS newlines. Please fix your editor to avoid that. On Sat, Feb 16, 2013 at 1:32 AM, Paulo C. A. Cavalcanti Jr <pc...@zy...> wrote: > pc...@zy... (Paulo C. A. Cavalcanti Jr) writes: > >> Just follow a patch that fixes a bug with >> evas_object_precise_is_inside_set() users on OpenGL backend. >> >> The _pixel_alpha_get() function used in evas_object_image_is_inside() >> relies on engine_data pointer being *always* an RGBA_Image * - but >> that's not true on OpenGL backend, since that pointer will be a >> Evas_GL_Image * instead. Given that, evas_object_image_is_inside() won't >> be able to get alpha from the pixels of the image being handled. >> >> The patch introduces a pixel_alpha_get() function on engines, and it has >> been implemented for Software and OpenGL backend so far. >> >> Besides, please consider backporting this patch to Evas 1.7.x as well. > > Just updated the patch with an unused "if" that got removed. > > -- > Paulo C. A. Cavalcanti Jr, Intel Open Source Technology Center > I speak only for myself. > > ------------------------------------------------------------------------------ > The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, > is your hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials, tech docs, > whitepapers, evaluation guides, and opinion stories. Check out the most > recent posts - join the conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > |
From: <pc...@zy...> - 2013-02-18 15:49:18
|
Iván Briano <sac...@gm...> writes: > Your patches seem to be coming with DOS newlines. > Please fix your editor to avoid that. Yeah, just fixed it. Thanks for pointing it out. -- Paulo C. A. Cavalcanti Jr, Intel Open Source Technology Center I speak only for myself. |
From: <pc...@zy...> - 2013-02-18 15:57:47
Attachments:
0001-evas-engines-Introduce-pixel_alpha_get.patch
|
Hi Cedric, Cedric BAIL <ced...@fr...> writes: > Good for me, will be in svn^Wgit soon. I just made a backported version of this patch. Feel free to push it out. |
From: Iván B. <sac...@gm...> - 2013-02-18 16:21:43
|
On Mon, Feb 18, 2013 at 12:57 PM, Paulo C. A. Cavalcanti Jr <pc...@zy...> wrote: > Hi Cedric, > > Cedric BAIL <ced...@fr...> writes: > >> Good for me, will be in svn^Wgit soon. > > I just made a backported version of this patch. Feel free to push it out. In it went. > > -- > Paulo C. A. Cavalcanti Jr, Intel Open Source Technology Center > I speak only for myself. > > ------------------------------------------------------------------------------ > The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, > is your hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials, tech docs, > whitepapers, evaluation guides, and opinion stories. Check out the most > recent posts - join the conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > |