From: cnook <kim...@gm...> - 2011-03-17 13:46:06
Attachments:
elm_diskselector.diff
Elementary.h.in.diff
|
Dear All, This is Shinwoo Kim, learned that I could contribute to EFL! :) I'm pleased to inform you that the patch for the "elm_diskselector". Until now, the "elm_diskselector" only display 3 items at once, if you accept this patch, the "elm_diskselector" can display more than 3 items. For this feature, "elm_diskselector_display_item_num_set(Evas_Object *obj, int num)" is added. I would like to know more about your opinion about this feature. Thanks. Sincerely, Shinwoo Kim |
From: Bruno D. <bd...@pr...> - 2011-03-17 19:42:29
|
On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: > Dear All, Hi Shinwoo Kim, > > This is Shinwoo Kim, learned that I could contribute to EFL! :) > I'm pleased to inform you that the patch for the "elm_diskselector". > > Until now, the "elm_diskselector" only display 3 items at once, > if you accept this patch, the "elm_diskselector" can display more than 3 > items. Displaying more than 3 items is a nice improvement. What do you think about the idea of getting the number of items to be displayed from the theme ? Anyway, there is a typo on documentation (param num). Maybe a getter could be useful as well. Regards > > For this feature, "elm_diskselector_display_item_num_set(Evas_Object *obj, > int num)" is added. > I would like to know more about your opinion about this feature. Thanks. > > Sincerely, > Shinwoo Kim > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > |
From: Gustavo S. B. <bar...@pr...> - 2011-03-17 19:47:29
|
On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> wrote: > On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: >> Dear All, > > Hi Shinwoo Kim, > >> >> This is Shinwoo Kim, learned that I could contribute to EFL! :) >> I'm pleased to inform you that the patch for the "elm_diskselector". >> >> Until now, the "elm_diskselector" only display 3 items at once, >> if you accept this patch, the "elm_diskselector" can display more than 3 >> items. > > Displaying more than 3 items is a nice improvement. > What do you think about the idea of getting the number of items to be > displayed from the theme ? > > Anyway, there is a typo on documentation (param num). Maybe a getter > could be useful as well. +1 to get it from theme! I did something similar for ephoto in some older version, it had couple of swallow parts defined, like "elm.swallow.p%d", and a data.item: "count" "3", thus it would fill 3 swallows. I believe this is something up to the theme as it has the knowledge on how to pack more items. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: bar...@gm... Skype: gsbarbieri Mobile: +55 (19) 9225-2202 |
From: Tiago F. <dev...@ti...> - 2011-03-17 20:57:37
|
+2 ! When had see this widget in first time, I imagined it with option to many items but ever configured in theme. If i'm right, this widget is a lot dependent of code and less of theme :( What you thing about this, Shinwoo Kim? Gustavo suggested the easiest way, use group data. Thanks. On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri <bar...@pr...> wrote: > On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> wrote: >> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: >>> Dear All, >> >> Hi Shinwoo Kim, >> >>> >>> This is Shinwoo Kim, learned that I could contribute to EFL! :) >>> I'm pleased to inform you that the patch for the "elm_diskselector". >>> >>> Until now, the "elm_diskselector" only display 3 items at once, >>> if you accept this patch, the "elm_diskselector" can display more than 3 >>> items. >> >> Displaying more than 3 items is a nice improvement. >> What do you think about the idea of getting the number of items to be >> displayed from the theme ? >> >> Anyway, there is a typo on documentation (param num). Maybe a getter >> could be useful as well. > > +1 to get it from theme! > > I did something similar for ephoto in some older version, it had > couple of swallow parts defined, like "elm.swallow.p%d", and a > data.item: "count" "3", thus it would fill 3 swallows. > > I believe this is something up to the theme as it has the knowledge on > how to pack more items. > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: bar...@gm... > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Tiago Rezende Campos Falcão http://www.tiagofalcao.com -- ProFUSION | embedded systems Computer Systems Laboratory - IC - Unicamp Grupo Pró Software Livre - Unicamp Laboratory of Information Systems - IC - Unicamp |
From: Daniel J. S. <seo...@gm...> - 2011-03-18 01:59:41
|
+3 ! Using group data in theme looks better because it reduces source-gui dependences. group { name: "xx"; data.item: "count" "3"; You can fetch this data from c source using edje_object_data_get() API. Please check other widgets for a reference. I checked the patch very briefly and here are some comments. 1. Indentation. ex) line 250 in elm_diskselector.diff 2. Blank lines. There are 2 blank lines at the end of diff file. 396, 397 lines. 3. Diff file. I think there is no rule for this but you can merge two diff files to one diff file because they are patches for a one feature and one library(elementary). 4. Sample code. It will be better to have a sample code for a new feature in elementary_test. Other than that, looks ok :) Thanks. Daniel Juyung Seo (SeoZ) On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao <dev...@ti...> wrote: > +2 ! > > When had see this widget in first time, I imagined it with option to > many items but ever configured in theme. > If i'm right, this widget is a lot dependent of code and less of theme :( > > What you thing about this, Shinwoo Kim? > Gustavo suggested the easiest way, use group data. > > Thanks. > > > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri > <bar...@pr...> wrote: >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> wrote: >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: >>>> Dear All, >>> >>> Hi Shinwoo Kim, >>> >>>> >>>> This is Shinwoo Kim, learned that I could contribute to EFL! :) >>>> I'm pleased to inform you that the patch for the "elm_diskselector". >>>> >>>> Until now, the "elm_diskselector" only display 3 items at once, >>>> if you accept this patch, the "elm_diskselector" can display more than 3 >>>> items. >>> >>> Displaying more than 3 items is a nice improvement. >>> What do you think about the idea of getting the number of items to be >>> displayed from the theme ? >>> >>> Anyway, there is a typo on documentation (param num). Maybe a getter >>> could be useful as well. >> >> +1 to get it from theme! >> >> I did something similar for ephoto in some older version, it had >> couple of swallow parts defined, like "elm.swallow.p%d", and a >> data.item: "count" "3", thus it would fill 3 swallows. >> >> I believe this is something up to the theme as it has the knowledge on >> how to pack more items. >> >> >> -- >> Gustavo Sverzut Barbieri >> http://profusion.mobi embedded systems >> -------------------------------------- >> MSN: bar...@gm... >> Skype: gsbarbieri >> Mobile: +55 (19) 9225-2202 >> >> ------------------------------------------------------------------------------ >> Colocation vs. Managed Hosting >> A question and answer guide to determining the best fit >> for your organization - today and in the future. >> http://p.sf.net/sfu/internap-sfd2d >> _______________________________________________ >> enlightenment-devel mailing list >> enl...@li... >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > -- > Tiago Rezende Campos Falcão > http://www.tiagofalcao.com > -- > ProFUSION | embedded systems > Computer Systems Laboratory - IC - Unicamp > Grupo Pró Software Livre - Unicamp > Laboratory of Information Systems - IC - Unicamp > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > |
From: cnook <kim...@gm...> - 2011-03-19 04:53:23
|
Dear All, Hi~ Thanks for your response. I have tried to use "data.item" and edje_object_data_get() API. It works fine. :) But I met a problem. When I use a new style for elm_diskselector, edje_object_data_get() cannot retrieve "data.item" of new style. Only original (default) "data.item" value is retrieved. Would you please let me know what I forget? Thanks. Sincerely, Shinwoo Kim. 2011/3/18 Daniel Juyung Seo <seo...@gm...> > +3 ! > Using group data in theme looks better because it reduces source-gui > dependences. > > group { name: "xx"; > data.item: "count" "3"; > > You can fetch this data from c source using edje_object_data_get() API. > Please check other widgets for a reference. > > I checked the patch very briefly and here are some comments. > > 1. Indentation. > ex) line 250 in elm_diskselector.diff > > 2. Blank lines. > There are 2 blank lines at the end of diff file. 396, 397 lines. > > 3. Diff file. > I think there is no rule for this but you can merge two diff files > to one diff file > because they are patches for a one feature and one library(elementary). > > 4. Sample code. > It will be better to have a sample code for a new feature in > elementary_test. > > Other than that, looks ok :) > > Thanks. > Daniel Juyung Seo (SeoZ) > > On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao <dev...@ti...> > wrote: > > +2 ! > > > > When had see this widget in first time, I imagined it with option to > > many items but ever configured in theme. > > If i'm right, this widget is a lot dependent of code and less of theme :( > > > > What you thing about this, Shinwoo Kim? > > Gustavo suggested the easiest way, use group data. > > > > Thanks. > > > > > > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri > > <bar...@pr...> wrote: > >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> > wrote: > >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: > >>>> Dear All, > >>> > >>> Hi Shinwoo Kim, > >>> > >>>> > >>>> This is Shinwoo Kim, learned that I could contribute to EFL! :) > >>>> I'm pleased to inform you that the patch for the "elm_diskselector". > >>>> > >>>> Until now, the "elm_diskselector" only display 3 items at once, > >>>> if you accept this patch, the "elm_diskselector" can display more than > 3 > >>>> items. > >>> > >>> Displaying more than 3 items is a nice improvement. > >>> What do you think about the idea of getting the number of items to be > >>> displayed from the theme ? > >>> > >>> Anyway, there is a typo on documentation (param num). Maybe a getter > >>> could be useful as well. > >> > >> +1 to get it from theme! > >> > >> I did something similar for ephoto in some older version, it had > >> couple of swallow parts defined, like "elm.swallow.p%d", and a > >> data.item: "count" "3", thus it would fill 3 swallows. > >> > >> I believe this is something up to the theme as it has the knowledge on > >> how to pack more items. > >> > >> > >> -- > >> Gustavo Sverzut Barbieri > >> http://profusion.mobi embedded systems > >> -------------------------------------- > >> MSN: bar...@gm... > >> Skype: gsbarbieri > >> Mobile: +55 (19) 9225-2202 > >> > >> > ------------------------------------------------------------------------------ > >> Colocation vs. Managed Hosting > >> A question and answer guide to determining the best fit > >> for your organization - today and in the future. > >> http://p.sf.net/sfu/internap-sfd2d > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enl...@li... > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > > > -- > > Tiago Rezende Campos Falcão > > http://www.tiagofalcao.com > > -- > > ProFUSION | embedded systems > > Computer Systems Laboratory - IC - Unicamp > > Grupo Pró Software Livre - Unicamp > > Laboratory of Information Systems - IC - Unicamp > > > > > ------------------------------------------------------------------------------ > > Colocation vs. Managed Hosting > > A question and answer guide to determining the best fit > > for your organization - today and in the future. > > http://p.sf.net/sfu/internap-sfd2d > > _______________________________________________ > > enlightenment-devel mailing list > > enl...@li... > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > |
From: Daniel J. S. <seo...@gm...> - 2011-03-19 04:58:02
|
Check the _theme_hook(). :) Thanks. Daniel Juyung Seo (SeoZ) On Sat, Mar 19, 2011 at 1:53 PM, cnook <kim...@gm...> wrote: > Dear All, > > Hi~ > > Thanks for your response. > > I have tried to use "data.item" and edje_object_data_get() API. It works > fine. :) > > But I met a problem. When I use a new style for elm_diskselector, > edje_object_data_get() cannot retrieve "data.item" of new style. > > Only original (default) "data.item" value is retrieved. > > Would you please let me know what I forget? > > Thanks. > > > Sincerely, > Shinwoo Kim. > > > 2011/3/18 Daniel Juyung Seo <seo...@gm...> >> >> +3 ! >> Using group data in theme looks better because it reduces source-gui >> dependences. >> >> group { name: "xx"; >> data.item: "count" "3"; >> >> You can fetch this data from c source using edje_object_data_get() API. >> Please check other widgets for a reference. >> >> I checked the patch very briefly and here are some comments. >> >> 1. Indentation. >> ex) line 250 in elm_diskselector.diff >> >> 2. Blank lines. >> There are 2 blank lines at the end of diff file. 396, 397 lines. >> >> 3. Diff file. >> I think there is no rule for this but you can merge two diff files >> to one diff file >> because they are patches for a one feature and one library(elementary). >> >> 4. Sample code. >> It will be better to have a sample code for a new feature in >> elementary_test. >> >> Other than that, looks ok :) >> >> Thanks. >> Daniel Juyung Seo (SeoZ) >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao <dev...@ti...> >> wrote: >> > +2 ! >> > >> > When had see this widget in first time, I imagined it with option to >> > many items but ever configured in theme. >> > If i'm right, this widget is a lot dependent of code and less of theme >> > :( >> > >> > What you thing about this, Shinwoo Kim? >> > Gustavo suggested the easiest way, use group data. >> > >> > Thanks. >> > >> > >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri >> > <bar...@pr...> wrote: >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> >> >> wrote: >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: >> >>>> Dear All, >> >>> >> >>> Hi Shinwoo Kim, >> >>> >> >>>> >> >>>> This is Shinwoo Kim, learned that I could contribute to EFL! :) >> >>>> I'm pleased to inform you that the patch for the "elm_diskselector". >> >>>> >> >>>> Until now, the "elm_diskselector" only display 3 items at once, >> >>>> if you accept this patch, the "elm_diskselector" can display more >> >>>> than 3 >> >>>> items. >> >>> >> >>> Displaying more than 3 items is a nice improvement. >> >>> What do you think about the idea of getting the number of items to be >> >>> displayed from the theme ? >> >>> >> >>> Anyway, there is a typo on documentation (param num). Maybe a getter >> >>> could be useful as well. >> >> >> >> +1 to get it from theme! >> >> >> >> I did something similar for ephoto in some older version, it had >> >> couple of swallow parts defined, like "elm.swallow.p%d", and a >> >> data.item: "count" "3", thus it would fill 3 swallows. >> >> >> >> I believe this is something up to the theme as it has the knowledge on >> >> how to pack more items. >> >> >> >> >> >> -- >> >> Gustavo Sverzut Barbieri >> >> http://profusion.mobi embedded systems >> >> -------------------------------------- >> >> MSN: bar...@gm... >> >> Skype: gsbarbieri >> >> Mobile: +55 (19) 9225-2202 >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Colocation vs. Managed Hosting >> >> A question and answer guide to determining the best fit >> >> for your organization - today and in the future. >> >> http://p.sf.net/sfu/internap-sfd2d >> >> _______________________________________________ >> >> enlightenment-devel mailing list >> >> enl...@li... >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> > >> > >> > >> > -- >> > Tiago Rezende Campos Falcão >> > http://www.tiagofalcao.com >> > -- >> > ProFUSION | embedded systems >> > Computer Systems Laboratory - IC - Unicamp >> > Grupo Pró Software Livre - Unicamp >> > Laboratory of Information Systems - IC - Unicamp >> > >> > >> > ------------------------------------------------------------------------------ >> > Colocation vs. Managed Hosting >> > A question and answer guide to determining the best fit >> > for your organization - today and in the future. >> > http://p.sf.net/sfu/internap-sfd2d >> > _______________________________________________ >> > enlightenment-devel mailing list >> > enl...@li... >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > |
From: cnook <kim...@gm...> - 2011-03-21 13:39:57
Attachments:
example.tar.gz
elm_diskselector.diff
|
Dear All, Hi~ Thanks for your response always! I have changed the "elm_diskselector" based on your comments. The "displayed item count" is described by using theme file. And example source - example.tar.gz - have attached. (If you have an example of the example :), then please inform and send me.) By the way, I have something wondering about this way. If several "elm_diskselector" are added with different "displayed item count" on one same parent, then several different theme file have to be existed. In this case, API would be more efficient. I would like to know more about your opinion. Thanks Sincerely, Shinwoo Kim. 2011/3/19 Daniel Juyung Seo <seo...@gm...> > Check the _theme_hook(). > :) > > Thanks. > Daniel Juyung Seo (SeoZ) > > On Sat, Mar 19, 2011 at 1:53 PM, cnook <kim...@gm...> wrote: > > Dear All, > > > > Hi~ > > > > Thanks for your response. > > > > I have tried to use "data.item" and edje_object_data_get() API. It works > > fine. :) > > > > But I met a problem. When I use a new style for elm_diskselector, > > edje_object_data_get() cannot retrieve "data.item" of new style. > > > > Only original (default) "data.item" value is retrieved. > > > > Would you please let me know what I forget? > > > > Thanks. > > > > > > Sincerely, > > Shinwoo Kim. > > > > > > 2011/3/18 Daniel Juyung Seo <seo...@gm...> > >> > >> +3 ! > >> Using group data in theme looks better because it reduces source-gui > >> dependences. > >> > >> group { name: "xx"; > >> data.item: "count" "3"; > >> > >> You can fetch this data from c source using edje_object_data_get() API. > >> Please check other widgets for a reference. > >> > >> I checked the patch very briefly and here are some comments. > >> > >> 1. Indentation. > >> ex) line 250 in elm_diskselector.diff > >> > >> 2. Blank lines. > >> There are 2 blank lines at the end of diff file. 396, 397 lines. > >> > >> 3. Diff file. > >> I think there is no rule for this but you can merge two diff files > >> to one diff file > >> because they are patches for a one feature and one > library(elementary). > >> > >> 4. Sample code. > >> It will be better to have a sample code for a new feature in > >> elementary_test. > >> > >> Other than that, looks ok :) > >> > >> Thanks. > >> Daniel Juyung Seo (SeoZ) > >> > >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao < > dev...@ti...> > >> wrote: > >> > +2 ! > >> > > >> > When had see this widget in first time, I imagined it with option to > >> > many items but ever configured in theme. > >> > If i'm right, this widget is a lot dependent of code and less of theme > >> > :( > >> > > >> > What you thing about this, Shinwoo Kim? > >> > Gustavo suggested the easiest way, use group data. > >> > > >> > Thanks. > >> > > >> > > >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri > >> > <bar...@pr...> wrote: > >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> > >> >> wrote: > >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: > >> >>>> Dear All, > >> >>> > >> >>> Hi Shinwoo Kim, > >> >>> > >> >>>> > >> >>>> This is Shinwoo Kim, learned that I could contribute to EFL! :) > >> >>>> I'm pleased to inform you that the patch for the > "elm_diskselector". > >> >>>> > >> >>>> Until now, the "elm_diskselector" only display 3 items at once, > >> >>>> if you accept this patch, the "elm_diskselector" can display more > >> >>>> than 3 > >> >>>> items. > >> >>> > >> >>> Displaying more than 3 items is a nice improvement. > >> >>> What do you think about the idea of getting the number of items to > be > >> >>> displayed from the theme ? > >> >>> > >> >>> Anyway, there is a typo on documentation (param num). Maybe a getter > >> >>> could be useful as well. > >> >> > >> >> +1 to get it from theme! > >> >> > >> >> I did something similar for ephoto in some older version, it had > >> >> couple of swallow parts defined, like "elm.swallow.p%d", and a > >> >> data.item: "count" "3", thus it would fill 3 swallows. > >> >> > >> >> I believe this is something up to the theme as it has the knowledge > on > >> >> how to pack more items. > >> >> > >> >> > >> >> -- > >> >> Gustavo Sverzut Barbieri > >> >> http://profusion.mobi embedded systems > >> >> -------------------------------------- > >> >> MSN: bar...@gm... > >> >> Skype: gsbarbieri > >> >> Mobile: +55 (19) 9225-2202 > >> >> > >> >> > >> >> > ------------------------------------------------------------------------------ > >> >> Colocation vs. Managed Hosting > >> >> A question and answer guide to determining the best fit > >> >> for your organization - today and in the future. > >> >> http://p.sf.net/sfu/internap-sfd2d > >> >> _______________________________________________ > >> >> enlightenment-devel mailing list > >> >> enl...@li... > >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >> > >> > > >> > > >> > > >> > -- > >> > Tiago Rezende Campos Falcão > >> > http://www.tiagofalcao.com > >> > -- > >> > ProFUSION | embedded systems > >> > Computer Systems Laboratory - IC - Unicamp > >> > Grupo Pró Software Livre - Unicamp > >> > Laboratory of Information Systems - IC - Unicamp > >> > > >> > > >> > > ------------------------------------------------------------------------------ > >> > Colocation vs. Managed Hosting > >> > A question and answer guide to determining the best fit > >> > for your organization - today and in the future. > >> > http://p.sf.net/sfu/internap-sfd2d > >> > _______________________________________________ > >> > enlightenment-devel mailing list > >> > enl...@li... > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > |
From: Daniel J. S. <seo...@gm...> - 2011-03-22 04:47:08
|
Hello. > then several different theme file have to be existed. In this case, API > would be more efficient. Hmm... you're right. It will be more flexible to use API for item count. If we use previously suggested idea, we need to prepare many item styles for several cases. And that doesn't look that flexible. And one more comment. You don't need to write separate sample application. Just add the sample to elementary_test. Thanks. Daniel Juyung Seo (SeoZ) On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> wrote: > Dear All, > > Hi~ > Thanks for your response always! > > I have changed the "elm_diskselector" based on your comments. > The "displayed item count" is described by using theme file. > And example source - example.tar.gz - have attached. > (If you have an example of the example :), then please inform and send me.) > > By the way, I have something wondering about this way. > If several "elm_diskselector" are added with different "displayed item > count" on one same parent, > then several different theme file have to be existed. In this case, API > would be more efficient. > > I would like to know more about your opinion. Thanks > > Sincerely, > Shinwoo Kim. > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> >> >> Check the _theme_hook(). >> :) >> >> Thanks. >> Daniel Juyung Seo (SeoZ) >> >> On Sat, Mar 19, 2011 at 1:53 PM, cnook <kim...@gm...> wrote: >> > Dear All, >> > >> > Hi~ >> > >> > Thanks for your response. >> > >> > I have tried to use "data.item" and edje_object_data_get() API. It works >> > fine. :) >> > >> > But I met a problem. When I use a new style for elm_diskselector, >> > edje_object_data_get() cannot retrieve "data.item" of new style. >> > >> > Only original (default) "data.item" value is retrieved. >> > >> > Would you please let me know what I forget? >> > >> > Thanks. >> > >> > >> > Sincerely, >> > Shinwoo Kim. >> > >> > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> >> >> >> >> +3 ! >> >> Using group data in theme looks better because it reduces source-gui >> >> dependences. >> >> >> >> group { name: "xx"; >> >> data.item: "count" "3"; >> >> >> >> You can fetch this data from c source using edje_object_data_get() API. >> >> Please check other widgets for a reference. >> >> >> >> I checked the patch very briefly and here are some comments. >> >> >> >> 1. Indentation. >> >> ex) line 250 in elm_diskselector.diff >> >> >> >> 2. Blank lines. >> >> There are 2 blank lines at the end of diff file. 396, 397 lines. >> >> >> >> 3. Diff file. >> >> I think there is no rule for this but you can merge two diff files >> >> to one diff file >> >> because they are patches for a one feature and one >> >> library(elementary). >> >> >> >> 4. Sample code. >> >> It will be better to have a sample code for a new feature in >> >> elementary_test. >> >> >> >> Other than that, looks ok :) >> >> >> >> Thanks. >> >> Daniel Juyung Seo (SeoZ) >> >> >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao >> >> <dev...@ti...> >> >> wrote: >> >> > +2 ! >> >> > >> >> > When had see this widget in first time, I imagined it with option to >> >> > many items but ever configured in theme. >> >> > If i'm right, this widget is a lot dependent of code and less of >> >> > theme >> >> > :( >> >> > >> >> > What you thing about this, Shinwoo Kim? >> >> > Gustavo suggested the easiest way, use group data. >> >> > >> >> > Thanks. >> >> > >> >> > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri >> >> > <bar...@pr...> wrote: >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> >> >> >> wrote: >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: >> >> >>>> Dear All, >> >> >>> >> >> >>> Hi Shinwoo Kim, >> >> >>> >> >> >>>> >> >> >>>> This is Shinwoo Kim, learned that I could contribute to EFL! :) >> >> >>>> I'm pleased to inform you that the patch for the >> >> >>>> "elm_diskselector". >> >> >>>> >> >> >>>> Until now, the "elm_diskselector" only display 3 items at once, >> >> >>>> if you accept this patch, the "elm_diskselector" can display more >> >> >>>> than 3 >> >> >>>> items. >> >> >>> >> >> >>> Displaying more than 3 items is a nice improvement. >> >> >>> What do you think about the idea of getting the number of items to >> >> >>> be >> >> >>> displayed from the theme ? >> >> >>> >> >> >>> Anyway, there is a typo on documentation (param num). Maybe a >> >> >>> getter >> >> >>> could be useful as well. >> >> >> >> >> >> +1 to get it from theme! >> >> >> >> >> >> I did something similar for ephoto in some older version, it had >> >> >> couple of swallow parts defined, like "elm.swallow.p%d", and a >> >> >> data.item: "count" "3", thus it would fill 3 swallows. >> >> >> >> >> >> I believe this is something up to the theme as it has the knowledge >> >> >> on >> >> >> how to pack more items. >> >> >> >> >> >> >> >> >> -- >> >> >> Gustavo Sverzut Barbieri >> >> >> http://profusion.mobi embedded systems >> >> >> -------------------------------------- >> >> >> MSN: bar...@gm... >> >> >> Skype: gsbarbieri >> >> >> Mobile: +55 (19) 9225-2202 >> >> >> >> >> >> >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> >> Colocation vs. Managed Hosting >> >> >> A question and answer guide to determining the best fit >> >> >> for your organization - today and in the future. >> >> >> http://p.sf.net/sfu/internap-sfd2d >> >> >> _______________________________________________ >> >> >> enlightenment-devel mailing list >> >> >> enl...@li... >> >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> >> >> > >> >> > >> >> > >> >> > -- >> >> > Tiago Rezende Campos Falcão >> >> > http://www.tiagofalcao.com >> >> > -- >> >> > ProFUSION | embedded systems >> >> > Computer Systems Laboratory - IC - Unicamp >> >> > Grupo Pró Software Livre - Unicamp >> >> > Laboratory of Information Systems - IC - Unicamp >> >> > >> >> > >> >> > >> >> > ------------------------------------------------------------------------------ >> >> > Colocation vs. Managed Hosting >> >> > A question and answer guide to determining the best fit >> >> > for your organization - today and in the future. >> >> > http://p.sf.net/sfu/internap-sfd2d >> >> > _______________________________________________ >> >> > enlightenment-devel mailing list >> >> > enl...@li... >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> > >> > >> > > > |
From: Tom H. <tom...@pa...> - 2011-03-22 08:09:03
|
You can load default from the theme and modify it with API... On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote: > Hello. > > > then several different theme file have to be existed. In this case, API > > would be more efficient. > > Hmm... you're right. It will be more flexible to use API for item count. > If we use previously suggested idea, we need to prepare many item > styles for several cases. > And that doesn't look that flexible. > > And one more comment. > You don't need to write separate sample application. > Just add the sample to elementary_test. > > Thanks. > Daniel Juyung Seo (SeoZ) > > On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> wrote: > > Dear All, > > > > Hi~ > > Thanks for your response always! > > > > I have changed the "elm_diskselector" based on your comments. > > The "displayed item count" is described by using theme file. > > And example source - example.tar.gz - have attached. > > (If you have an example of the example :), then please inform and send me.) > > > > By the way, I have something wondering about this way. > > If several "elm_diskselector" are added with different "displayed item > > count" on one same parent, > > then several different theme file have to be existed. In this case, API > > would be more efficient. > > > > I would like to know more about your opinion. Thanks > > > > Sincerely, > > Shinwoo Kim. > > > > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> > >> > >> Check the _theme_hook(). > >> :) > >> > >> Thanks. > >> Daniel Juyung Seo (SeoZ) > >> > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook <kim...@gm...> wrote: > >> > Dear All, > >> > > >> > Hi~ > >> > > >> > Thanks for your response. > >> > > >> > I have tried to use "data.item" and edje_object_data_get() API. It works > >> > fine. :) > >> > > >> > But I met a problem. When I use a new style for elm_diskselector, > >> > edje_object_data_get() cannot retrieve "data.item" of new style. > >> > > >> > Only original (default) "data.item" value is retrieved. > >> > > >> > Would you please let me know what I forget? > >> > > >> > Thanks. > >> > > >> > > >> > Sincerely, > >> > Shinwoo Kim. > >> > > >> > > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> > >> >> > >> >> +3 ! > >> >> Using group data in theme looks better because it reduces source-gui > >> >> dependences. > >> >> > >> >> group { name: "xx"; > >> >> data.item: "count" "3"; > >> >> > >> >> You can fetch this data from c source using edje_object_data_get() API. > >> >> Please check other widgets for a reference. > >> >> > >> >> I checked the patch very briefly and here are some comments. > >> >> > >> >> 1. Indentation. > >> >> ex) line 250 in elm_diskselector.diff > >> >> > >> >> 2. Blank lines. > >> >> There are 2 blank lines at the end of diff file. 396, 397 lines. > >> >> > >> >> 3. Diff file. > >> >> I think there is no rule for this but you can merge two diff files > >> >> to one diff file > >> >> because they are patches for a one feature and one > >> >> library(elementary). > >> >> > >> >> 4. Sample code. > >> >> It will be better to have a sample code for a new feature in > >> >> elementary_test. > >> >> > >> >> Other than that, looks ok :) > >> >> > >> >> Thanks. > >> >> Daniel Juyung Seo (SeoZ) > >> >> > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao > >> >> <dev...@ti...> > >> >> wrote: > >> >> > +2 ! > >> >> > > >> >> > When had see this widget in first time, I imagined it with option to > >> >> > many items but ever configured in theme. > >> >> > If i'm right, this widget is a lot dependent of code and less of > >> >> > theme > >> >> > :( > >> >> > > >> >> > What you thing about this, Shinwoo Kim? > >> >> > Gustavo suggested the easiest way, use group data. > >> >> > > >> >> > Thanks. > >> >> > > >> >> > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri > >> >> > <bar...@pr...> wrote: > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> > >> >> >> wrote: > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: > >> >> >>>> Dear All, > >> >> >>> > >> >> >>> Hi Shinwoo Kim, > >> >> >>> > >> >> >>>> > >> >> >>>> This is Shinwoo Kim, learned that I could contribute to EFL! :) > >> >> >>>> I'm pleased to inform you that the patch for the > >> >> >>>> "elm_diskselector". > >> >> >>>> > >> >> >>>> Until now, the "elm_diskselector" only display 3 items at once, > >> >> >>>> if you accept this patch, the "elm_diskselector" can display more > >> >> >>>> than 3 > >> >> >>>> items. > >> >> >>> > >> >> >>> Displaying more than 3 items is a nice improvement. > >> >> >>> What do you think about the idea of getting the number of items to > >> >> >>> be > >> >> >>> displayed from the theme ? > >> >> >>> > >> >> >>> Anyway, there is a typo on documentation (param num). Maybe a > >> >> >>> getter > >> >> >>> could be useful as well. > >> >> >> > >> >> >> +1 to get it from theme! > >> >> >> > >> >> >> I did something similar for ephoto in some older version, it had > >> >> >> couple of swallow parts defined, like "elm.swallow.p%d", and a > >> >> >> data.item: "count" "3", thus it would fill 3 swallows. > >> >> >> > >> >> >> I believe this is something up to the theme as it has the knowledge > >> >> >> on > >> >> >> how to pack more items. > >> >> >> > >> >> >> > >> >> >> -- > >> >> >> Gustavo Sverzut Barbieri > >> >> >> http://profusion.mobi embedded systems > >> >> >> -------------------------------------- > >> >> >> MSN: bar...@gm... > >> >> >> Skype: gsbarbieri > >> >> >> Mobile: +55 (19) 9225-2202 > >> >> >> > >> >> >> > >> >> >> > >> >> >> ------------------------------------------------------------------------------ > >> >> >> Colocation vs. Managed Hosting > >> >> >> A question and answer guide to determining the best fit > >> >> >> for your organization - today and in the future. > >> >> >> http://p.sf.net/sfu/internap-sfd2d > >> >> >> _______________________________________________ > >> >> >> enlightenment-devel mailing list > >> >> >> enl...@li... > >> >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >> >> > >> >> > > >> >> > > >> >> > > >> >> > -- > >> >> > Tiago Rezende Campos Falcão > >> >> > http://www.tiagofalcao.com > >> >> > -- > >> >> > ProFUSION | embedded systems > >> >> > Computer Systems Laboratory - IC - Unicamp > >> >> > Grupo Pró Software Livre - Unicamp > >> >> > Laboratory of Information Systems - IC - Unicamp > >> >> > > >> >> > > >> >> > > >> >> > ------------------------------------------------------------------------------ > >> >> > Colocation vs. Managed Hosting > >> >> > A question and answer guide to determining the best fit > >> >> > for your organization - today and in the future. > >> >> > http://p.sf.net/sfu/internap-sfd2d > >> >> > _______________________________________________ > >> >> > enlightenment-devel mailing list > >> >> > enl...@li... > >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >> > > >> > > >> > > > > > > > ------------------------------------------------------------------------------ > Enable your software for Intel(R) Active Management Technology to meet the > growing manageability and security demands of your customers. Businesses > are taking advantage of Intel(R) vPro (TM) technology - will your software > be a part of the solution? Download the Intel(R) Manageability Checker > today! http://p.sf.net/sfu/intel-dev2devmar > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel |
From: cnook <kim...@gm...> - 2011-03-22 10:36:31
Attachments:
elm_diskselector_using_API.diff
|
Dear All, Hello :) Thanks for your response. I have attached "elm_diskselector" patch using API and example code is also included. Please review this again. Thanks always. Sincerely, Shinwoo Kim. 2011/3/22 Tom Hacohen <tom...@pa...> > You can load default from the theme and modify it with API... > > On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote: > > Hello. > > > > > then several different theme file have to be existed. In this case, API > > > would be more efficient. > > > > Hmm... you're right. It will be more flexible to use API for item count. > > If we use previously suggested idea, we need to prepare many item > > styles for several cases. > > And that doesn't look that flexible. > > > > And one more comment. > > You don't need to write separate sample application. > > Just add the sample to elementary_test. > > > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> wrote: > > > Dear All, > > > > > > Hi~ > > > Thanks for your response always! > > > > > > I have changed the "elm_diskselector" based on your comments. > > > The "displayed item count" is described by using theme file. > > > And example source - example.tar.gz - have attached. > > > (If you have an example of the example :), then please inform and send > me.) > > > > > > By the way, I have something wondering about this way. > > > If several "elm_diskselector" are added with different "displayed item > > > count" on one same parent, > > > then several different theme file have to be existed. In this case, API > > > would be more efficient. > > > > > > I would like to know more about your opinion. Thanks > > > > > > Sincerely, > > > Shinwoo Kim. > > > > > > > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> > > >> > > >> Check the _theme_hook(). > > >> :) > > >> > > >> Thanks. > > >> Daniel Juyung Seo (SeoZ) > > >> > > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook <kim...@gm...> wrote: > > >> > Dear All, > > >> > > > >> > Hi~ > > >> > > > >> > Thanks for your response. > > >> > > > >> > I have tried to use "data.item" and edje_object_data_get() API. It > works > > >> > fine. :) > > >> > > > >> > But I met a problem. When I use a new style for elm_diskselector, > > >> > edje_object_data_get() cannot retrieve "data.item" of new style. > > >> > > > >> > Only original (default) "data.item" value is retrieved. > > >> > > > >> > Would you please let me know what I forget? > > >> > > > >> > Thanks. > > >> > > > >> > > > >> > Sincerely, > > >> > Shinwoo Kim. > > >> > > > >> > > > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> > > >> >> > > >> >> +3 ! > > >> >> Using group data in theme looks better because it reduces > source-gui > > >> >> dependences. > > >> >> > > >> >> group { name: "xx"; > > >> >> data.item: "count" "3"; > > >> >> > > >> >> You can fetch this data from c source using edje_object_data_get() > API. > > >> >> Please check other widgets for a reference. > > >> >> > > >> >> I checked the patch very briefly and here are some comments. > > >> >> > > >> >> 1. Indentation. > > >> >> ex) line 250 in elm_diskselector.diff > > >> >> > > >> >> 2. Blank lines. > > >> >> There are 2 blank lines at the end of diff file. 396, 397 lines. > > >> >> > > >> >> 3. Diff file. > > >> >> I think there is no rule for this but you can merge two diff > files > > >> >> to one diff file > > >> >> because they are patches for a one feature and one > > >> >> library(elementary). > > >> >> > > >> >> 4. Sample code. > > >> >> It will be better to have a sample code for a new feature in > > >> >> elementary_test. > > >> >> > > >> >> Other than that, looks ok :) > > >> >> > > >> >> Thanks. > > >> >> Daniel Juyung Seo (SeoZ) > > >> >> > > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao > > >> >> <dev...@ti...> > > >> >> wrote: > > >> >> > +2 ! > > >> >> > > > >> >> > When had see this widget in first time, I imagined it with option > to > > >> >> > many items but ever configured in theme. > > >> >> > If i'm right, this widget is a lot dependent of code and less of > > >> >> > theme > > >> >> > :( > > >> >> > > > >> >> > What you thing about this, Shinwoo Kim? > > >> >> > Gustavo suggested the easiest way, use group data. > > >> >> > > > >> >> > Thanks. > > >> >> > > > >> >> > > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri > > >> >> > <bar...@pr...> wrote: > > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly < > bd...@pr...> > > >> >> >> wrote: > > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> > wrote: > > >> >> >>>> Dear All, > > >> >> >>> > > >> >> >>> Hi Shinwoo Kim, > > >> >> >>> > > >> >> >>>> > > >> >> >>>> This is Shinwoo Kim, learned that I could contribute to EFL! > :) > > >> >> >>>> I'm pleased to inform you that the patch for the > > >> >> >>>> "elm_diskselector". > > >> >> >>>> > > >> >> >>>> Until now, the "elm_diskselector" only display 3 items at > once, > > >> >> >>>> if you accept this patch, the "elm_diskselector" can display > more > > >> >> >>>> than 3 > > >> >> >>>> items. > > >> >> >>> > > >> >> >>> Displaying more than 3 items is a nice improvement. > > >> >> >>> What do you think about the idea of getting the number of items > to > > >> >> >>> be > > >> >> >>> displayed from the theme ? > > >> >> >>> > > >> >> >>> Anyway, there is a typo on documentation (param num). Maybe a > > >> >> >>> getter > > >> >> >>> could be useful as well. > > >> >> >> > > >> >> >> +1 to get it from theme! > > >> >> >> > > >> >> >> I did something similar for ephoto in some older version, it had > > >> >> >> couple of swallow parts defined, like "elm.swallow.p%d", and a > > >> >> >> data.item: "count" "3", thus it would fill 3 swallows. > > >> >> >> > > >> >> >> I believe this is something up to the theme as it has the > knowledge > > >> >> >> on > > >> >> >> how to pack more items. > > >> >> >> > > >> >> >> > > >> >> >> -- > > >> >> >> Gustavo Sverzut Barbieri > > >> >> >> http://profusion.mobi embedded systems > > >> >> >> -------------------------------------- > > >> >> >> MSN: bar...@gm... > > >> >> >> Skype: gsbarbieri > > >> >> >> Mobile: +55 (19) 9225-2202 > > >> >> >> > > >> >> >> > > >> >> >> > > >> >> >> > ------------------------------------------------------------------------------ > > >> >> >> Colocation vs. Managed Hosting > > >> >> >> A question and answer guide to determining the best fit > > >> >> >> for your organization - today and in the future. > > >> >> >> http://p.sf.net/sfu/internap-sfd2d > > >> >> >> _______________________________________________ > > >> >> >> enlightenment-devel mailing list > > >> >> >> enl...@li... > > >> >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> >> >> > > >> >> > > > >> >> > > > >> >> > > > >> >> > -- > > >> >> > Tiago Rezende Campos Falcão > > >> >> > http://www.tiagofalcao.com > > >> >> > -- > > >> >> > ProFUSION | embedded systems > > >> >> > Computer Systems Laboratory - IC - Unicamp > > >> >> > Grupo Pró Software Livre - Unicamp > > >> >> > Laboratory of Information Systems - IC - Unicamp > > >> >> > > > >> >> > > > >> >> > > > >> >> > > ------------------------------------------------------------------------------ > > >> >> > Colocation vs. Managed Hosting > > >> >> > A question and answer guide to determining the best fit > > >> >> > for your organization - today and in the future. > > >> >> > http://p.sf.net/sfu/internap-sfd2d > > >> >> > _______________________________________________ > > >> >> > enlightenment-devel mailing list > > >> >> > enl...@li... > > >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> >> > > > >> > > > >> > > > > > > > > > > > > ------------------------------------------------------------------------------ > > Enable your software for Intel(R) Active Management Technology to meet > the > > growing manageability and security demands of your customers. Businesses > > are taking advantage of Intel(R) vPro (TM) technology - will your > software > > be a part of the solution? Download the Intel(R) Manageability Checker > > today! http://p.sf.net/sfu/intel-dev2devmar > > _______________________________________________ > > enlightenment-devel mailing list > > enl...@li... > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > |
From: Tom H. <tom...@pa...> - 2011-03-22 10:46:35
|
Dear Shinwoo, Why did you ditch getting the data from the theme? I think my suggestion is reasonable: use the data from the theme as the default value, and allow people to override it from API. So it's essentially what you did with just adding one line to the init of the object, to set display_item_num from the theme... -- Tom. On Tue, 2011-03-22 at 19:36 +0900, cnook wrote: > Dear All, > > Hello :) > > Thanks for your response. > I have attached "elm_diskselector" patch using API and example code is > also included. > Please review this again. Thanks always. > > Sincerely, > Shinwoo Kim. > > 2011/3/22 Tom Hacohen <tom...@pa...> > You can load default from the theme and modify it with API... > > > On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote: > > Hello. > > > > > then several different theme file have to be existed. In > this case, API > > > would be more efficient. > > > > Hmm... you're right. It will be more flexible to use API for > item count. > > If we use previously suggested idea, we need to prepare many > item > > styles for several cases. > > And that doesn't look that flexible. > > > > And one more comment. > > You don't need to write separate sample application. > > Just add the sample to elementary_test. > > > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> > wrote: > > > Dear All, > > > > > > Hi~ > > > Thanks for your response always! > > > > > > I have changed the "elm_diskselector" based on your > comments. > > > The "displayed item count" is described by using theme > file. > > > And example source - example.tar.gz - have attached. > > > (If you have an example of the example :), then please > inform and send me.) > > > > > > By the way, I have something wondering about this way. > > > If several "elm_diskselector" are added with different > "displayed item > > > count" on one same parent, > > > then several different theme file have to be existed. In > this case, API > > > would be more efficient. > > > > > > I would like to know more about your opinion. Thanks > > > > > > Sincerely, > > > Shinwoo Kim. > > > > > > > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> > > >> > > >> Check the _theme_hook(). > > >> :) > > >> > > >> Thanks. > > >> Daniel Juyung Seo (SeoZ) > > >> > > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook > <kim...@gm...> wrote: > > >> > Dear All, > > >> > > > >> > Hi~ > > >> > > > >> > Thanks for your response. > > >> > > > >> > I have tried to use "data.item" and > edje_object_data_get() API. It works > > >> > fine. :) > > >> > > > >> > But I met a problem. When I use a new style for > elm_diskselector, > > >> > edje_object_data_get() cannot retrieve "data.item" of > new style. > > >> > > > >> > Only original (default) "data.item" value is retrieved. > > >> > > > >> > Would you please let me know what I forget? > > >> > > > >> > Thanks. > > >> > > > >> > > > >> > Sincerely, > > >> > Shinwoo Kim. > > >> > > > >> > > > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> > > >> >> > > >> >> +3 ! > > >> >> Using group data in theme looks better because it > reduces source-gui > > >> >> dependences. > > >> >> > > >> >> group { name: "xx"; > > >> >> data.item: "count" "3"; > > >> >> > > >> >> You can fetch this data from c source using > edje_object_data_get() API. > > >> >> Please check other widgets for a reference. > > >> >> > > >> >> I checked the patch very briefly and here are some > comments. > > >> >> > > >> >> 1. Indentation. > > >> >> ex) line 250 in elm_diskselector.diff > > >> >> > > >> >> 2. Blank lines. > > >> >> There are 2 blank lines at the end of diff file. > 396, 397 lines. > > >> >> > > >> >> 3. Diff file. > > >> >> I think there is no rule for this but you can merge > two diff files > > >> >> to one diff file > > >> >> because they are patches for a one feature and one > > >> >> library(elementary). > > >> >> > > >> >> 4. Sample code. > > >> >> It will be better to have a sample code for a new > feature in > > >> >> elementary_test. > > >> >> > > >> >> Other than that, looks ok :) > > >> >> > > >> >> Thanks. > > >> >> Daniel Juyung Seo (SeoZ) > > >> >> > > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao > > >> >> <dev...@ti...> > > >> >> wrote: > > >> >> > +2 ! > > >> >> > > > >> >> > When had see this widget in first time, I imagined > it with option to > > >> >> > many items but ever configured in theme. > > >> >> > If i'm right, this widget is a lot dependent of code > and less of > > >> >> > theme > > >> >> > :( > > >> >> > > > >> >> > What you thing about this, Shinwoo Kim? > > >> >> > Gustavo suggested the easiest way, use group data. > > >> >> > > > >> >> > Thanks. > > >> >> > > > >> >> > > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut > Barbieri > > >> >> > <bar...@pr...> wrote: > > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly > <bd...@pr...> > > >> >> >> wrote: > > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook > <kim...@gm...> wrote: > > >> >> >>>> Dear All, > > >> >> >>> > > >> >> >>> Hi Shinwoo Kim, > > >> >> >>> > > >> >> >>>> > > >> >> >>>> This is Shinwoo Kim, learned that I could > contribute to EFL! :) > > >> >> >>>> I'm pleased to inform you that the patch for the > > >> >> >>>> "elm_diskselector". > > >> >> >>>> > > >> >> >>>> Until now, the "elm_diskselector" only display 3 > items at once, > > >> >> >>>> if you accept this patch, the "elm_diskselector" > can display more > > >> >> >>>> than 3 > > >> >> >>>> items. > > >> >> >>> > > >> >> >>> Displaying more than 3 items is a nice > improvement. > > >> >> >>> What do you think about the idea of getting the > number of items to > > >> >> >>> be > > >> >> >>> displayed from the theme ? > > >> >> >>> > > >> >> >>> Anyway, there is a typo on documentation (param > num). Maybe a > > >> >> >>> getter > > >> >> >>> could be useful as well. > > >> >> >> > > >> >> >> +1 to get it from theme! > > >> >> >> > > >> >> >> I did something similar for ephoto in some older > version, it had > > >> >> >> couple of swallow parts defined, like > "elm.swallow.p%d", and a > > >> >> >> data.item: "count" "3", thus it would fill 3 > swallows. > > >> >> >> > > >> >> >> I believe this is something up to the theme as it > has the knowledge > > >> >> >> on > > >> >> >> how to pack more items. > > >> >> >> > > >> >> >> > > >> >> >> -- > > >> >> >> Gustavo Sverzut Barbieri > > >> >> >> http://profusion.mobi embedded systems > > >> >> >> -------------------------------------- > > >> >> >> MSN: bar...@gm... > > >> >> >> Skype: gsbarbieri > > >> >> >> Mobile: +55 (19) 9225-2202 > > >> >> >> > > >> >> >> > > >> >> >> > > >> >> >> > ------------------------------------------------------------------------------ > > >> >> >> Colocation vs. Managed Hosting > > >> >> >> A question and answer guide to determining the best > fit > > >> >> >> for your organization - today and in the future. > > >> >> >> http://p.sf.net/sfu/internap-sfd2d > > >> >> >> _______________________________________________ > > >> >> >> enlightenment-devel mailing list > > >> >> >> enl...@li... > > >> >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> >> >> > > >> >> > > > >> >> > > > >> >> > > > >> >> > -- > > >> >> > Tiago Rezende Campos Falcão > > >> >> > http://www.tiagofalcao.com > > >> >> > -- > > >> >> > ProFUSION | embedded systems > > >> >> > Computer Systems Laboratory - IC - Unicamp > > >> >> > Grupo Pró Software Livre - Unicamp > > >> >> > Laboratory of Information Systems - IC - Unicamp > > >> >> > > > >> >> > > > >> >> > > > >> >> > > ------------------------------------------------------------------------------ > > >> >> > Colocation vs. Managed Hosting > > >> >> > A question and answer guide to determining the best > fit > > >> >> > for your organization - today and in the future. > > >> >> > http://p.sf.net/sfu/internap-sfd2d > > >> >> > _______________________________________________ > > >> >> > enlightenment-devel mailing list > > >> >> > enl...@li... > > >> >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> >> > > > >> > > > >> > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > Enable your software for Intel(R) Active Management > Technology to meet the > > growing manageability and security demands of your > customers. Businesses > > are taking advantage of Intel(R) vPro (TM) technology - will > your software > > be a part of the solution? Download the Intel(R) > Manageability Checker > > today! http://p.sf.net/sfu/intel-dev2devmar > > > _______________________________________________ > > enlightenment-devel mailing list > > enl...@li... > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > |
From: ChunEon P. <he...@na...> - 2011-03-22 11:31:47
|
But I guess the data count in the theme does not useful. Even user change the theme, the count could not be changed. Because each items could be set only in the code. ------------------------------------ Let's run together for the best moment! -Regards, Hermet- -----Original Message----- From: "Tom Hacohen"<tom...@pa...> To: "Daniel Juyung Seo"<seo...@gm...> Cc: enl...@li...; "cnook"<kim...@gm...> Sent: 11-03-22(화) 17:08:37 Subject: Re: [E-devel] [Patch] Display more than 3 items You can load default from the theme and modify it with API... On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote: > Hello. > > > then several different theme file have to be existed. In this case, API > > would be more efficient. > > Hmm... you're right. It will be more flexible to use API for item count. > If we use previously suggested idea, we need to prepare many item > styles for several cases. > And that doesn't look that flexible. > > And one more comment. > You don't need to write separate sample application. > Just add the sample to elementary_test. > > Thanks. > Daniel Juyung Seo (SeoZ) > > On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> wrote: > > Dear All, > > > > Hi~ > > Thanks for your response always! > > > > I have changed the "elm_diskselector" based on your comments. > > The "displayed item count" is described by using theme file. > > And example source - example.tar.gz - have attached. > > (If you have an example of the example :), then please inform and send me.) > > > > By the way, I have something wondering about this way. > > If several "elm_diskselector" are added with different "displayed item > > count" on one same parent, > > then several different theme file have to be existed. In this case, API > > would be more efficient. > > > > I would like to know more about your opinion. Thanks > > > > Sincerely, > > Shinwoo Kim. > > > > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> > >> > >> Check the _theme_hook(). > >> :) > >> > >> Thanks. > >> Daniel Juyung Seo (SeoZ) > >> > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook <kim...@gm...> wrote: > >> > Dear All, > >> > > >> > Hi~ > >> > > >> > Thanks for your response. > >> > > >> > I have tried to use "data.item" and edje_object_data_get() API. It works > >> > fine. :) > >> > > >> > But I met a problem. When I use a new style for elm_diskselector, > >> > edje_object_data_get() cannot retrieve "data.item" of new style. > >> > > >> > Only original (default) "data.item" value is retrieved. > >> > > >> > Would you please let me know what I forget? > >> > > >> > Thanks. > >> > > >> > > >> > Sincerely, > >> > Shinwoo Kim. > >> > > >> > > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> > >> >> > >> >> +3 ! > >> >> Using group data in theme looks better because it reduces source-gui > >> >> dependences. > >> >> > >> >> group { name: "xx"; > >> >> data.item: "count" "3"; > >> >> > >> >> You can fetch this data from c source using edje_object_data_get() API. > >> >> Please check other widgets for a reference. > >> >> > >> >> I checked the patch very briefly and here are some comments. > >> >> > >> >> 1. Indentation. > >> >> ex) line 250 in elm_diskselector.diff > >> >> > >> >> 2. Blank lines. > >> >> There are 2 blank lines at the end of diff file. 396, 397 lines. > >> >> > >> >> 3. Diff file. > >> >> I think there is no rule for this but you can merge two diff files > >> >> to one diff file > >> >> because they are patches for a one feature and one > >> >> library(elementary). > >> >> > >> >> 4. Sample code. > >> >> It will be better to have a sample code for a new feature in > >> >> elementary_test. > >> >> > >> >> Other than that, looks ok :) > >> >> > >> >> Thanks. > >> >> Daniel Juyung Seo (SeoZ) > >> >> > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao > >> >> <dev...@ti...> > >> >> wrote: > >> >> > +2 ! > >> >> > > >> >> > When had see this widget in first time, I imagined it with option to > >> >> > many items but ever configured in theme. > >> >> > If i'm right, this widget is a lot dependent of code and less of > >> >> > theme > >> >> > :( > >> >> > > >> >> > What you thing about this, Shinwoo Kim? > >> >> > Gustavo suggested the easiest way, use group data. > >> >> > > >> >> > Thanks. > >> >> > > >> >> > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri > >> >> > <bar...@pr...> wrote: > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bd...@pr...> > >> >> >> wrote: > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kim...@gm...> wrote: > >> >> >>>> Dear All, > >> >> >>> > >> >> >>> Hi Shinwoo Kim, > >> >> >>> > >> >> >>>> > >> >> >>>> This is Shinwoo Kim, learned that I could contribute to EFL! :) > >> >> >>>> I'm pleased to inform you that the patch for the > >> >> >>>> "elm_diskselector". > >> >> >>>> > >> >> >>>> Until now, the "elm_diskselector" only display 3 items at once, > >> >> >>>> if you accept this patch, the "elm_diskselector" can display more > >> >> >>>> than 3 > >> >> >>>> items. > >> >> >>> > >> >> >>> Displaying more than 3 items is a nice improvement. > >> >> >>> What do you think about the idea of getting the number of items to > >> >> >>> be > >> >> >>> displayed from the theme ? > >> >> >>> > >> >> >>> Anyway, there is a typo on documentation (param num). Maybe a > >> >> >>> getter > >> >> >>> could be useful as well. > >> >> >> > >> >> >> +1 to get it from theme! > >> >> >> > >> >> >> I did something similar for ephoto in some older version, it had > >> >> >> couple of swallow parts defined, like "elm.swallow.p%d", and a > >> >> >> data.item: "count" "3", thus it would fill 3 swallows. > >> >> >> > >> >> >> I believe this is something up to the theme as it has the knowledge > >> >> >> on > >> >> >> how to pack more items. > >> >> >> > >> >> >> > >> >> >> -- > >> >> >> Gustavo Sverzut Barbieri > >> >> >> http://profusion.mobi embedded systems > >> >> >> -------------------------------------- > >> >> >> MSN: bar...@gm... > >> >> >> Skype: gsbarbieri > >> >> >> Mobile: +55 (19) 9225-2202 > >> >> >> > >> >> >> > >> >> >> > >> >> >> ------------------------------------------------------------------------------ > >> >> >> Colocation vs. Managed Hosting > >> >> >> A question and answer guide to determining the best fit > >> >> >> for your organization - today and in the future. > >> >> >> http://p.sf.net/sfu/internap-sfd2d > >> >> >> _______________________________________________ > >> >> >> enlightenment-devel mailing list > >> >> >> enl...@li... > >> >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >> >> > >> >> > > >> >> > > >> >> > > >> >> > -- > >> >> > Tiago Rezende Campos Falcão > >> >> > http://www.tiagofalcao.com > >> >> > -- > >> >> > ProFUSION | embedded systems > >> >> > Computer Systems Laboratory - IC - Unicamp > >> >> > Grupo Pró Software Livre - Unicamp > >> >> > Laboratory of Information Systems - IC - Unicamp > >> >> > > >> >> > > >> >> > > >> >> > ------------------------------------------------------------------------------ > >> >> > Colocation vs. Managed Hosting > >> >> > A question and answer guide to determining the best fit > >> >> > for your organization - today and in the future. > >> >> > http://p.sf.net/sfu/internap-sfd2d > >> >> > _______________________________________________ > >> >> > enlightenment-devel mailing list > >> >> > enl...@li... > >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >> > > >> > > >> > > > > > > > ------------------------------------------------------------------------------ > Enable your software for Intel(R) Active Management Technology to meet the > growing manageability and security demands of your customers. Businesses > are taking advantage of Intel(R) vPro (TM) technology - will your software > be a part of the solution? Download the Intel(R) Manageability Checker > today! http://p.sf.net/sfu/intel-dev2devmar > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Enable your software for Intel(R) Active Management Technology to meet the growing manageability and security demands of your customers. Businesses are taking advantage of Intel(R) vPro (TM) technology - will your software be a part of the solution? Download the Intel(R) Manageability Checker today! http://p.sf.net/sfu/intel-dev2devmar _______________________________________________ enlightenment-devel mailing list enl...@li... https://lists.sourceforge.net/lists/listinfo/enlightenment-devel |
From: Gustavo S. B. <bar...@pr...> - 2011-03-22 12:09:50
|
On Tue, Mar 22, 2011 at 11:31 AM, ChunEon Park <he...@na...> wrote: > > But I guess the data count in the theme does not useful. > > Even user change the theme, the count could not be changed. > Because each items could be set only in the code. Again, I did not check the code and you did not send a screenshot to show it... but: considering a vertical disc (rolls up/down), is this the number of horizontal pieces (ie: number of discs)? Like in iPhone the number they provide 3 if you show the date (year, month, day). If this is the case then theme indeed does not make much sense (although I'd still like to have it, as theme is the proper way to define presentation and it would be awesome to have "date" style). if it's the number of previous/next items for each piece (disc), then I hardly disagree with it. This should be solely theme defined. If you want to support resize, then you can augment the contract with not just data.item, but also edje MSG_TYPE_INT to say how many items will fit in the given space. Just send a screenshot and things will be easier for those on the road without much time like me. :-) BR, -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: bar...@gm... Skype: gsbarbieri Mobile: +55 (19) 9225-2202 |
From: Tom H. <tom...@pa...> - 2011-03-22 11:40:47
|
I don'c quite follow. The user can change the theme to change the default behavior, and an application can override it through API, I don't see how setting it in the theme is not useful. -- Tom. On Tue, 2011-03-22 at 20:31 +0900, ChunEon Park wrote: > But I guess the data count in the theme does not useful. > > > > Even user change the theme, the count could not be changed. > > Because each items could be set only in the code. > > > > ------------------------------------ > Let's run together for the best moment! > > -Regards, Hermet- > > > > -----Original Message----- > From: "Tom Hacohen"<tom...@pa...> > To: "Daniel Juyung Seo"<seo...@gm...> > Cc: enl...@li...; > "cnook"<kim...@gm...> > Sent: 11-03-22(화) 17:08:37 > Subject: Re: [E-devel] [Patch] Display more than 3 items > > You can load default from the theme and modify it with API... > > On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote: > > Hello. > > > > > then several different theme file have to be existed. In this > case, API > > > would be more efficient. > > > > Hmm... you're right. It will be more flexible to use API for item > count. > > If we use previously suggested idea, we need to prepare many item > > styles for several cases. > > And that doesn't look that flexible. > > > > And one more comment. > > You don't need to write separate sample application. > > Just add the sample to elementary_test. > > > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> wrote: > > > Dear All, > > > > > > Hi~ > > > Thanks for your response always! > > > > > > I have changed the "elm_diskselector" based on your comments. > > > The "displayed item count" is described by using theme file. > > > And example source - example.tar.gz - have attached. > > > (If you have an example of the example :), then please inform and > send me.) > > > > > > By the way, I have something wondering about this way. > > > If several "elm_diskselector" are added with different "displayed > item > > > count" on one same parent, > > > then several different theme file have to be existed. In this > case, API > > > would be more efficient. > > > > > > I would like to know more about your opinion. Thanks > > > > > > Sincerely, > > > Shinwoo Kim. > > > > > > > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> > > >> > > >> Check the _theme_hook(). > > >> :) > > >> > > >> Thanks. > > >> Daniel Juyung Seo (SeoZ) > > >> > > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook <kim...@gm...> > wrote: > > >> > Dear All, > > >> > > > >> > Hi~ > > >> > > > >> > Thanks for your response. > > >> > > > >> > I have tried to use "data.item" and edje_object_data_get() API. > It works > > >> > fine. :) > > >> > > > >> > But I met a problem. When I use a new style for > elm_diskselector, > > >> > edje_object_data_get() cannot retrieve "data.item" of new > style. > > >> > > > >> > Only original (default) "data.item" value is retrieved. > > >> > > > >> > Would you please let me know what I forget? > > >> > > > >> > Thanks. > > >> > > > >> > > > >> > Sincerely, > > >> > Shinwoo Kim. > > >> > > > >> > > > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> > > >> >> > > >> >> +3 ! > > >> >> Using group data in theme looks better because it reduces > source-gui > > >> >> dependences. > > >> >> > > >> >> group { name: "xx"; > > >> >> data.item: "count" "3"; > > >> >> > > >> >> You can fetch this data from c source using > edje_object_data_get() API. > > >> >> Please check other widgets for a reference. > > >> >> > > >> >> I checked the patch very briefly and here are some comments. > > >> >> > > >> >> 1. Indentation. > > >> >> ex) line 250 in elm_diskselector.diff > > >> >> > > >> >> 2. Blank lines. > > >> >> There are 2 blank lines at the end of diff file. 396, 397 > lines. > > >> >> > > >> >> 3. Diff file. > > >> >> I think there is no rule for this but you can merge two diff > files > > >> >> to one diff file > > >> >> because they are patches for a one feature and one > > >> >> library(elementary). > > >> >> > > >> >> 4. Sample code. > > >> >> It will be better to have a sample code for a new feature in > > >> >> elementary_test. > > >> >> > > >> >> Other than that, looks ok :) > > >> >> > > >> >> Thanks. > > >> >> Daniel Juyung Seo (SeoZ) > > >> >> > > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao > > >> >> <dev...@ti...> > > >> >> wrote: > > >> >> > +2 ! > > >> >> > > > >> >> > When had see this widget in first time, I imagined it with > option to > > >> >> > many items but ever configured in theme. > > >> >> > If i'm right, this widget is a lot dependent of code and > less of > > >> >> > theme > > >> >> > :( > > >> >> > > > >> >> > What you thing about this, Shinwoo Kim? > > >> >> > Gustavo suggested the easiest way, use group data. > > >> >> > > > >> >> > Thanks. > > >> >> > > > >> >> > > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri > > >> >> > <bar...@pr...> wrote: > > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly > <bd...@pr...> > > >> >> >> wrote: > > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook > <kim...@gm...> wrote: > > >> >> >>>> Dear All, > > >> >> >>> > > >> >> >>> Hi Shinwoo Kim, > > >> >> >>> > > >> >> >>>> > > >> >> >>>> This is Shinwoo Kim, learned that I could contribute to > EFL! :) > > >> >> >>>> I'm pleased to inform you that the patch for the > > >> >> >>>> "elm_diskselector". > > >> >> >>>> > > >> >> >>>> Until now, the "elm_diskselector" only display 3 items at > once, > > >> >> >>>> if you accept this patch, the "elm_diskselector" can > display more > > >> >> >>>> than 3 > > >> >> >>>> items. > > >> >> >>> > > >> >> >>> Displaying more than 3 items is a nice improvement. > > >> >> >>> What do you think about the idea of getting the number of > items to > > >> >> >>> be > > >> >> >>> displayed from the theme ? > > >> >> >>> > > >> >> >>> Anyway, there is a typo on documentation (param num). > Maybe a > > >> >> >>> getter > > >> >> >>> could be useful as well. > > >> >> >> > > >> >> >> +1 to get it from theme! > > >> >> >> > > >> >> >> I did something similar for ephoto in some older version, > it had > > >> >> >> couple of swallow parts defined, like "elm.swallow.p%d", > and a > > >> >> >> data.item: "count" "3", thus it would fill 3 swallows. > > >> >> >> > > >> >> >> I believe this is something up to the theme as it has the > knowledge > > >> >> >> on > > >> >> >> how to pack more items. > > >> >> >> > > >> >> >> > > >> >> >> -- > > >> >> >> Gustavo Sverzut Barbieri > > >> >> >> http://profusion.mobi embedded systems > > >> >> >> -------------------------------------- > > >> >> >> MSN: bar...@gm... > > >> >> >> Skype: gsbarbieri > > >> >> >> Mobile: +55 (19) 9225-2202 > > >> >> >> > > >> >> >> > > >> >> >> > > >> >> >> > ------------------------------------------------------------------------------ > > >> >> >> Colocation vs. Managed Hosting > > >> >> >> A question and answer guide to determining the best fit > > >> >> >> for your organization - today and in the future. > > >> >> >> http://p.sf.net/sfu/internap-sfd2d > > >> >> >> _______________________________________________ > > >> >> >> enlightenment-devel mailing list > > >> >> >> enl...@li... > > >> >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> >> >> > > >> >> > > > >> >> > > > >> >> > > > >> >> > -- > > >> >> > Tiago Rezende Campos Falcão > > >> >> > http://www.tiagofalcao.com > > >> >> > -- > > >> >> > ProFUSION | embedded systems > > >> >> > Computer Systems Laboratory - IC - Unicamp > > >> >> > Grupo Pró Software Livre - Unicamp > > >> >> > Laboratory of Information Systems - IC - Unicamp > > >> >> > > > >> >> > > > >> >> > > > >> >> > > ------------------------------------------------------------------------------ > > >> >> > Colocation vs. Managed Hosting > > >> >> > A question and answer guide to determining the best fit > > >> >> > for your organization - today and in the future. > > >> >> > http://p.sf.net/sfu/internap-sfd2d > > >> >> > _______________________________________________ > > >> >> > enlightenment-devel mailing list > > >> >> > enl...@li... > > >> >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> >> > > > >> > > > >> > > > > > > > > > > > > ------------------------------------------------------------------------------ > > Enable your software for Intel(R) Active Management Technology to > meet the > > growing manageability and security demands of your customers. > Businesses > > are taking advantage of Intel(R) vPro (TM) technology - will your > software > > be a part of the solution? Download the Intel(R) Manageability > Checker > > today! http://p.sf.net/sfu/intel-dev2devmar > > _______________________________________________ > > enlightenment-devel mailing list > > enl...@li... > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ------------------------------------------------------------------------------ > Enable your software for Intel(R) Active Management Technology to meet > the > growing manageability and security demands of your customers. > Businesses > are taking advantage of Intel(R) vPro (TM) technology - will your > software > be a part of the solution? Download the Intel(R) Manageability > Checker > today! http://p.sf.net/sfu/intel-dev2devmar > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > |
From: cnook <kim...@gm...> - 2011-03-23 13:54:39
|
Dear All, Thanks for your response. I have attached "elm_diskselector" patch using API and getting default value from theme. But the default value from "elementary/themes/default.edc" is applied only. If user wants new default value from his/her own theme file, it will not be applied. Why I have changed like this.. because there is one case I worry about [steps] 1. elm_diskselector_display_item_num_set(disk, 5) 2. elm_object_style_set(disk, "new/style"); // style has data.item "display_item_num" "7" In this case elm_diskselector will display 7 items. By the way.. you mean.. 1. the newly defined default value should be applied? or 2. default value of default.edc is applied only? (attached patch) If you mean the first one, then both "Value from API" and "Value from Theme" will be supported. But I worry about above case and I'm not sure two ways should be coexisted. The second one.. it is also not meaningful.. Ok, please let me now your opinion upon it. Thanks. Sincerely, Shinwoo Kim. 2011/3/22 Tom Hacohen <tom...@pa...> > Dear Shinwoo, > > Why did you ditch getting the data from the theme? I think my suggestion > is reasonable: use the data from the theme as the default value, and > allow people to override it from API. So it's essentially what you did > with just adding one line to the init of the object, to set > display_item_num from the theme... > > -- > Tom. > > On Tue, 2011-03-22 at 19:36 +0900, cnook wrote: > > Dear All, > > > > Hello :) > > > > Thanks for your response. > > I have attached "elm_diskselector" patch using API and example code is > > also included. > > Please review this again. Thanks always. > > > > Sincerely, > > Shinwoo Kim. > > > > 2011/3/22 Tom Hacohen <tom...@pa...> > > You can load default from the theme and modify it with API... > > > > > > On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote: > > > Hello. > > > > > > > then several different theme file have to be existed. In > > this case, API > > > > would be more efficient. > > > > > > Hmm... you're right. It will be more flexible to use API for > > item count. > > > If we use previously suggested idea, we need to prepare many > > item > > > styles for several cases. > > > And that doesn't look that flexible. > > > > > > And one more comment. > > > You don't need to write separate sample application. > > > Just add the sample to elementary_test. > > > > > > Thanks. > > > Daniel Juyung Seo (SeoZ) > > > > > > On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> > > wrote: > > > > Dear All, > > > > > > > > Hi~ > > > > Thanks for your response always! > > > > > > > > I have changed the "elm_diskselector" based on your > > comments. > > > > The "displayed item count" is described by using theme > > file. > > > > And example source - example.tar.gz - have attached. > > > > (If you have an example of the example :), then please > > inform and send me.) > > > > > > > > By the way, I have something wondering about this way. > > > > If several "elm_diskselector" are added with different > > "displayed item > > > > count" on one same parent, > > > > then several different theme file have to be existed. In > > this case, API > > > > would be more efficient. > > > > > > > > I would like to know more about your opinion. Thanks > > > > > > > > Sincerely, > > > > Shinwoo Kim. > > > > > > > > > > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> > > > >> > > > >> Check the _theme_hook(). > > > >> :) > > > >> > > > >> Thanks. > > > >> Daniel Juyung Seo (SeoZ) > > > >> > > > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook > > <kim...@gm...> wrote: > > > >> > Dear All, > > > >> > > > > >> > Hi~ > > > >> > > > > >> > Thanks for your response. > > > >> > > > > >> > I have tried to use "data.item" and > > edje_object_data_get() API. It works > > > >> > fine. :) > > > >> > > > > >> > But I met a problem. When I use a new style for > > elm_diskselector, > > > >> > edje_object_data_get() cannot retrieve "data.item" of > > new style. > > > >> > > > > >> > Only original (default) "data.item" value is retrieved. > > > >> > > > > >> > Would you please let me know what I forget? > > > >> > > > > >> > Thanks. > > > >> > > > > >> > > > > >> > Sincerely, > > > >> > Shinwoo Kim. > > > >> > > > > >> > > > > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> > > > >> >> > > > >> >> +3 ! > > > >> >> Using group data in theme looks better because it > > reduces source-gui > > > >> >> dependences. > > > >> >> > > > >> >> group { name: "xx"; > > > >> >> data.item: "count" "3"; > > > >> >> > > > >> >> You can fetch this data from c source using > > edje_object_data_get() API. > > > >> >> Please check other widgets for a reference. > > > >> >> > > > >> >> I checked the patch very briefly and here are some > > comments. > > > >> >> > > > >> >> 1. Indentation. > > > >> >> ex) line 250 in elm_diskselector.diff > > > >> >> > > > >> >> 2. Blank lines. > > > >> >> There are 2 blank lines at the end of diff file. > > 396, 397 lines. > > > >> >> > > > >> >> 3. Diff file. > > > >> >> I think there is no rule for this but you can merge > > two diff files > > > >> >> to one diff file > > > >> >> because they are patches for a one feature and one > > > >> >> library(elementary). > > > >> >> > > > >> >> 4. Sample code. > > > >> >> It will be better to have a sample code for a new > > feature in > > > >> >> elementary_test. > > > >> >> > > > >> >> Other than that, looks ok :) > > > >> >> > > > >> >> Thanks. > > > >> >> Daniel Juyung Seo (SeoZ) > > > >> >> > > > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao > > > >> >> <dev...@ti...> > > > >> >> wrote: > > > >> >> > +2 ! > > > >> >> > > > > >> >> > When had see this widget in first time, I imagined > > it with option to > > > >> >> > many items but ever configured in theme. > > > >> >> > If i'm right, this widget is a lot dependent of code > > and less of > > > >> >> > theme > > > >> >> > :( > > > >> >> > > > > >> >> > What you thing about this, Shinwoo Kim? > > > >> >> > Gustavo suggested the easiest way, use group data. > > > >> >> > > > > >> >> > Thanks. > > > >> >> > > > > >> >> > > > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut > > Barbieri > > > >> >> > <bar...@pr...> wrote: > > > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly > > <bd...@pr...> > > > >> >> >> wrote: > > > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook > > <kim...@gm...> wrote: > > > >> >> >>>> Dear All, > > > >> >> >>> > > > >> >> >>> Hi Shinwoo Kim, > > > >> >> >>> > > > >> >> >>>> > > > >> >> >>>> This is Shinwoo Kim, learned that I could > > contribute to EFL! :) > > > >> >> >>>> I'm pleased to inform you that the patch for the > > > >> >> >>>> "elm_diskselector". > > > >> >> >>>> > > > >> >> >>>> Until now, the "elm_diskselector" only display 3 > > items at once, > > > >> >> >>>> if you accept this patch, the "elm_diskselector" > > can display more > > > >> >> >>>> than 3 > > > >> >> >>>> items. > > > >> >> >>> > > > >> >> >>> Displaying more than 3 items is a nice > > improvement. > > > >> >> >>> What do you think about the idea of getting the > > number of items to > > > >> >> >>> be > > > >> >> >>> displayed from the theme ? > > > >> >> >>> > > > >> >> >>> Anyway, there is a typo on documentation (param > > num). Maybe a > > > >> >> >>> getter > > > >> >> >>> could be useful as well. > > > >> >> >> > > > >> >> >> +1 to get it from theme! > > > >> >> >> > > > >> >> >> I did something similar for ephoto in some older > > version, it had > > > >> >> >> couple of swallow parts defined, like > > "elm.swallow.p%d", and a > > > >> >> >> data.item: "count" "3", thus it would fill 3 > > swallows. > > > >> >> >> > > > >> >> >> I believe this is something up to the theme as it > > has the knowledge > > > >> >> >> on > > > >> >> >> how to pack more items. > > > >> >> >> > > > >> >> >> > > > >> >> >> -- > > > >> >> >> Gustavo Sverzut Barbieri > > > >> >> >> http://profusion.mobi embedded systems > > > >> >> >> -------------------------------------- > > > >> >> >> MSN: bar...@gm... > > > >> >> >> Skype: gsbarbieri > > > >> >> >> Mobile: +55 (19) 9225-2202 > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > ------------------------------------------------------------------------------ > > > >> >> >> Colocation vs. Managed Hosting > > > >> >> >> A question and answer guide to determining the best > > fit > > > >> >> >> for your organization - today and in the future. > > > >> >> >> http://p.sf.net/sfu/internap-sfd2d > > > >> >> >> _______________________________________________ > > > >> >> >> enlightenment-devel mailing list > > > >> >> >> enl...@li... > > > >> >> >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > >> >> >> > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> > -- > > > >> >> > Tiago Rezende Campos Falcão > > > >> >> > http://www.tiagofalcao.com > > > >> >> > -- > > > >> >> > ProFUSION | embedded systems > > > >> >> > Computer Systems Laboratory - IC - Unicamp > > > >> >> > Grupo Pró Software Livre - Unicamp > > > >> >> > Laboratory of Information Systems - IC - Unicamp > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> > > > > ------------------------------------------------------------------------------ > > > >> >> > Colocation vs. Managed Hosting > > > >> >> > A question and answer guide to determining the best > > fit > > > >> >> > for your organization - today and in the future. > > > >> >> > http://p.sf.net/sfu/internap-sfd2d > > > >> >> > _______________________________________________ > > > >> >> > enlightenment-devel mailing list > > > >> >> > enl...@li... > > > >> >> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > >> >> > > > > >> > > > > >> > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Enable your software for Intel(R) Active Management > > Technology to meet the > > > growing manageability and security demands of your > > customers. Businesses > > > are taking advantage of Intel(R) vPro (TM) technology - will > > your software > > > be a part of the solution? Download the Intel(R) > > Manageability Checker > > > today! http://p.sf.net/sfu/intel-dev2devmar > > > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enl...@li... > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > |
From: Bruno D. <bd...@pr...> - 2011-03-23 17:16:36
|
On Wed, Mar 23, 2011 at 10:54 AM, cnook <kim...@gm...> wrote: > Dear All, > Hey Shinwoo Kim, > Thanks for your response. > > I have attached "elm_diskselector" patch using API and getting default value > from theme. > But the default value from "elementary/themes/default.edc" is applied only. > If user wants new default value from his/her own theme file, it will not be > applied. > > > Why I have changed like this.. because there is one case I worry about > > [steps] > 1. elm_diskselector_display_item_num_set(disk, 5) > 2. elm_object_style_set(disk, "new/style"); // style has data.item > "display_item_num" "7" > > In this case elm_diskselector will display 7 items. So keep these values in different variables and prioritize the usage of the value set with elm_diskselector_display_item_num_set over the data.item in the theme_hook function. Or just keep a bool that is true if the display_item_num was set by API You need to consider the most simple case, that is just set a new style that have a data.item != 3... It will be broken for this case, if I understood you proposal correctly. So, basically, you would have: function display_item_num_set(value): display_item_num_by_api = EINA_TRUE display_item_num = value function _theme_hook(): if (!display_item_num_by_api) display_item_num = data_item_get() > > > By the way.. you mean.. > 1. the newly defined default value should be applied? > or > 2. default value of default.edc is applied only? (attached patch) > > If you mean the first one, then both "Value from API" and "Value from > Theme" will be supported. But I worry about above case and I'm not sure two > ways should be coexisted. The idea is that both ways will be supported, yeah. Regards > > The second one.. it is also not meaningful.. > > Ok, please let me now your opinion upon it. Thanks. > > > Sincerely, > Shinwoo Kim. > > 2011/3/22 Tom Hacohen <tom...@pa...> > >> Dear Shinwoo, >> >> Why did you ditch getting the data from the theme? I think my suggestion >> is reasonable: use the data from the theme as the default value, and >> allow people to override it from API. So it's essentially what you did >> with just adding one line to the init of the object, to set >> display_item_num from the theme... >> >> -- >> Tom. >> >> On Tue, 2011-03-22 at 19:36 +0900, cnook wrote: >> > Dear All, >> > >> > Hello :) >> > >> > Thanks for your response. >> > I have attached "elm_diskselector" patch using API and example code is >> > also included. >> > Please review this again. Thanks always. >> > >> > Sincerely, >> > Shinwoo Kim. >> > >> > 2011/3/22 Tom Hacohen <tom...@pa...> >> > You can load default from the theme and modify it with API... >> > >> > >> > On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote: >> > > Hello. >> > > >> > > > then several different theme file have to be existed. In >> > this case, API >> > > > would be more efficient. >> > > >> > > Hmm... you're right. It will be more flexible to use API for >> > item count. >> > > If we use previously suggested idea, we need to prepare many >> > item >> > > styles for several cases. >> > > And that doesn't look that flexible. >> > > >> > > And one more comment. >> > > You don't need to write separate sample application. >> > > Just add the sample to elementary_test. >> > > >> > > Thanks. >> > > Daniel Juyung Seo (SeoZ) >> > > >> > > On Mon, Mar 21, 2011 at 10:39 PM, cnook <kim...@gm...> >> > wrote: >> > > > Dear All, >> > > > >> > > > Hi~ >> > > > Thanks for your response always! >> > > > >> > > > I have changed the "elm_diskselector" based on your >> > comments. >> > > > The "displayed item count" is described by using theme >> > file. >> > > > And example source - example.tar.gz - have attached. >> > > > (If you have an example of the example :), then please >> > inform and send me.) >> > > > >> > > > By the way, I have something wondering about this way. >> > > > If several "elm_diskselector" are added with different >> > "displayed item >> > > > count" on one same parent, >> > > > then several different theme file have to be existed. In >> > this case, API >> > > > would be more efficient. >> > > > >> > > > I would like to know more about your opinion. Thanks >> > > > >> > > > Sincerely, >> > > > Shinwoo Kim. >> > > > >> > > > >> > > > 2011/3/19 Daniel Juyung Seo <seo...@gm...> >> > > >> >> > > >> Check the _theme_hook(). >> > > >> :) >> > > >> >> > > >> Thanks. >> > > >> Daniel Juyung Seo (SeoZ) >> > > >> >> > > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook >> > <kim...@gm...> wrote: >> > > >> > Dear All, >> > > >> > >> > > >> > Hi~ >> > > >> > >> > > >> > Thanks for your response. >> > > >> > >> > > >> > I have tried to use "data.item" and >> > edje_object_data_get() API. It works >> > > >> > fine. :) >> > > >> > >> > > >> > But I met a problem. When I use a new style for >> > elm_diskselector, >> > > >> > edje_object_data_get() cannot retrieve "data.item" of >> > new style. >> > > >> > >> > > >> > Only original (default) "data.item" value is retrieved. >> > > >> > >> > > >> > Would you please let me know what I forget? >> > > >> > >> > > >> > Thanks. >> > > >> > >> > > >> > >> > > >> > Sincerely, >> > > >> > Shinwoo Kim. >> > > >> > >> > > >> > >> > > >> > 2011/3/18 Daniel Juyung Seo <seo...@gm...> >> > > >> >> >> > > >> >> +3 ! >> > > >> >> Using group data in theme looks better because it >> > reduces source-gui >> > > >> >> dependences. >> > > >> >> >> > > >> >> group { name: "xx"; >> > > >> >> data.item: "count" "3"; >> > > >> >> >> > > >> >> You can fetch this data from c source using >> > edje_object_data_get() API. >> > > >> >> Please check other widgets for a reference. >> > > >> >> >> > > >> >> I checked the patch very briefly and here are some >> > comments. >> > > >> >> >> > > >> >> 1. Indentation. >> > > >> >> ex) line 250 in elm_diskselector.diff >> > > >> >> >> > > >> >> 2. Blank lines. >> > > >> >> There are 2 blank lines at the end of diff file. >> > 396, 397 lines. >> > > >> >> >> > > >> >> 3. Diff file. >> > > >> >> I think there is no rule for this but you can merge >> > two diff files >> > > >> >> to one diff file >> > > >> >> because they are patches for a one feature and one >> > > >> >> library(elementary). >> > > >> >> >> > > >> >> 4. Sample code. >> > > >> >> It will be better to have a sample code for a new >> > feature in >> > > >> >> elementary_test. >> > > >> >> >> > > >> >> Other than that, looks ok :) >> > > >> >> >> > > >> >> Thanks. >> > > >> >> Daniel Juyung Seo (SeoZ) >> > > >> >> >> > > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao >> > > >> >> <dev...@ti...> >> > > >> >> wrote: >> > > >> >> > +2 ! >> > > >> >> > >> > > >> >> > When had see this widget in first time, I imagined >> > it with option to >> > > >> >> > many items but ever configured in theme. >> > > >> >> > If i'm right, this widget is a lot dependent of code >> > and less of >> > > >> >> > theme >> > > >> >> > :( >> > > >> >> > >> > > >> >> > What you thing about this, Shinwoo Kim? >> > > >> >> > Gustavo suggested the easiest way, use group data. >> > > >> >> > >> > > >> >> > Thanks. >> > > >> >> > >> > > >> >> > >> > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut >> > Barbieri >> > > >> >> > <bar...@pr...> wrote: >> > > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly >> > <bd...@pr...> >> > > >> >> >> wrote: >> > > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook >> > <kim...@gm...> wrote: >> > > >> >> >>>> Dear All, >> > > >> >> >>> >> > > >> >> >>> Hi Shinwoo Kim, >> > > >> >> >>> >> > > >> >> >>>> >> > > >> >> >>>> This is Shinwoo Kim, learned that I could >> > contribute to EFL! :) >> > > >> >> >>>> I'm pleased to inform you that the patch for the >> > > >> >> >>>> "elm_diskselector". >> > > >> >> >>>> >> > > >> >> >>>> Until now, the "elm_diskselector" only display 3 >> > items at once, >> > > >> >> >>>> if you accept this patch, the "elm_diskselector" >> > can display more >> > > >> >> >>>> than 3 >> > > >> >> >>>> items. >> > > >> >> >>> >> > > >> >> >>> Displaying more than 3 items is a nice >> > improvement. >> > > >> >> >>> What do you think about the idea of getting the >> > number of items to >> > > >> >> >>> be >> > > >> >> >>> displayed from the theme ? >> > > >> >> >>> >> > > >> >> >>> Anyway, there is a typo on documentation (param >> > num). Maybe a >> > > >> >> >>> getter >> > > >> >> >>> could be useful as well. >> > > >> >> >> >> > > >> >> >> +1 to get it from theme! >> > > >> >> >> >> > > >> >> >> I did something similar for ephoto in some older >> > version, it had >> > > >> >> >> couple of swallow parts defined, like >> > "elm.swallow.p%d", and a >> > > >> >> >> data.item: "count" "3", thus it would fill 3 >> > swallows. >> > > >> >> >> >> > > >> >> >> I believe this is something up to the theme as it >> > has the knowledge >> > > >> >> >> on >> > > >> >> >> how to pack more items. >> > > >> >> >> >> > > >> >> >> >> > > >> >> >> -- >> > > >> >> >> Gustavo Sverzut Barbieri >> > > >> >> >> http://profusion.mobi embedded systems >> > > >> >> >> -------------------------------------- >> > > >> >> >> MSN: bar...@gm... >> > > >> >> >> Skype: gsbarbieri >> > > >> >> >> Mobile: +55 (19) 9225-2202 >> > > >> >> >> >> > > >> >> >> >> > > >> >> >> >> > > >> >> >> >> > >> ------------------------------------------------------------------------------ >> > > >> >> >> Colocation vs. Managed Hosting >> > > >> >> >> A question and answer guide to determining the best >> > fit >> > > >> >> >> for your organization - today and in the future. >> > > >> >> >> http://p.sf.net/sfu/internap-sfd2d >> > > >> >> >> _______________________________________________ >> > > >> >> >> enlightenment-devel mailing list >> > > >> >> >> enl...@li... >> > > >> >> >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> >> >> >> > > >> >> > >> > > >> >> > >> > > >> >> > >> > > >> >> > -- >> > > >> >> > Tiago Rezende Campos Falcão >> > > >> >> > http://www.tiagofalcao.com >> > > >> >> > -- >> > > >> >> > ProFUSION | embedded systems >> > > >> >> > Computer Systems Laboratory - IC - Unicamp >> > > >> >> > Grupo Pró Software Livre - Unicamp >> > > >> >> > Laboratory of Information Systems - IC - Unicamp >> > > >> >> > >> > > >> >> > >> > > >> >> > >> > > >> >> > >> > >> ------------------------------------------------------------------------------ >> > > >> >> > Colocation vs. Managed Hosting >> > > >> >> > A question and answer guide to determining the best >> > fit >> > > >> >> > for your organization - today and in the future. >> > > >> >> > http://p.sf.net/sfu/internap-sfd2d >> > > >> >> > _______________________________________________ >> > > >> >> > enlightenment-devel mailing list >> > > >> >> > enl...@li... >> > > >> >> > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> >> > >> > > >> > >> > > >> > >> > > > >> > > > >> > > >> > >> > > >> > >> ------------------------------------------------------------------------------ >> > > Enable your software for Intel(R) Active Management >> > Technology to meet the >> > > growing manageability and security demands of your >> > customers. Businesses >> > > are taking advantage of Intel(R) vPro (TM) technology - will >> > your software >> > > be a part of the solution? Download the Intel(R) >> > Manageability Checker >> > > today! http://p.sf.net/sfu/intel-dev2devmar >> > >> > > _______________________________________________ >> > > enlightenment-devel mailing list >> > > enl...@li... >> > > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> > >> > >> > >> >> >> > > ------------------------------------------------------------------------------ > Enable your software for Intel(R) Active Management Technology to meet the > growing manageability and security demands of your customers. Businesses > are taking advantage of Intel(R) vPro (TM) technology - will your software > be a part of the solution? Download the Intel(R) Manageability Checker > today! http://p.sf.net/sfu/intel-dev2devmar > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > |
From: Gustavo S. B. <bar...@pr...> - 2011-03-23 14:16:04
|
On Wed, Mar 23, 2011 at 1:54 PM, cnook <kim...@gm...> wrote: > Dear All, > > Thanks for your response. > > I have attached "elm_diskselector" patch using API and getting default value > from theme. > But the default value from "elementary/themes/default.edc" is applied only. > If user wants new default value from his/her own theme file, it will not be > applied. > > > Why I have changed like this.. because there is one case I worry about Do you have the screenshot? Nobody replied to my mail. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: bar...@gm... Skype: gsbarbieri Mobile: +55 (19) 9225-2202 |
From: Daniel J. S. <seo...@gm...> - 2011-03-23 15:19:20
Attachments:
diskselector.png
|
I attached a screen shot :) This is a screen shot from elementary_test "Disk Selector" which cnook attached. Btw, cnook, I have one comment. _item_click_cb()'s parameter is wrong. Please check elm_diskselector.c code. elm_diskselector.c: In function ‘_item_new’: elm_diskselector.c:137: warning: passing argument 4 of ‘edje_object_signal_callback_add’ f rom incompatible pointer type /usr/local/include/edje-1/Edje.h:550: note: expected ‘Edje_Signal_Cb’ but argument is of t ype ‘void (*)(void *, struct Evas_Object *, void *)’ Thanks. Daniel Juyung Seo (SeoZ) On Wed, Mar 23, 2011 at 7:15 AM, Gustavo Sverzut Barbieri <bar...@pr...> wrote: > On Wed, Mar 23, 2011 at 1:54 PM, cnook <kim...@gm...> wrote: >> Dear All, >> >> Thanks for your response. >> >> I have attached "elm_diskselector" patch using API and getting default value >> from theme. >> But the default value from "elementary/themes/default.edc" is applied only. >> If user wants new default value from his/her own theme file, it will not be >> applied. >> >> >> Why I have changed like this.. because there is one case I worry about > > > Do you have the screenshot? Nobody replied to my mail. > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: bar...@gm... > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ------------------------------------------------------------------------------ > Enable your software for Intel(R) Active Management Technology to meet the > growing manageability and security demands of your customers. Businesses > are taking advantage of Intel(R) vPro (TM) technology - will your software > be a part of the solution? Download the Intel(R) Manageability Checker > today! http://p.sf.net/sfu/intel-dev2devmar > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > |
From: Gustavo S. B. <bar...@pr...> - 2011-03-23 21:05:55
|
On Wed, Mar 23, 2011 at 3:19 PM, Daniel Juyung Seo <seo...@gm...> wrote: > I attached a screen shot :) > This is a screen shot from elementary_test "Disk Selector" which cnook attached. THAT is what I worried. Problem is that we're trying to define presentation where it should not. Presentation should be in the theme/style, because it knows about it. EDC will know about font and size, you code will not. How can you judge how many elements will fit there? You can ask the theme to show N values, but then the theme itself will likely have a min/max value to enforce enough size is allocated for it. BTW, this widget layout is wrong. You should never fit an horizontal expanding item on a horizontal scrolling disc object. It's not logical. If you have an horizontal expanding item (ie; a text) you must place them vertically to get any effect that reminds of a disc. There is no graphical artist that will be able to make that look and feel like a disc, I warn you. OTOH if you place them vertically you'll have more control on item layout/spacing, can plan proper shadows and it will look nice. (Check people that do this type of widget, like the iPhone diskpicker, that's the reason they do that way). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: bar...@gm... Skype: gsbarbieri Mobile: +55 (19) 9225-2202 |
From: Carsten H. (T. R. <ra...@ra...> - 2011-03-25 07:22:27
|
On Wed, 23 Mar 2011 08:19:13 -0700 Daniel Juyung Seo <seo...@gm...> said: you're going to hate me :) you did go the right way - theme defines default, code can override... BUT.. you are ALSO missing a fit POLICY. you are fitting just N items in the visible region. i think... you are missing the ability to say "fit as many items ads you can" either based on largest item in list (homogeneous layout in the box) or have all items a different size (actually i might argue that this is dubiously useful except maybe in a case where MOST items are small and 1 or 2 are longer eg a list like: 1,2,3,4,5,NONE). so THEME should provide the default FIT policy (fixed count, best fit, compact fit). fixed count uses the theme number defined as you did already and code can override that, and other policies as above. also code should be allowed to override this too. (and yes a horizontal scrolling list of items where they change size horizontally is not that great as gustavo mentioned... but i know that you didn't design the widget, so not a lot of use going on about that - BUT his point implies that we should have a vertical diskselector mode too... use that for horizontally expanding items, and vice-versa). > I attached a screen shot :) > This is a screen shot from elementary_test "Disk Selector" which cnook > attached. > > Btw, cnook, I have one comment. > _item_click_cb()'s parameter is wrong. > Please check elm_diskselector.c code. > > elm_diskselector.c: In function ‘_item_new’: > elm_diskselector.c:137: warning: passing argument 4 of > ‘edje_object_signal_callback_add’ f > rom incompatible pointer type > /usr/local/include/edje-1/Edje.h:550: note: expected ‘Edje_Signal_Cb’ > but argument is of t > ype ‘void (*)(void *, struct Evas_Object *, void *)’ > > Thanks. > Daniel Juyung Seo (SeoZ) > > > > > On Wed, Mar 23, 2011 at 7:15 AM, Gustavo Sverzut Barbieri > <bar...@pr...> wrote: > > On Wed, Mar 23, 2011 at 1:54 PM, cnook <kim...@gm...> wrote: > >> Dear All, > >> > >> Thanks for your response. > >> > >> I have attached "elm_diskselector" patch using API and getting default > >> value from theme. > >> But the default value from "elementary/themes/default.edc" is applied only. > >> If user wants new default value from his/her own theme file, it will not be > >> applied. > >> > >> > >> Why I have changed like this.. because there is one case I worry about > > > > > > Do you have the screenshot? Nobody replied to my mail. > > > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: bar...@gm... > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > > ------------------------------------------------------------------------------ > > Enable your software for Intel(R) Active Management Technology to meet the > > growing manageability and security demands of your customers. Businesses > > are taking advantage of Intel(R) vPro (TM) technology - will your software > > be a part of the solution? Download the Intel(R) Manageability Checker > > today! http://p.sf.net/sfu/intel-dev2devmar > > _______________________________________________ > > enlightenment-devel mailing list > > enl...@li... > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |
From: cnook <kim...@gm...> - 2011-03-28 03:04:26
Attachments:
elm_diskselector_both_theme_and_api.diff
|
Hi All, Thanks for your response and suggestion always. I have attached new patch file which has following modification. - remove warning message - support setting by theme and api Others are also reasonable suggestion, some of them especially vertical mode would be fine. But till now there is no design for that as raster mentioned. setting min/max "display item num" is reasonable also but user can set content size differently. So if elm_diskselector restrict its min/max "display item num", it would occur that user cannot set "display item num" more than max value even though there is enough space. Thanks again. Sincerely, Shinwoo Kim. 2011/3/25 Carsten Haitzler <ra...@ra...> > On Wed, 23 Mar 2011 08:19:13 -0700 Daniel Juyung Seo <seo...@gm... > > > said: > > you're going to hate me :) > > you did go the right way - theme defines default, code can override... > BUT.. > you are ALSO missing a fit POLICY. you are fitting just N items in the > visible > region. i think... you are missing the ability to say "fit as many items > ads > you can" either based on largest item in list (homogeneous layout in the > box) > or have all items a different size (actually i might argue that this is > dubiously useful except maybe in a case where MOST items are small and 1 or > 2 > are longer eg a list like: 1,2,3,4,5,NONE). > > so THEME should provide the default FIT policy (fixed count, best fit, > compact > fit). fixed count uses the theme number defined as you did already and code > can > override that, and other policies as above. also code should be allowed to > override this too. > > (and yes a horizontal scrolling list of items where they change size > horizontally is not that great as gustavo mentioned... but i know that you > didn't design the widget, so not a lot of use going on about that - BUT his > point implies that we should have a vertical diskselector mode too... use > that > for horizontally expanding items, and vice-versa). > > > I attached a screen shot :) > > This is a screen shot from elementary_test "Disk Selector" which cnook > > attached. > > > > Btw, cnook, I have one comment. > > _item_click_cb()'s parameter is wrong. > > Please check elm_diskselector.c code. > > > > elm_diskselector.c: In function ‘_item_new’: > > elm_diskselector.c:137: warning: passing argument 4 of > > ‘edje_object_signal_callback_add’ f > > rom incompatible pointer type > > /usr/local/include/edje-1/Edje.h:550: note: expected ‘Edje_Signal_Cb’ > > but argument is of t > > ype ‘void (*)(void *, struct Evas_Object *, void *)’ > > > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > > > > > > > On Wed, Mar 23, 2011 at 7:15 AM, Gustavo Sverzut Barbieri > > <bar...@pr...> wrote: > > > On Wed, Mar 23, 2011 at 1:54 PM, cnook <kim...@gm...> wrote: > > >> Dear All, > > >> > > >> Thanks for your response. > > >> > > >> I have attached "elm_diskselector" patch using API and getting default > > >> value from theme. > > >> But the default value from "elementary/themes/default.edc" is applied > only. > > >> If user wants new default value from his/her own theme file, it will > not be > > >> applied. > > >> > > >> > > >> Why I have changed like this.. because there is one case I worry > about > > > > > > > > > Do you have the screenshot? Nobody replied to my mail. > > > > > > > > > -- > > > Gustavo Sverzut Barbieri > > > http://profusion.mobi embedded systems > > > -------------------------------------- > > > MSN: bar...@gm... > > > Skype: gsbarbieri > > > Mobile: +55 (19) 9225-2202 > > > > > > > ------------------------------------------------------------------------------ > > > Enable your software for Intel(R) Active Management Technology to meet > the > > > growing manageability and security demands of your customers. > Businesses > > > are taking advantage of Intel(R) vPro (TM) technology - will your > software > > > be a part of the solution? Download the Intel(R) Manageability Checker > > > today! http://p.sf.net/sfu/intel-dev2devmar > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enl...@li... > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ra...@ra... > > |
From: cnook <kim...@gm...> - 2011-03-31 03:22:35
|
Hi All, Please check latest patch set. Sincerely, Shinwoo Kim. 2011/3/28 cnook <kim...@gm...> > Hi All, > > Thanks for your response and suggestion always. > I have attached new patch file which has following modification. > > - remove warning message > - support setting by theme and api > > Others are also reasonable suggestion, some of them especially vertical > mode would be fine. But till now there is no design for that as raster > mentioned. setting min/max "display item num" is reasonable also but user > can set content size differently. So if elm_diskselector restrict its > min/max "display item num", it would occur that user cannot set "display > item num" more than max value even though there is enough space. > > Thanks again. > > Sincerely, > Shinwoo Kim. > > > 2011/3/25 Carsten Haitzler <ra...@ra...> > >> On Wed, 23 Mar 2011 08:19:13 -0700 Daniel Juyung Seo < >> seo...@gm...> >> said: >> >> you're going to hate me :) >> >> you did go the right way - theme defines default, code can override... >> BUT.. >> you are ALSO missing a fit POLICY. you are fitting just N items in the >> visible >> region. i think... you are missing the ability to say "fit as many items >> ads >> you can" either based on largest item in list (homogeneous layout in the >> box) >> or have all items a different size (actually i might argue that this is >> dubiously useful except maybe in a case where MOST items are small and 1 >> or 2 >> are longer eg a list like: 1,2,3,4,5,NONE). >> >> so THEME should provide the default FIT policy (fixed count, best fit, >> compact >> fit). fixed count uses the theme number defined as you did already and >> code can >> override that, and other policies as above. also code should be allowed to >> override this too. >> >> (and yes a horizontal scrolling list of items where they change size >> horizontally is not that great as gustavo mentioned... but i know that you >> didn't design the widget, so not a lot of use going on about that - BUT >> his >> point implies that we should have a vertical diskselector mode too... use >> that >> for horizontally expanding items, and vice-versa). >> >> > I attached a screen shot :) >> > This is a screen shot from elementary_test "Disk Selector" which cnook >> > attached. >> > >> > Btw, cnook, I have one comment. >> > _item_click_cb()'s parameter is wrong. >> > Please check elm_diskselector.c code. >> > >> > elm_diskselector.c: In function ‘_item_new’: >> > elm_diskselector.c:137: warning: passing argument 4 of >> > ‘edje_object_signal_callback_add’ f >> > rom incompatible pointer type >> > /usr/local/include/edje-1/Edje.h:550: note: expected ‘Edje_Signal_Cb’ >> > but argument is of t >> > ype ‘void (*)(void *, struct Evas_Object *, void *)’ >> > >> > Thanks. >> > Daniel Juyung Seo (SeoZ) >> > >> > >> > >> > >> > On Wed, Mar 23, 2011 at 7:15 AM, Gustavo Sverzut Barbieri >> > <bar...@pr...> wrote: >> > > On Wed, Mar 23, 2011 at 1:54 PM, cnook <kim...@gm...> wrote: >> > >> Dear All, >> > >> >> > >> Thanks for your response. >> > >> >> > >> I have attached "elm_diskselector" patch using API and getting >> default >> > >> value from theme. >> > >> But the default value from "elementary/themes/default.edc" is applied >> only. >> > >> If user wants new default value from his/her own theme file, it will >> not be >> > >> applied. >> > >> >> > >> >> > >> Why I have changed like this.. because there is one case I worry >> about >> > > >> > > >> > > Do you have the screenshot? Nobody replied to my mail. >> > > >> > > >> > > -- >> > > Gustavo Sverzut Barbieri >> > > http://profusion.mobi embedded systems >> > > -------------------------------------- >> > > MSN: bar...@gm... >> > > Skype: gsbarbieri >> > > Mobile: +55 (19) 9225-2202 >> > > >> > > >> ------------------------------------------------------------------------------ >> > > Enable your software for Intel(R) Active Management Technology to meet >> the >> > > growing manageability and security demands of your customers. >> Businesses >> > > are taking advantage of Intel(R) vPro (TM) technology - will your >> software >> > > be a part of the solution? Download the Intel(R) Manageability Checker >> > > today! http://p.sf.net/sfu/intel-dev2devmar >> > > _______________________________________________ >> > > enlightenment-devel mailing list >> > > enl...@li... >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> >> >> -- >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> The Rasterman (Carsten Haitzler) ra...@ra... >> >> > |
From: Daniel J. S. <seo...@gm...> - 2011-04-04 04:57:46
|
No comments? I guess we already discussed this heavily. If there is no comments in a couple of days, I'll commit this. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Mar 31, 2011 at 12:22 PM, cnook <kim...@gm...> wrote: > Hi All, > > Please check latest patch set. > > Sincerely, > Shinwoo Kim. > > > 2011/3/28 cnook <kim...@gm...> > >> Hi All, >> >> Thanks for your response and suggestion always. >> I have attached new patch file which has following modification. >> >> - remove warning message >> - support setting by theme and api >> >> Others are also reasonable suggestion, some of them especially vertical >> mode would be fine. But till now there is no design for that as raster >> mentioned. setting min/max "display item num" is reasonable also but user >> can set content size differently. So if elm_diskselector restrict its >> min/max "display item num", it would occur that user cannot set "display >> item num" more than max value even though there is enough space. >> >> Thanks again. >> >> Sincerely, >> Shinwoo Kim. >> >> >> 2011/3/25 Carsten Haitzler <ra...@ra...> >> >>> On Wed, 23 Mar 2011 08:19:13 -0700 Daniel Juyung Seo < >>> seo...@gm...> >>> said: >>> >>> you're going to hate me :) >>> >>> you did go the right way - theme defines default, code can override... >>> BUT.. >>> you are ALSO missing a fit POLICY. you are fitting just N items in the >>> visible >>> region. i think... you are missing the ability to say "fit as many items >>> ads >>> you can" either based on largest item in list (homogeneous layout in the >>> box) >>> or have all items a different size (actually i might argue that this is >>> dubiously useful except maybe in a case where MOST items are small and 1 >>> or 2 >>> are longer eg a list like: 1,2,3,4,5,NONE). >>> >>> so THEME should provide the default FIT policy (fixed count, best fit, >>> compact >>> fit). fixed count uses the theme number defined as you did already and >>> code can >>> override that, and other policies as above. also code should be allowed >>> to >>> override this too. >>> >>> (and yes a horizontal scrolling list of items where they change size >>> horizontally is not that great as gustavo mentioned... but i know that >>> you >>> didn't design the widget, so not a lot of use going on about that - BUT >>> his >>> point implies that we should have a vertical diskselector mode too... use >>> that >>> for horizontally expanding items, and vice-versa). >>> >>> > I attached a screen shot :) >>> > This is a screen shot from elementary_test "Disk Selector" which cnook >>> > attached. >>> > >>> > Btw, cnook, I have one comment. >>> > _item_click_cb()'s parameter is wrong. >>> > Please check elm_diskselector.c code. >>> > >>> > elm_diskselector.c: In function ‘_item_new’: >>> > elm_diskselector.c:137: warning: passing argument 4 of >>> > ‘edje_object_signal_callback_add’ f >>> > rom incompatible pointer type >>> > /usr/local/include/edje-1/Edje.h:550: note: expected ‘Edje_Signal_Cb’ >>> > but argument is of t >>> > ype ‘void (*)(void *, struct Evas_Object *, void *)’ >>> > >>> > Thanks. >>> > Daniel Juyung Seo (SeoZ) >>> > >>> > >>> > >>> > >>> > On Wed, Mar 23, 2011 at 7:15 AM, Gustavo Sverzut Barbieri >>> > <bar...@pr...> wrote: >>> > > On Wed, Mar 23, 2011 at 1:54 PM, cnook <kim...@gm...> wrote: >>> > >> Dear All, >>> > >> >>> > >> Thanks for your response. >>> > >> >>> > >> I have attached "elm_diskselector" patch using API and getting >>> default >>> > >> value from theme. >>> > >> But the default value from "elementary/themes/default.edc" is >>> applied only. >>> > >> If user wants new default value from his/her own theme file, it will >>> not be >>> > >> applied. >>> > >> >>> > >> >>> > >> Why I have changed like this.. because there is one case I worry >>> about >>> > > >>> > > >>> > > Do you have the screenshot? Nobody replied to my mail. >>> > > >>> > > >>> > > -- >>> > > Gustavo Sverzut Barbieri >>> > > http://profusion.mobi embedded systems >>> > > -------------------------------------- >>> > > MSN: bar...@gm... >>> > > Skype: gsbarbieri >>> > > Mobile: +55 (19) 9225-2202 >>> > > >>> > > >>> ------------------------------------------------------------------------------ >>> > > Enable your software for Intel(R) Active Management Technology to >>> meet the >>> > > growing manageability and security demands of your customers. >>> Businesses >>> > > are taking advantage of Intel(R) vPro (TM) technology - will your >>> software >>> > > be a part of the solution? Download the Intel(R) Manageability >>> Checker >>> > > today! http://p.sf.net/sfu/intel-dev2devmar >>> > > _______________________________________________ >>> > > enlightenment-devel mailing list >>> > > enl...@li... >>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> > > >>> >>> >>> -- >>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >>> The Rasterman (Carsten Haitzler) ra...@ra... >>> >>> >> > |
From: Carsten H. (T. R. <ra...@ra...> - 2011-04-04 06:08:20
|
On Mon, 28 Mar 2011 12:04:19 +0900 cnook <kim...@gm...> said: too many problems with this patch :( can you fix the below and re-submit? 1. fails. malformed patch even. patching file src/lib/elm_diskselector.c Hunk #5 FAILED at 136. Hunk #19 succeeded at 780 with fuzz 2. 1 out of 29 hunks FAILED -- saving rejects to file src/lib/elm_diskselector.c.rej patching file src/lib/Elementary.h.in patching file src/bin/test_diskselector.c patching file data/themes/default.edc patch: **** malformed patch at line 553: 2. math relying on operator precedence rather than being explicit with ()'s: + evas_object_resize(wd->main_box, w / wd->display_item_num * (wd->item_count + CEIL(wd->display_item_num) * 2), h); + evas_object_resize(wd->main_box, w / wd->display_item_num * (wd->item_count + CEIL(wd->display_item_num)), h); 3. divide by 0 waiting to happen: + (int)(w / wd->display_item_num), 0); (you never check the return of atoi so it can happily return 0 or theme could literally use a 0) 4. no space between if and (): + if(!wd->display_item_num_by_api) 5. no check of atoi result to stop invalid values (<= 0): + if (str) wd->display_item_num = atoi(str); 6. no check of atoi() to check for <= -2: + if (str) wd->minw = atoi(str); + if (str) wd->minh = atoi(str); 7. no check of atoi result to stop invalid values: + if (str) wd->display_item_num = atoi(str); 8. use: if (!strcmp(...)): + if (strcmp(item->label, it->label) == 0) edje_object_signal_emit (item->base.view, "elm,state,selected", "elm"); 9. add space between void and * and no space between ) and it->: + if (it->func) it->func((void*) it->base.data, it->base.widget, it); 10. more operator precedence reliance here. use ()'s to collect statements: + if (x > w / wd->display_item_num * (wd->item_count + (wd->display_item_num % 2))) + x - w / wd->display_item_num * wd->item_count, + x + w / wd->display_item_num * wd->item_count, 11. add space between for and (: + for(i = 2; i < CEIL(wd->display_item_num); i++) + for(i = 3; i <= CEIL(wd->display_item_num); i++) + for(i = 2; i < CEIL(wd->display_item_num); i++) + for(i = 3; i <= CEIL(wd->display_item_num); i++) + for(idx = 0; idx < sizeof(month_list) / sizeof(month_list[0]); idx++) + for(idx = 1; idx < 31; idx++) 12. please declare vars at top of function or {} section where you can: + char *month_list[] = { + char date[3]; > Hi All, > > Thanks for your response and suggestion always. > I have attached new patch file which has following modification. > > - remove warning message > - support setting by theme and api > > Others are also reasonable suggestion, some of them especially vertical mode > would be fine. But till now there is no design for that as raster mentioned. > setting min/max "display item num" is reasonable also but user can set > content size differently. So if elm_diskselector restrict its min/max > "display item num", it would occur that user cannot set "display item num" > more than max value even though there is enough space. > > Thanks again. > > Sincerely, > Shinwoo Kim. > > 2011/3/25 Carsten Haitzler <ra...@ra...> > > > On Wed, 23 Mar 2011 08:19:13 -0700 Daniel Juyung Seo <seo...@gm... > > > > > said: > > > > you're going to hate me :) > > > > you did go the right way - theme defines default, code can override... > > BUT.. > > you are ALSO missing a fit POLICY. you are fitting just N items in the > > visible > > region. i think... you are missing the ability to say "fit as many items > > ads > > you can" either based on largest item in list (homogeneous layout in the > > box) > > or have all items a different size (actually i might argue that this is > > dubiously useful except maybe in a case where MOST items are small and 1 or > > 2 > > are longer eg a list like: 1,2,3,4,5,NONE). > > > > so THEME should provide the default FIT policy (fixed count, best fit, > > compact > > fit). fixed count uses the theme number defined as you did already and code > > can > > override that, and other policies as above. also code should be allowed to > > override this too. > > > > (and yes a horizontal scrolling list of items where they change size > > horizontally is not that great as gustavo mentioned... but i know that you > > didn't design the widget, so not a lot of use going on about that - BUT his > > point implies that we should have a vertical diskselector mode too... use > > that > > for horizontally expanding items, and vice-versa). > > > > > I attached a screen shot :) > > > This is a screen shot from elementary_test "Disk Selector" which cnook > > > attached. > > > > > > Btw, cnook, I have one comment. > > > _item_click_cb()'s parameter is wrong. > > > Please check elm_diskselector.c code. > > > > > > elm_diskselector.c: In function ‘_item_new’: > > > elm_diskselector.c:137: warning: passing argument 4 of > > > ‘edje_object_signal_callback_add’ f > > > rom incompatible pointer type > > > /usr/local/include/edje-1/Edje.h:550: note: expected ‘Edje_Signal_Cb’ > > > but argument is of t > > > ype ‘void (*)(void *, struct Evas_Object *, void *)’ > > > > > > Thanks. > > > Daniel Juyung Seo (SeoZ) > > > > > > > > > > > > > > > On Wed, Mar 23, 2011 at 7:15 AM, Gustavo Sverzut Barbieri > > > <bar...@pr...> wrote: > > > > On Wed, Mar 23, 2011 at 1:54 PM, cnook <kim...@gm...> wrote: > > > >> Dear All, > > > >> > > > >> Thanks for your response. > > > >> > > > >> I have attached "elm_diskselector" patch using API and getting default > > > >> value from theme. > > > >> But the default value from "elementary/themes/default.edc" is applied > > only. > > > >> If user wants new default value from his/her own theme file, it will > > not be > > > >> applied. > > > >> > > > >> > > > >> Why I have changed like this.. because there is one case I worry > > about > > > > > > > > > > > > Do you have the screenshot? Nobody replied to my mail. > > > > > > > > > > > > -- > > > > Gustavo Sverzut Barbieri > > > > http://profusion.mobi embedded systems > > > > -------------------------------------- > > > > MSN: bar...@gm... > > > > Skype: gsbarbieri > > > > Mobile: +55 (19) 9225-2202 > > > > > > > > > > ------------------------------------------------------------------------------ > > > > Enable your software for Intel(R) Active Management Technology to meet > > the > > > > growing manageability and security demands of your customers. > > Businesses > > > > are taking advantage of Intel(R) vPro (TM) technology - will your > > software > > > > be a part of the solution? Download the Intel(R) Manageability Checker > > > > today! http://p.sf.net/sfu/intel-dev2devmar > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > enl...@li... > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ra...@ra... > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |