From: Gustavo S. B. <bar...@gm...> - 2007-05-27 18:44:44
|
On 5/27/07, Enlightenment CVS <no...@cv...> wrote: > Enlightenment CVS committal > > Author : doursse > Project : e17 > Module : libs/evas > > Dir : e17/libs/evas/src/modules/engines/software_ddraw > > > > > Log Message: > Directory /cvs/e/e17/libs/evas/src/modules/engines/software_ddraw added to the repository Great, since we have some designers here that just have windows or mac, it would be great to provide binaries of evas/ecore/edje so they can test their EDC files more easily. :-) [I have no windows or windows development tools, that's why the windows binaries] -- Gustavo Sverzut Barbieri -------------------------------------- Jabber: bar...@gm... MSN: bar...@gm... ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 |
From: Gustavo S. B. <bar...@gm...> - 2007-08-19 17:02:50
|
On 8/19/07, Enlightenment CVS <no...@cv...> wrote: > Enlightenment CVS committal > > Author : doursse > Project : e17 > Module : libs/evas > > Dir : e17/libs/evas/src/lib/engines/common > > > Modified Files: > evas_tiler.c > > > Log Message: > use standard syntax when initializing structures instead of specific gcc one > > =================================================================== > RCS file: /cvs/e/e17/libs/evas/src/lib/engines/common/evas_tiler.c,v > retrieving revision 1.16 > retrieving revision 1.17 > diff -u -3 -r1.16 -r1.17 > --- evas_tiler.c 8 Jun 2007 00:03:56 -0000 1.16 > +++ evas_tiler.c 19 Aug 2007 06:21:23 -0000 1.17 > @@ -2,8 +2,8 @@ > > #ifdef EVAS_RECT_SPLIT > > -static const list_node_t list_node_zeroed = {.next = NULL}; > -static const list_t list_zeroed = {.head = NULL, .tail = NULL}; > +static const list_node_t list_node_zeroed = { NULL }; > +static const list_t list_zeroed = { NULL, NULL }; > > > typedef struct list_node_pool > @@ -13,9 +13,7 @@ > int max; > } list_node_pool_t; > > -static list_node_pool_t list_node_pool = { > - .node = NULL, .len = 0, .max = 1024 > -}; > +static list_node_pool_t list_node_pool = { NULL, 0, 1024 }; > > void > rect_list_node_pool_set_max(int max) No this is wrong, it's in C99 standard and is not a GCC extension: http://home.tiscalinet.ch/t_wolf/tw/c/c9x_changes.html I want to keep them since it help to avoid errors and helps readability. -- Gustavo Sverzut Barbieri -------------------------------------- Jabber: bar...@gm... MSN: bar...@gm... ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 |
From: Vincent T. <vt...@un...> - 2007-08-19 17:15:39
|
On Sun, 19 Aug 2007, Gustavo Sverzut Barbieri wrote: >> Log Message: >> use standard syntax when initializing structures instead of specific gcc one >> >> =================================================================== >> RCS file: /cvs/e/e17/libs/evas/src/lib/engines/common/evas_tiler.c,v >> retrieving revision 1.16 >> retrieving revision 1.17 >> diff -u -3 -r1.16 -r1.17 >> --- evas_tiler.c 8 Jun 2007 00:03:56 -0000 1.16 >> +++ evas_tiler.c 19 Aug 2007 06:21:23 -0000 1.17 >> @@ -2,8 +2,8 @@ >> >> #ifdef EVAS_RECT_SPLIT >> >> -static const list_node_t list_node_zeroed = {.next = NULL}; >> -static const list_t list_zeroed = {.head = NULL, .tail = NULL}; >> +static const list_node_t list_node_zeroed = { NULL }; >> +static const list_t list_zeroed = { NULL, NULL }; >> >> >> typedef struct list_node_pool >> @@ -13,9 +13,7 @@ >> int max; >> } list_node_pool_t; >> >> -static list_node_pool_t list_node_pool = { >> - .node = NULL, .len = 0, .max = 1024 >> -}; >> +static list_node_pool_t list_node_pool = { NULL, 0, 1024 }; >> >> void >> rect_list_node_pool_set_max(int max) > > No this is wrong, it's in C99 standard and is not a GCC extension: > > http://home.tiscalinet.ch/t_wolf/tw/c/c9x_changes.html > > I want to keep them since it help to avoid errors and helps readability. avoid errors ? one structure has only 1 member, another 2 and another 3, the last one being declared just above. That's not a big deal to maintain. also, what convinces me to change that is that a guy, that wants to use evas on win ce, with vc++, can't compile evas_tiler with that compiler. I agree that vc++ is a bad compiler, but the changes are really minor. Vincent |
From: Gustavo S. B. <bar...@gm...> - 2007-08-19 17:22:20
|
On 8/19/07, Vincent Torri <vt...@un...> wrote: > > > On Sun, 19 Aug 2007, Gustavo Sverzut Barbieri wrote: > >> Log Message: > >> use standard syntax when initializing structures instead of specific gcc one > >> > >> =================================================================== > >> RCS file: /cvs/e/e17/libs/evas/src/lib/engines/common/evas_tiler.c,v > >> retrieving revision 1.16 > >> retrieving revision 1.17 > >> diff -u -3 -r1.16 -r1.17 > >> --- evas_tiler.c 8 Jun 2007 00:03:56 -0000 1.16 > >> +++ evas_tiler.c 19 Aug 2007 06:21:23 -0000 1.17 > >> @@ -2,8 +2,8 @@ > >> > >> #ifdef EVAS_RECT_SPLIT > >> > >> -static const list_node_t list_node_zeroed = {.next = NULL}; > >> -static const list_t list_zeroed = {.head = NULL, .tail = NULL}; > >> +static const list_node_t list_node_zeroed = { NULL }; > >> +static const list_t list_zeroed = { NULL, NULL }; > >> > >> > >> typedef struct list_node_pool > >> @@ -13,9 +13,7 @@ > >> int max; > >> } list_node_pool_t; > >> > >> -static list_node_pool_t list_node_pool = { > >> - .node = NULL, .len = 0, .max = 1024 > >> -}; > >> +static list_node_pool_t list_node_pool = { NULL, 0, 1024 }; > >> > >> void > >> rect_list_node_pool_set_max(int max) > > > > No this is wrong, it's in C99 standard and is not a GCC extension: > > > > http://home.tiscalinet.ch/t_wolf/tw/c/c9x_changes.html > > > > I want to keep them since it help to avoid errors and helps readability. > > avoid errors ? one structure has only 1 member, another 2 and another > 3, the last one being declared just above. That's not a big deal to > maintain. > > also, what convinces me to change that is that a guy, that wants to use > evas on win ce, with vc++, can't compile evas_tiler with that compiler. I > agree that vc++ is a bad compiler, but the changes are really minor. don't this work on VC++? In this case, ok, keep the change. About maintainance, in this case it doesn't matter much, but with bigger structures it can help, so I'd like to see more of that in E (if it don't break VC++, of course) -- Gustavo Sverzut Barbieri -------------------------------------- Jabber: bar...@gm... MSN: bar...@gm... ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 |
From: Vincent T. <vt...@un...> - 2007-08-19 18:27:04
|
On Sun, 19 Aug 2007, Gustavo Sverzut Barbieri wrote: > About maintainance, in this case it doesn't matter much, but with > bigger structures it can help, so I'd like to see more of that in E > (if it don't break VC++, of course) as having a windows manager (in the X terminology) on Windows is not possible, i don't see any problem in using that syntax in e17 code. I would like to avoid that syntax in the core efl (eet, evas, ecore, embryo and edje), in the toolkits, and maybe in some other libs (emotion, epsilon and some in proto/) as they can be used with win ce. Vincent |