From: Christopher M. <cpm...@co...> - 2008-12-22 07:44:04
|
Don't know about everyone else, but I use ecore_list when I can.... dh Enlightenment SVN wrote: > Log: > Fix segfault when double freeing a string. > > This fix makes it work again. However, ecore plugin should really be rewritten > or we should start considering eina_module instead. > > Author: ulisses > Date: 2008-12-21 18:30:17 -0800 (Sun, 21 Dec 2008) > New Revision: 38275 > > Modified: > trunk/ecore/src/lib/ecore/ecore_plugin.c > > Modified: trunk/ecore/src/lib/ecore/ecore_plugin.c > =================================================================== > --- trunk/ecore/src/lib/ecore/ecore_plugin.c 2008-12-22 00:23:41 UTC (rev 38274) > +++ trunk/ecore/src/lib/ecore/ecore_plugin.c 2008-12-22 02:30:17 UTC (rev 38275) > @@ -249,6 +249,6 @@ > static Eina_Bool > _hash_keys(const Eina_Hash *hash, const char *key, void *list) > { > - ecore_list_append(list, key); > + ecore_list_append(list, strdup(key)); > return EINA_TRUE; > } > > > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-svn mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > |
From: Cedric B. <ced...@fr...> - 2008-12-22 09:38:24
|
On Mon, Dec 22, 2008 at 3:30 AM, Enlightenment SVN <no-...@en...> wrote: > Log: > Fix segfault when double freeing a string. > > This fix makes it work again. However, ecore plugin should really be rewritten > or we should start considering eina_module instead. The plan is to one day use eina_module for ecore_plugin as ecore_plugin is a little bit more highe level than eina_module. It's just on the TODO, just need someone to take the task... -- Cedric BAIL |
From: Ulisses F. <ul...@pr...> - 2008-12-22 13:23:53
|
On Mon, Dec 22, 2008 at 7:38 AM, Cedric BAIL <ced...@fr...> wrote: > On Mon, Dec 22, 2008 at 3:30 AM, Enlightenment SVN > <no-...@en...> wrote: >> Log: >> Fix segfault when double freeing a string. >> >> This fix makes it work again. However, ecore plugin should really be rewritten >> or we should start considering eina_module instead. > > The plan is to one day use eina_module for ecore_plugin as > ecore_plugin is a little bit more highe level than eina_module. It's > just on the TODO, just need someone to take the task... Yep, we need to stop replicating this kind of code too (plugin support) and have a good implementation that anyone can use. Ecore plugin was broken for some days and nobody noticed which makes me think almost nobody uses it (exception is ecore_imf which we use for Canola). -- Ulisses Furquim ProFUSION embedded systems http://profusion.mobi |