From: rustyBSD <rus...@gm...> - 2012-12-01 07:02:00
Attachments:
tempget.c.diff
|
Hi, just a patch to avoid temperature/tempget.c: In function 'init': temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' from incompatible pointer type temperature/tempget.c: In function 'check': temperature/tempget.c:379: warning: passing argument 4 of 'sysctl' from incompatible pointer type this file should be formatted thanks |
From: Vincent T. <vin...@gm...> - 2012-12-01 07:22:46
|
in svn, thanks Vincent On Sat, Dec 1, 2012 at 8:01 AM, rustyBSD <rus...@gm...> wrote: > Hi, > just a patch to avoid > > temperature/tempget.c: In function 'init': > temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' from incompatible pointer type > temperature/tempget.c: In function 'check': > temperature/tempget.c:379: warning: passing argument 4 of 'sysctl' from incompatible pointer type > > this file should be formatted > > thanks > > ------------------------------------------------------------------------------ > Keep yourself connected to Go Parallel: > INSIGHTS What's next for parallel hardware, programming and related areas? > Interviews and blogs by thought leaders keep you ahead of the curve. > http://goparallel.sourceforge.net > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > |
From: Michael B. <mic...@gm...> - 2012-12-01 08:42:49
|
On Sat, 01 Dec 2012 08:01:28 +0100 rustyBSD <rus...@gm...> wrote: > Hi, > just a patch to avoid > > temperature/tempget.c: In function 'init': > temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' from incompatible pointer type > temperature/tempget.c: In function 'check': > temperature/tempget.c:379: warning: passing argument 4 of 'sysctl' from incompatible pointer type > > this file should be formatted > > thanks formatting done |
From: rustyBSD <rus...@gm...> - 2012-12-01 09:03:37
Attachments:
tempget.c.diff
|
Le 01/12/2012 09:41, Michael Blumenkrantz a écrit : > On Sat, 01 Dec 2012 08:01:28 +0100 > rustyBSD <rus...@gm...> wrote: > >> Hi, >> just a patch to avoid >> >> temperature/tempget.c: In function 'init': >> temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' from incompatible pointer type >> temperature/tempget.c: In function 'check': >> temperature/tempget.c:379: warning: passing argument 4 of 'sysctl' from incompatible pointer type >> >> this file should be formatted >> >> thanks > > formatting done > We can also fix leaks. I. Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets() already does that II. Ensure file descriptors are closed before 'goto error' III.We don't need to nullcheck before freeing a buf, as it's already done by free() |
From: rustyBSD <rus...@gm...> - 2012-12-07 21:19:09
|
Le 01/12/2012 10:02, rustyBSD a écrit : > We can also fix leaks. > > > I. Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets() > already does that > > II. Ensure file descriptors are closed before 'goto error' > > III.We don't need to nullcheck before freeing a buf, as it's > already done by free() So, what's new ? |
From: Maxime V. <rus...@gm...> - 2012-12-13 20:18:01
Attachments:
tempget.c.diff
|
Hum, I sent it two weeks ago I. Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets() already does that II. Ensure file descriptors are closed before 'goto error' III.We don't need to nullcheck before freeing a buf, as it's already done by free() |
From: Michael B. <mic...@gm...> - 2012-12-13 21:32:31
|
On Thu, 13 Dec 2012 21:04:51 +0100 Maxime Villard <rus...@gm...> wrote: > Hum, I sent it two weeks ago > > > I. Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets() > already does that > > II. Ensure file descriptors are closed before 'goto error' > > III.We don't need to nullcheck before freeing a buf, as it's > already done by free() hi, sorry for taking so long to get to your patch. would it be possible for you to rebase it against current e? I'll get it in right after. |
From: Carsten H. (T. R. <ra...@ra...> - 2012-12-14 05:29:16
|
On Thu, 13 Dec 2012 21:04:51 +0100 Maxime Villard <rus...@gm...> said: i put in just fixed for the FILE * leak here on error - the rest i kept. i did it differently tho. > Hum, I sent it two weeks ago > > > I. Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets() > already does that > > II. Ensure file descriptors are closed before 'goto error' > > III.We don't need to nullcheck before freeing a buf, as it's > already done by free() -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |
From: Maxime V. <rus...@gm...> - 2012-12-15 07:19:33
|
Le 14/12/2012 06:29, Carsten Haitzler (The Rasterman) a écrit : > i put in just fixed for the FILE * leak here on error - > the rest i kept. Why ? |
From: Carsten H. (T. R. <ra...@ra...> - 2012-12-15 07:44:45
|
On Sat, 15 Dec 2012 08:19:24 +0100 Maxime Villard <rus...@gm...> said: > Le 14/12/2012 06:29, Carsten Haitzler (The Rasterman) a écrit : > > i put in just fixed for the FILE * leak here on error - > > the rest i kept. > > Why ? because i didnt use your patch at all - i just fixed the file leak that it pointed out. mike asked for you to provie a new patch against current as i assume it didnt apply... so i just fixed the bug there. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |
From: Maxime V. <rus...@gm...> - 2012-12-15 07:43:10
Attachments:
tempget.c.diff
|
Le 15/12/2012 08:19, Maxime Villard a écrit : > Le 14/12/2012 06:29, Carsten Haitzler (The Rasterman) a écrit : >> > i put in just fixed for the FILE * leak here on error - >> > the rest i kept. > Why ? I would also move some {free(x); x = null} to E_FREE. Patch joined. |
From: Maxime V. <rus...@gm...> - 2012-12-15 11:58:13
Attachments:
tempget.c.diff
|
Le 15/12/2012 08:35, Carsten Haitzler (The Rasterman) a écrit : > because i didnt use your patch at all - i just fixed the file leak that it > pointed out. mike asked for you to provie a new patch against current as i > assume it didnt apply... so i just fixed the bug there. I don't know if you noticed, but I sent a patch before your answer. -------- Message original -------- Sujet: Re: [E-devel] [e] [patch] Leak (was FreeBSD patch) Date : Sat, 15 Dec 2012 08:43:03 +0100 De : Maxime Villard <rus...@gm...> Répondre à : Enlightenment developer list <enl...@li...> Pour : enl...@li... Le 15/12/2012 08:19, Maxime Villard a écrit : > Le 14/12/2012 06:29, Carsten Haitzler (The Rasterman) a écrit : >> > i put in just fixed for the FILE * leak here on error - >> > the rest i kept. > Why ? I would also move some {free(x); x = null} to E_FREE. Patch joined. |
From: Carsten H. (T. R. <ra...@ra...> - 2012-12-15 14:43:08
|
On Sat, 15 Dec 2012 08:43:03 +0100 Maxime Villard <rus...@gm...> said: > Le 15/12/2012 08:19, Maxime Villard a écrit : > > Le 14/12/2012 06:29, Carsten Haitzler (The Rasterman) a écrit : > >> > i put in just fixed for the FILE * leak here on error - > >> > the rest i kept. > > Why ? > > I would also move some {free(x); x = null} to E_FREE. > > Patch joined. in svn. tnx! :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |