#749 Improvements to Transfer Settings Preferences

[Patrick Brunschwig]

Mail from dkg on the mailing list:

The dialog as a whole is too much text for most users to read, in this era of short attention spans. I recommend splitting it into three simple buttons, something like:

     [ Set up another Autocrypt e-mail app ]  (_What's_Autocrypt?_)

     [ Back up your Enigmail settings ]

     [ Restore Enigmail settings from backup ]

I'm imagining that What's_Autocrypt? would be a link that takes the
user to some explanatory page at https://autocrypt.org/ .

(obviously, if enigmail is not in a state to be able to initiate an
Autocrypt Setup Message, the first button should be disabled; perhaps
adding a tooltip or a "why is this disabled?" link would be friendly in
that situation)

Maybe with this setup, we can do away with all the rest of the text
in that pane entirely?

[Khushil Mistry]

Hey, I want to work on this Enhancement. Can you guide me little bit ?

[Patrick Brunschwig]

The dialog is found in pref-enigmail.xul, in the last tab (labelled "Transfer Settings").

The functionality is already there, what is required here is improving/rearranging the labels. You also might use this to learn how the Autocrypt Setup Message is created and used (which would have been my suggestion for the next step in any case ;-) ).

[Khushil Mistry]

I have gone through the source code for Transfer Settings as well as How Autocrypt Setup Message is and it is communicating to other devices. Now, I have fair idea about Autocrypt and little idea about how Autocrypt Message Setup is created. I am still digging in to figure out the whole Setup.

For this bug, should I remove all the descriptions and change the name of the Lable according to above recommendations and also add link to https://autocrypt.org/ ?

[Patrick Brunschwig]

Yes, I think you can remove the description entirely.

[Khushil Mistry]

Hey, I have few questions regarding coding standards. I have attached SS of my changes.

1 .What is Autocrypt is hardcoded here. Should I add it in enigmail.dtd in locale/en-US. Is there any need to add this Entity else where ?

1. Styling for Autocrypt is inlined. Where should I add it ?
2. I have removed decription. Should I remove it from enigmail.dtd also or keep it there for any future reference/use ?
3. Also, there is an issue : I have added <html:a> tag here. I want to redirect user to default browser from this link. Currently with target blank, it is happing. But is also opening a new Write a mail window. How can this issue can be solved ?</html:a>

[Patrick Brunschwig]

1. "What is" would certainly need to be translated, as this is different in every language. I'd therefore say yes, add "What is Autocrypt" to enigmail.dtd.
2. If possible add the styling in the XUL, not in the DTD. You will find a reference for the styling in the enigmailEeditIdentity.xul.
3. You can remove unused text from the DTD
4. Check enigmailEeditIdentity. I we try to open URLs in a browser window within Thunderbird.

[Khushil Mistry]

Hey, I have done required changes and checked on Thunderbird. Please review it.

[Patrick Brunschwig]

looks good upon a first glance

[Patrick Brunschwig]

committed to master - thanks.