#743 Remove OpenPGP Header from Enigmail

[Patrick Brunschwig]

The OpenPGP header has been superseeded by Autocrypt. We should remove it in Enigmail

[Khushil Mistry]

Hey, I want to work on this bug.
Can you guide me what should be done ? Which header is it referring to ?

[Patrick Brunschwig]

Enigmail may issue a header called "OpenPGP" upon sending a message. This task consists of the following steps in the sequence provided below:

1. remove the code that creates the header in enigmailMsgComposeOverlay.js
2. remove the dialog options that control this header. To get to this dialog, you need to 1st enable "Expert settings and menus" in the Enigmail Preferences. The dialog is then reachable via the Account Settings > OpenPGP security > Advanced.
3. remove the default setting in defaultPreferences.js

To test the current behaviour: follow the description in step 2 and enable the OpenPGP header. Then send an email to yourself and inspect the message source. You should then see that header being generated.

[Khushil Mistry]

Thanks for the description. I will work upon this.

[Khushil Mistry]

Removed OpenPGP Header from Enigmail

[Patrick Brunschwig]

Thanks for the patch, that looks good :-)

I have a functional and a technical nitpick:

• functional: as you removed the dialog entirely, there is no possibility anymore to change the default for "Attach my key to messages" (relating to the mail.identity.default.attachPgpKey option.
• technical: you need to remove the deleted files from ui/content/Makefile and from util/genxpi, otherwise building Enigmail will fail. You can try this by doing make clean first.

[Khushil Mistry]

Thanks for review.
What should I exactly do for functional nitpick ? Just remove the mail.identity.default.attachPgpKey from all the default option ?
Also, Should I make a patch for this new changes or have to combine them with above patch ?

[Patrick Brunschwig]

I think the mail.identity.default.attachPgpKey is useful - some users want it. I'd suggest you move it to the identity settings (enigmailEditIdentity.js|xul).

I'd prefer if you could combine everything in a single patch.

[Khushil Mistry]

Okay. Will Add Radio button for the same enigmailEditIdentity.js|xul.
Will make a combine Patch by end of the day.

[Khushil Mistry]

I have done required changes and also checked the functionalities after building and integrating add on on thunderbird.

[Patrick Brunschwig]

Thanks, I'll review the patch this evening.

[Patrick Brunschwig]

Your patch is committed to master. Thanks - good work :-)