Menu

#340 Manual key selection shows up for missing keys even if disabled

fixed
nobody
None
1.7.2
Major
31.1.2
2.0.26
All
1.8.0
nobody
2015-04-10
2014-09-28
No

Even if manual key selection is disabled, the selection dialog pops up on sending if a key is missing.

Related

Bugs: #343

Discussion

  • Michael Norrish

    Michael Norrish - 2014-10-20

    Assuming this bug is the same as the one I'm seeing, it's very annoying because the window will keep popping up (after a delay) if it is closed.

     
  • Peter Thomassen

    Peter Thomassen - 2014-11-16

    I have the same issue after upgrading to 1.7.2 (from Ubuntu repositories). This also happens in the "convenient" settings.

    It's an annoyance, not so much to me, but especially to unexperienced users who ideally shouldn't be bothered at all if "convenient" is selected. It would be sad if they thought GnuPG was a bad idea because it's so complicated.

     
  • Stefan Kurtz

    Stefan Kurtz - 2014-12-11

    I'm experiencing the same. Latest nightlies (20141211) don't fix the bug yet.

     
  • Patrick Brunschwig

    Fixed on trunk, even though I consider it a bit dangerous. The result is that the message can now be silently sent unencrypted, despite the GUI displaying the message as "encrypted".

     
  • Patrick Brunschwig

    • status: open --> fixed
    • Fixed in version: --- --> 1.8.0
     
  • Patrick Schönbach

    But:

    1. This is how enigmail always used to work.

    2. It only will send it silently unencrypted if there is no matching key.

    Am I correct?

    If you are concerned about security then make it an option.

     
  • Patrick Schönbach

    Or more precisely, this is what disabling manual key selection is all about.

     
  • Patrick Brunschwig

    Sure, except that we changed Enigmail to actually make this scenario obsolete.

    By choosing the correct defaults and preferences (actually: the recommended defaults), Enigmail will automatically enable or disable encryption&signing and display the correct status for encryption and signing while the message is written. You will therefore not see the key selection dialog and still have encryption only enabled if possible.

    There were a few occurrences in 1.7.2 where the dialog was shown unnecessarily for the "convenient" settings, but I'm pretty sure that this is no longer true.

    I'm therefore unsure if the option is required at all...

     
    • Stefan Kurtz

      Stefan Kurtz - 2014-12-14

      The "correct defaults and preferences" never worked for me. It always asked for key selection no matter what (if key was missing) and it probably happens to the other guys here as well. There wouldn't be a reason to come here if it would work the way you're telling.
      The latest nightly is the first that (partly) works properly again. But its still not on par with previous behavior. It still enables signing on default that should be off as well. Would be great if you could fix that as well.

      The small yellow icons (enc/sign) on bottom right compositing window are gone now for ever or will they come back?

       

      Last edit: Stefan Kurtz 2014-12-14
  • Ludwig Hügelschäfer

    Stefan, would you please send a debug log for such an unwanted signed mail using tomorrows nightly (see https://www.enigmail.net/support/bugs.php, section "Execution Trace")? Thanks.

    Concerning the small yellow icons in bottom right of the composer window: Yes, they are gone, and I think it is a good change. They were too small and easily overlooked. They are replaced by bigger icons in the new extra Enigmail toolbar.

     
  • Stefan Kurtz

    Stefan Kurtz - 2014-12-15

    Sure, here is the log. I've stripped/substituted personal data. I hope its ok.
    http://pastebin.com/KsL6EmMg

    A mail was created for recipient without key and moved to output folder ("sent later"). The mail has been signed automatically (but not encrypted). No error message appeared.

     
  • Patrick Schönbach

    The problem still exists. Maybe, it happens in conjunction with the addon "Virtual Identity"?

     
  • Patrick Schönbach

    • status: fixed --> open
     
  • Patrick Brunschwig

    I don't know the "Virtual Identity" addon. Can you please retry with the addon disabled?

     
    • Patrick Schönbach

      Nope, also happens without that addon.

       
  • Viktor Dick

    Viktor Dick - 2015-04-10

    I recently had this error again, but I now I noticed that even though I had 'convenient encryption settings' enabled globally, each account was set to "encrypt messages by default". Once I disabled this, when I start writing a new E-Mail the encryption button is disabled by default but is automatically enabled once I type in a recipient whose key I have - i.e. the desired behavior.

    Could you check if this fixes the problem for you, too?

     
    • Patrick Schönbach

      Yes, it works. However, isn't this counterintuitive? I mean, what is the mentioned option there for, then? In earlier versions, it also used to work with this option enabled.

       
  • Patrick Brunschwig

    "Convenient settings" are global settings which can be overwritten:
    a) by account-specific settings
    b) by replying to encrypted/signed messages
    c) per-recipient rules.

    The purpose of the "Convenient settings" is to make it easier to activate encryption if (and only if) encryption is not enabled by other rules (such as a-c above).

     
  • Patrick Brunschwig

    • status: open --> fixed
     
  • Viktor Dick

    Viktor Dick - 2015-04-10

    I guess it would be more intuitive if the per-account settings had an option "use global settings" which greyed out the other options. Otherwise one might think (as I and others obviously did) that 'Encrypt messages by default' means 'Unless you can't, which is of course the case when there is no key associated with that address'. I guess the fact that the global options differ from the account options (i.e. there is no 'convenient' setting) contributes to this confusion.

     

Log in to post a comment.