Invalid signature if messages contain long lines starting with '-'

OpenPGP addon for Mozilla Thunderbird

Brought to you by: pbrunschwig

#3 Invalid signature if messages contain long lines starting with '-'

Status: fixed

Owner: Ludwig Hügelschäfer

Labels: None

Found in Version: 1.4.1

Severity: Minor

Thunderbird version:

GnuPG version:

Operating System: All

Fixed in version: 1.8.0

Cc: nobody

Updated: 2014-09-11

Created: 2012-08-05

Creator: Patrick Brunschwig

Private: No

Bug 4251 migrated from Mozdev.org

A long line (i.e. longer than the line wrapping value) consisting of dashes "-"
is translated in "- next line long line with dashes" thus giving a bad
signature. Using PGP/MIME doesn't give any problem at all.

It is confirmed that this problem only appears in connection with the dash
character (-) and long lines and without using PGP/MIME.

------- Comment #1 From Patrick Brunschwig 2005-04-14 07:06:43 [reply] -------

*** Bug 9829 has been marked as a duplicate of this bug. ***

------- Comment #2 From Patrick Brunschwig 2005-04-14 07:07:40 [reply] -------

see bug 9829 for more examples that can break the signature validity.

------- Comment #3 From George 2008-03-12 17:55:59 [reply] -------

I get bad signature verification failures on any email with a line that is too
long.

------- Comment #4 From Klaus Ramstöck 2009-01-29 06:27:23 [reply] -------

I'm using Thunderbird 2.0.0.19 and enigmail 0.95.7 and I have the same problem

------- Comment #5 From Olav Seyfarth 2010-06-16 04:21:22 [reply] -------

Issue still there in Enigmail 1.1 with Thunderbird 3.1

Related

Discussion

Patrick Brunschwig - 2012-08-05

Description has changed:

Diff:

--- old +++ new @@ -1,4 +1,5 @@ Bug 4251 migrated from Mozdev.org +================================= A long line (i.e. longer than the line wrapping value) consisting of dashes "-" is translated in "- *next line* *long line with dashes*" thus giving a bad

severity: Enhancement --> Minor
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ludwig Hügelschäfer - 2013-12-31

Behaviour has changed, but is not good either: gpg complains about "bad armor" at verification:

gpg: Ungültige mit Bindestrich "escapte" Zeile:
-------------------------------------------------------------------------------------------------------\n
gpg: Unerwartete ASCII-Hülle:
-----BEGIN PGP SIGNATURE-----\n
[GNUPG:] BADARMOR
gpg: Ungültige ASCII-Hülle

Maybe we should check line length(s) after rewrapping. If still longer than $LIMIT, we should hard break the line(s) at $LIMIT until they are shorter before feeding it to gpg.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patrick Brunschwig - 2014-09-11

status: open --> fixed

assigned_to: Ludwig Hügelschäfer

Found in Version: before_1.4 --> 1.4.1

Operating System: --> All

Fixed in version: --> 1.8.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patrick Brunschwig - 2014-09-11

Line wrapping has been improved, and a dialog lets the user now choose between various options.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.