Menu

#152 CSharpFileManipulator should be redesigned

open
None
5
2008-04-04
2008-04-04
No

Maybe "redesign" is a bad word, but its constructors definitely need to be changed. I'm not convinced that we need to call parseDocument() every time we instantiate an instance of the class.

For cases like cast insertion, we really don't care about the structure of the file in its entirety. In this case, we're only concerned about one single statement.

On large files, parsing takes a lot of time so this will have a large impact on the user experience of Emonic.

Discussion

  • Bernhard Brem

    Bernhard Brem - 2008-04-04

    Logged In: YES
    user_id=1245734
    Originator: NO

    I do this on my job list. I have some ideas to this theme and will probably change in this way the structure of the build file mechanism so that the individual mechanisms will be implemented in one extra plugin for each mechanism.

     
  • Bernhard Brem

    Bernhard Brem - 2008-04-04
    • assigned_to: nobody --> bernhardbrem
     
  • Bernhard Brem

    Bernhard Brem - 2008-04-05

    Logged In: YES
    user_id=1245734
    Originator: NO

    Sorry for the last comment, mixed it up with the IBuildFileManipulator-interface. Nevertheless, I keep the job at my list.

     

Log in to post a comment.