Menu

#148 IBuildfileManipulator's addOrModifyLanguageTarget needs doc

open
None
5
2008-04-03
2008-04-02
No

The addOrModifyLanguageTarget method does not specify how its references and define variables should be passed in. The NAnt unit test is using a space as a delimiter for the references parameter but the MSBuild unit test is using a semi-colon. This inconsistency needs to be resolved for callers of the API.

Discussion

  • Bernhard Brem

    Bernhard Brem - 2008-04-03
    • assigned_to: nobody --> bernhardbrem
     
  • Bernhard Brem

    Bernhard Brem - 2008-04-03

    Logged In: YES
    user_id=1245734
    Originator: NO

    Yes, we have to check it. Might be we should change the API so that it expects a array instead of a string.....

     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: YES

    Using a String array is probably a better idea. I also think we should consider changing this method's signature. It is simply way too verbose. Not everyone really wants to set something every time. We need convenience methods that allows a user to simply update the references or change the target's warning level without having to call the method and have all its parameters filled every time.

    Perhaps we should consider changing the API around so that users can interact with the build file and also targets (and tasks?) individually (some kind of ITarget/IBuildTarget interface or a Target/BuildTarget class and and possibly a ITask interface or Task class). This would make the code a lot easier to read.

     

Log in to post a comment.