#346 False edge trigger on edge.comp when input is initially high.

[Frank Tkalcevic]

The edge component, edge.comp, starts with the last input value (last_in) 0, so if you start the component, and the input is already 1, you will get a false edge trigger.

It needs a "first" variable, to assign the last_in variable the first time the function is run.

This is a simple fix, but the version I'm running doesn't match what is in master, so I wasn't able to test against master.

[Marius Liebenberg]

Frank post your proposed change here and I will apply it to the latest code and submit.

[Frank Tkalcevic]

My fix is available here, but was applied to 2.5.x

https://github.com/ftkalcevic/LinuxCNC/blob/ikfast/src/hal/components/edge.comp

[Marius Liebenberg]

Frank have you tested this in 2.6 master recently?

[Frank Tkalcevic]

No, sorry. The change is pretty simple. Just make sure the first time though, just load the values and don't trigger.

[Marius Liebenberg]

I made the suggested change and attached the code. Frank, can you please verify that it is correct.

[Frank Tkalcevic]

The change looks correct.

[Chris Radek]

Thanks for this fix, Frank. It will be in 2.5.4 and later versions.