#79 emacs-jabber 0.8.90 breaks connections to lavabit.com

closed
Magnus Henoch
None
5
2012-02-06
2011-08-21
Elias Pipping
No

Using a googlemail account of the form

(setq jabber-account-list '(("user@googlemail.com"
(:password . "password")
(:network-server . "talk.google.com")
(:connection-type . ssl))))

works for me with emacs-jabber 0.8.90. Using a lavabit.com account of the form

(setq jabber-account-list '(("user@lavabit.com"
(:password . "password.")
(:network-server . "lavabit.com")
(:connection-type . ssl)
(:port . 5223))))

does not. It did with 0.8.0, though. Here's what happens:

Opening TLS connection to `lavabit.com'...
Opening TLS connection with `gnutls-cli -p 5223 lavabit.com'...done
Opening TLS connection to `lavabit.com'...done
user@lavabit.com/nil: connection lost: `Unexpected stanza (features ((xmlns . http://etherx.jabber.org/streams\) (xmlns:stream . http://etherx.jabber.org/streams\)) (compression ((xmlns . http://jabber.org/features/compress\)) (method nil zlib)) (address ((xmlns . http://affinix.com/jabber/address\)) 91.65.137.66) (auth ((xmlns . http://jabber.org/features/iq-auth\))))'

Discussion

  • Magnus Henoch
    Magnus Henoch
    2011-08-21

    Accept <features> as well as <stream:features>

     
    Attachments
  • Magnus Henoch
    Magnus Henoch
    2011-08-21

    Right, I think I see what's going on. The <stream:features> element has an xmlns attribute for the stream prefix, so the namespace tree walker removes the stream: prefix from the element, which confuses other parts of jabber-core.

    Could you try the attached patch? I'll try to get a nicer version into the tree during the coming week.

     
  • Elias Pipping
    Elias Pipping
    2011-08-22

    That makes it work again for me, thanks.

     
  • Magnus Henoch
    Magnus Henoch
    2011-12-21

    Finally got time to do it the proper way :)

    Could you try the change I just pushed to Git? I believe it should work with both Google Talk and lavabit.com.

     
  • Magnus Henoch
    Magnus Henoch
    2011-12-21

    • assigned_to: nobody --> legoscia
     
  • Elias Pipping
    Elias Pipping
    2011-12-21

    Well, the good news is that my lavabit account continues to work.

    There's a test failure, though:

    romeo@montague.net/nil: connection lost: `Unexpected stanza (stream:features nil (mechanisms ((xmlns . urn:ietf:params:xml:ns:xmpp-sasl)) (mechanism nil DIGEST-MD5)) (bind ((xmlns . urn:ietf:params:xml:ns:xmpp-bind))) (session ((xmlns . urn:ietf:params:xml:ns:xmpp-session))))'
    Timeout
    FAIL: nick-change-fail.el

    And the error looks like it's related.

     
  • Magnus Henoch
    Magnus Henoch
    2012-02-06

    • status: open --> closed
     
  • Magnus Henoch
    Magnus Henoch
    2012-02-06

    Both the original problem and the test failure should be solved in 0.8.91.