From: Ed M. <em...@fr...> - 2020-02-11 22:15:56
|
On Sat, 8 Feb 2020 at 17:31, Joseph Koshy <jk...@us...> wrote: > > As of [r3818], test failures are propagated to the invoking make(1) process. Thank you - indeed, the test runs are now red in Cirrus-CI. https://cirrus-ci.com/build/5940794091634688 AFAIK all failing elfcopy tests are comparing against an expected binary output and the order of the strings in .shstrtab changed after markj's commit - i.e., the test legitimately detected change in the output, but the change is actually benign and the fix is to update the expected output. Of course I'd make that change only after comparing the output and ensuring that ordering in the string table is the only difference. |