Menu

#6 unquoted attribute value with comma handled poorly

open-fixed
nobody
None
5
2004-06-12
2004-02-19
Josh
No

In ekhtml_mktables.c, the method that specifies which
characters are valid attribute values (valid_attrvalue)
does not include the comma (,), the semicolon (;), or
the vertical bar (|). If any of these characters shows up
in an unquoted attribute value, then the rest of the
element is not parsed. An example that seems to show
up pretty commonly is: <AREA SHAPE=rectangle
COORDS=40,20,30,40 HREF="http://..."/>. In this case,
the HREF is never found. As another example, if an
unquoted HREF contains any of these characters, than
the value will only include characters up to, but not
including, the first offending character.

I propose adding these characters to the list of
characters in valid_attrvalue. Here is the diff of
ekhtml_mktables.c for this change:

72c72,73
< in == '$' || in == '_')
---
> in == '$' || in == '_' || in == ',' || in == ';' ||
> in == '|')

Attached is the modified file

Discussion

  • Josh

    Josh - 2004-02-19

    modified ekhtml_mktables.c

     
  • Jon Travis

    Jon Travis - 2004-06-12
    • status: open --> open-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB