Menu

#96 All modules have the title 0 after they are created

RC1
closed-fixed
None
5
2014-07-03
2014-06-26
No

After the modules have been created in the index.php page they have the title 0. This happened after commit #316. I think there could be a line of code the is only supposed to work with copies but could be renaming the modules before submission to the database.

Related

Bugs: #96

Discussion

  • Christopher Macco

    • status: open --> closed-fixed
     
    • Gregory Hislop

      Gregory Hislop - 2014-06-26

      It looks like the intention of that line is to do something similar to what Windows file manage does when you create a copy of a file in the same directory. That is, (for example) if you copy a module named "Exercise A" it looks like the intention was that the module copy would be named "Exercise A (COPY)" by default. I would suggests instead that the copy create this default name but then allow the user to edit that text to change it before the module is copied.

      GH.

      From: Christopher Macco [mailto:cmacco@users.sf.net]
      Sent: Thursday, June 26, 2014 2:05 PM
      To: [edrepo:bugs]
      Subject: [edrepo:bugs] #96 All modules have the title 0 after they are created

      • status: open --> closed-fixed
      • Comment:

      Fixed at revision #317. I took out a line of code that changed the title from $_REQUEST["moduleTitle"] to $_REQUEST["moduleTitle"] + "(COPY)" which made the title 0. Tested on: EdRepo 0.8, Firefox, XAMPPLite 1.7.3, Windows 8.1 Pro.


      [bugs:#96]http://sourceforge.net/p/edrepo/bugs/96/ All modules have the title 0 after they are created

      Status: closed-fixed
      Group: RC1
      Created: Thu Jun 26, 2014 06:01 PM UTC by Christopher Macco
      Last Updated: Thu Jun 26, 2014 06:01 PM UTC
      Owner: nobody

      After the modules have been created in the index.php page they have the title 0. This happened after commit #316. I think there could be a line of code the is only supposed to work with copies but could be renaming the modules before submission to the database.


      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/edrepo/bugs/96/

      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

       

      Related

      Bugs: #96

  • Christopher Macco

    Fixed at revision #317. I took out a line of code that changed the title from $_REQUEST["moduleTitle"] to $_REQUEST["moduleTitle"] + "(COPY)" which made the title 0. Tested on: EdRepo 0.8, Firefox, XAMPPLite 1.7.3, Windows 8.1 Pro.

     
  • Christopher Macco

    • assigned_to: Christopher Macco
     
  • Christopher Macco

    • status: closed-fixed --> open
     
  • Christopher Macco

    Opened to update and implement the feature Dr. Hislop has suggested.

     
  • Christopher Macco

    Implemented extra at revision #321: this was fixed while working on feature request #62. Please see closed request #62 for more information. https://sourceforge.net/p/edrepo/feature-requests/62/

     

    Last edit: Christopher Macco 2014-07-03
  • Christopher Macco

    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB