Re: [edk2-buildtools] [edk2][PATCH] Merge sources from edk2-buildtools sub-project to EDK II BaseTools trunk

[Kinney, M. D <mic...@in...>]

Jordan,

I agree with doing these as 5 separate patches.

Reviewed-by: Michael Kinney mic...@in...

Do you want to go ahead and check-in these patches? 

Thanks,

Mike

-----Original Message-----
From: Jordan Justen [mailto:jlj...@gm...] 
Sent: Friday, July 25, 2014 1:43 PM
To: Kinney, Michael D
Cc: edk...@li...; edk...@li...
Subject: Re: [edk2-buildtools] [edk2][PATCH] Merge sources from edk2-buildtools sub-project to EDK II BaseTools trunk

Mike,

I think we should re-apply these 4 changes separately in EDK II. (See
attachments 1-4)

I also found a difference in some 'build version' variables. (See attachment 5).

After applying these 5 patches, the two BaseTools seem to be in sync.

-Jordan

https://github.com/jljusten/edk2/tree/sync-BaseTools

On Fri, Jul 25, 2014 at 10:38 AM, Kinney, Michael D
<mic...@in...> wrote:
> Hello,
>
>
>
> The attached patch contains the changes to sync the edk2-buildtools
> sub-project to the EDK II BaseTools trunk.  This is the last step before the
> edk2-buildtools sub-project permissions are changed to read-only.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Michael Kinney mic...@in...
>
>
>
> The patch includes changes for the following check-in log entries from the
> edk2-buildtools sub-project.
>
>
>
> =====
>
> Update GenFv tool to handle the file path with space.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Gao, Liming lim...@in...
>
> Review-by: Kinney, Michael D mic...@in...
>
> ====
>
> Report warning info if vfr file use the flags used for framework code only.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Eric Dong <eri...@in...>
>
> Reviewed-by: Liming Gao <lim...@in...>
>
> ====
>
> Clean 1 build error and 1 warning for VfrCompiler.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Eric Dong <eri...@in...>
>
> Reviewed-by: Liming Gao <lim...@in...>
>
> ====
>
> Report warning info if an action opcode has text two statement.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Eric Dong <eri...@in...>
>
> Reviewed-by: Liming Gao <lim...@in...>
>
> =====
>
>
>
> Thanks,
>
>
>
> Mike
>
>
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> _______________________________________________
> edk2-buildtools-devel mailing list
> edk...@li...
> https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
>