From: Liu, Y. D <yin...@in...> - 2014-07-09 00:42:07
|
The change is good to me. Reviewed-by: Yingke Liu <yin...@in...> Dennis From: Andrew Fish [mailto:af...@ap...] Sent: Tuesday, July 08, 2014 11:54 PM To: edk...@li...; edk...@li... Subject: [edk2-buildtools] Update the Guid.xref file to have only upper case GUIDs. I ran into some 3rd party INF files that use mixed case for the FILE_GUID and this was confusing my debugger Python scripts. I think it is better for the Guid.xref file to output the GUID strings in upper case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish <and...@ap...<mailto:and...@ap...>> Index: Source/Python/GenFds/GenFds.py =================================================================== --- Source/Python/GenFds/GenFds.py (revision 2670) +++ Source/Python/GenFds/GenFds.py (working copy) @@ -517,7 +517,7 @@ PlatformDataBase = BuildDb.BuildObject[GenFdsGlobalVariable.ActivePlatform, Arch, GenFdsGlobalVariable.TargetName, GenFdsGlobalVariable.ToolChainTag] for ModuleFile in PlatformDataBase.Modules: Module = BuildDb.BuildObject[ModuleFile, Arch, GenFdsGlobalVariable.TargetName, GenFdsGlobalVariable.ToolChainTag] - GuidXRefFile.write("%s %s\n" % (Module.Guid, Module.BaseName)) + GuidXRefFile.write("%s %s\n" % (Module.Guid.upper(), Module.BaseName)) for key, item in Module.Protocols.items(): GuidDict[key] = item for key, item in Module.Guids.items(): Thanks, Andrew Fish |