Re: SF.net SVN: edk2-buildtools:[2644] trunk/BaseTools/Conf/tools_def.template

[Andrew F. <af...@ap...>]

On Jan 15, 2014, at 10:08 AM, Olivier Martin <oli...@ar...> wrote:

> I do not think it is possible to set a default value in the DSC when using
> ENV().
> 
> You should not get an error if ENV(CLANG_BIN) is not defined (it is bug I
> fixed in BaseTools a couple of years ago).
> But you will definitely have an error if you still have DEF(CLANG_BIN) and
> CLANG_BIN is not defined.
> 

Sorry looks like I missed a DEF(CLANG_BIN) in the file. It was my error, just a bad merge. 

Thanks,

Andrew Fish

> Which kind of error do you have? Do you only use CLANG_BIN in your
> tools_def.txt? Or are you also using this variable into your DSC file?
> 
> 
>> -----Original Message-----
>> From: Andrew Fish [mailto:af...@ap...]
>> Sent: 15 January 2014 17:55
>> To: oli...@us...
>> Cc: edk...@li...
>> Subject: Re: SF.net SVN: edk2-buildtools:[2644]
>> trunk/BaseTools/Conf/tools_def.template
>> 
>> Olivier,
>> 
>> It it possible to give a default value for CLANG_BIN in the .DSC file?
>> 
>> I noticed I get an error if CLANG_BIN is not defined.
>> 
>> Thanks,
>> 
>> Andrew Fish
>> 
>> On Jan 15, 2014, at 9:07 AM, oli...@us... wrote:
>> 
>>> Revision: 2644
>>>         http://sourceforge.net/p/edk2-buildtools/code/2644
>>> Author:   oliviermartin
>>> Date:     2014-01-15 17:07:09 +0000 (Wed, 15 Jan 2014)
>>> Log Message:
>>> -----------
>>> tools_def.template: Change CLANG_BIN from DEF to ENV
>>> 
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Olivier Martin <oli...@ar...>
>>> Reviewed-by: Andrew Fish <af...@ap...>
>>> 
>>> Modified Paths:
>>> --------------
>>>   trunk/BaseTools/Conf/tools_def.template
>>> 
>>> Modified: trunk/BaseTools/Conf/tools_def.template
>>> ===================================================================
>>> --- trunk/BaseTools/Conf/tools_def.template	2014-01-15 12:34:01 UTC
>> (rev 2643)
>>> +++ trunk/BaseTools/Conf/tools_def.template	2014-01-15 17:07:09 UTC
>> (rev 2644)
>>> @@ -192,11 +192,6 @@
>>> 
>>> DEFINE SOURCERY_CYGWIN_TOOLS = /cygdrive/c/Program
>> Files/CodeSourcery/Sourcery G++ Lite/bin
>>> 
>>> -#
>>> -# Change to the location clang was built
>>> -#
>>> -DEFINE CLANG_BIN = /usr/bin/
>>> -
>>> 
>> #######################################################################
>> #############
>>> #
>>> # format: TARGET_TOOLCHAIN_ARCH_COMMANDTYPE_ATTRIBUTE = <string>
>>> @@ -5484,15 +5479,15 @@
>>> RELEASE_XCLANG_*_MTOC_FLAGS = -align 0x20
>>> 
>>> 
>>> -*_XCLANG_*_CC_PATH      = DEF(CLANG_BIN)clang
>>> +*_XCLANG_*_CC_PATH      = ENV(CLANG_BIN)clang
>>> *_XCLANG_*_SLINK_PATH   = libtool
>>> *_XCLANG_*_DLINK_PATH   = ld
>>> *_XCLANG_*_ASM_PATH     = as
>>> -*_XCLANG_*_PP_PATH      = DEF(CLANG_BIN)clang
>>> -*_XCLANG_*_VFRPP_PATH   = DEF(CLANG_BIN)clang
>>> +*_XCLANG_*_PP_PATH      = ENV(CLANG_BIN)clang
>>> +*_XCLANG_*_VFRPP_PATH   = ENV(CLANG_BIN)clang
>>> *_XCLANG_*_ASL_PATH     = iasl
>>> -*_XCLANG_*_ASLCC_PATH   = DEF(CLANG_BIN)clang
>>> -*_XCLANG_*_ASLPP_PATH   = DEF(CLANG_BIN)clang
>>> +*_XCLANG_*_ASLCC_PATH   = ENV(CLANG_BIN)clang
>>> +*_XCLANG_*_ASLPP_PATH   = ENV(CLANG_BIN)clang
>>> *_XCLANG_*_ASLDLINK_PATH  = ld
>>> 
>>> ####################
>>> 
>>> This was sent by the SourceForge.net collaborative development
>> platform, the world's largest Open Source development site.
>>> 
>>> 
>>> ---------------------------------------------------------------------
>> ---------
>>> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
>>> Learn Why More Businesses Are Choosing CenturyLink Cloud For
>>> Critical Workloads, Development Environments & Everything In Between.
>>> Get a Quote or Start a Free Trial Today.
>>> 
>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.c
>> lktrk
>>> _______________________________________________
>>> edk2-buildtools-commits mailing list
>>> edk...@li...
>>> https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-commits
>> 
>> 
>> -----------------------------------------------------------------------
>> -------
>> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
>> Learn Why More Businesses Are Choosing CenturyLink Cloud For
>> Critical Workloads, Development Environments & Everything In Between.
>> Get a Quote or Start a Free Trial Today.
>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.c
>> lktrk
>> _______________________________________________
>> edk2-buildtools-commits mailing list
>> edk...@li...
>> https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-commits
> 
> 
> 
>