Menu

#1 get_cpu_entropy in strobe.c possibly broken on i386 builds

1.0
closed
None
2017-01-17
2016-11-07
No

This ticket may be premature as I haven't delved deeply into building on a 32-bit machine, but this issue for erlang-libdecaf made me think that there might be some issues with the i386 implementation for get_cpu_entropy in strobe.c.

Discussion

  • Mike Hamburg

    Mike Hamburg - 2016-11-07

    Yeah, that's a bug, caused by too much copy-pasting. It's harmless except that -Wall -Werror flags it. The problem is that I needed to explicitly cast the pointer to convert it to a uint32_t * before storing it into a variable of type uint32_t *. But instead I explicitly casted it to uint64_t *. Then the compiler warns on storing it to uint32_t *, and -Werror errors the build.

    Should be fixed in f102952.

     
  • Mike Hamburg

    Mike Hamburg - 2017-01-17
    • status: open --> closed
    • assigned_to: Mike Hamburg
     

Log in to post a comment.