#28 cygwin & mingw compilation ( final )

closed-accepted
None
5
2004-01-15
2004-01-14
Anonymous
No

Final version of mingw-compile patch.
Now windows version is working without coredump on
exit.

Hazeman

Discussion

  • Nobody/Anonymous

    cygwin & mingw compilation patch

     
  • Tim-Philipp Muller

    • status: open --> pending
     
  • Tim-Philipp Muller

    Logged In: YES
    user_id=583691

    k

    I am sceptical about the changes in _is_evil_ip() in http_get.c,
    but I've applied them anyway for now. If that breaks, we know
    where to look. (also it seems odd to me that the mask is not
    reset within the loop there, but that was there before).

    Note that you should define HAVE_SYS_SYSLIMITS_H if
    needed (did I put that include at the right spot?)

    Btw, please make diffs with the -u switch in future. Your
    patches didn't apply with any path stripping setting, so I had to
    put them in manually, which really sucks in the default diff
    format.

    Thanks

    Cheers
    -Tim

     
  • Tim-Philipp Muller

    • assigned_to: nobody --> uberdork
    • summary: cygwin & mingw compilation ( final ) --> cygwin & mingw compilation ( final )
    • status: pending --> pending-accepted
     
  • Nobody/Anonymous

    Logged In: NO

    You are right, the mask should be set within the loop. I
    wasn't looking at the logic of the whole function, so that's
    why I missed it. I simply exchanged the same with smaller the
    same ( it really does exactly the same thing ). For me it's
    example of "microsoft style programming" - if you can do
    something, do it around, so there is higher chance that it will
    not work :) ( and it did broke compilation under mingw ).

    Hazeman

     
  • Tim-Philipp Muller

    • status: pending-accepted --> closed-accepted
     
  • Tim-Philipp Muller

    Logged In: YES
    user_id=583691

    k, thanks for the feedback.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks