From: Thiago A. <thi...@gm...> - 2006-01-30 20:28:43
|
Leif, I was wondering if we could rename the "de.leiffrenzel" packages to "net.sf.eclipsefp". I know it was you who started this whole thing, but I don't think that people feel quite comfortable changing code with someone else's name on it. Using a team name would make the code more attractive to potential developers in the future. This is not to take your credit away, far from that. But I think this is already present on the authorship information. Cheers, Thiago Arrais -- Mergulhando no Caos - http://thiagoarrais.blogspot.com Pensamentos, id=E9ias e devaneios sobre desenvolvimento de software e tecnologia em geral |
From: Leif F. <lfr...@in...> - 2006-01-31 11:31:33
|
Hi Thiago, > Leif, > > I was wondering if we could rename the "de.leiffrenzel" packages to > "net.sf.eclipsefp". I know it was you who started this whole thing, > but I don't think that people feel quite comfortable changing code > with someone else's name on it. Using a team name would make the code > more attractive to potential developers in the future. > > This is not to take your credit away, far from that. But I think this > is already present on the authorship information. > Sure :-) I'm not particularly happy about the situation with the mixed prefixes anyway. When I moved the code to sf, I started to use the net.sf.eclipsefp prefix. Changing the package names would not be a big deal. But there is one problem: if we change things like project nature ids (which also have the de.leiffrenzel prefix), that would break existing projects. So the only acceptable way to do this would be to do it in one go, and tell all users about the break in compatibility, so that they can migrate their projects (and have it to do only once). Ciao, Leif > Cheers, > > Thiago Arrais > -- > Mergulhando no Caos - http://thiagoarrais.blogspot.com > Pensamentos, idéias e devaneios sobre desenvolvimento de software e > tecnologia em geral > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://sel.as-us.falkag.net/sel?cmd=k&kid3432&bid#0486&dat1642 > _______________________________________________ > eclipsefp-develop mailing list > ecl...@li... > https://lists.sourceforge.net/lists/listinfo/eclipsefp-develop > |
From: Thiago A. <thi...@gm...> - 2006-01-31 11:56:26
|
2006/1/31, Leif Frenzel <lfr...@in...>: > Changing the package names would not be a big deal. So we should start with them. > But there is one > problem: if we change things like project nature ids (which also have > the de.leiffrenzel prefix), that would break existing projects. In that case we'll need to heavily test those sentive areas. Please let me know if you happen to remember any other fragile areas like this one. I am indeed concerned with the danger of breaking something, mostly because we don't have a wide test coverage at this time. I am sure Eclipse JDT/PDE will be able to do much of the work, but I am afraid there are some areas where they won't reach. Things like property files or even the plugin manifests. I am not sure if it is really safe to rename components referenced at the manifest files. > So the > only acceptable way to do this would be to do it in one go, and tell all > users about the break in compatibility, so that they can migrate their > projects (and have it to do only once). Agreed. Cheers, Thiago Arrais |
From: Leif F. <lfr...@in...> - 2006-01-31 12:09:22
|
> In that case we'll need to heavily test those sentive areas. Please > let me know if you happen to remember any other fragile areas like > this one. > > I am indeed concerned with the danger of breaking something, mostly > because we don't have a wide test coverage at this time. I am sure > Eclipse JDT/PDE will be able to do much of the work, but I am afraid > there are some areas where they won't reach. Things like property > files or even the plugin manifests. I am not sure if it is really safe > to rename components referenced at the manifest files. > > The refactorings in Eclipse will pretty much cover all the renaming. However, it is good practice to keep class names and ids equal, if possible. So, e.g. if you have a view that is implemented in bla.ViewClass, then the id should be "bla.ViewClass". The rename refactorings in Eclipse 3.2 can rename the class names in the plugin.xml files, but naturally then will not cover the ids. Since I usually used the id/class name convention, I usually refer to ids (like view ids) via e.g. ViewClass.class.getName(). Therefore I don't think there are many explicit references to ids in strings (but we'll have to check, of course :-). Builder ids and natures are more tricky, because they appear in the user's projects, they are saved in the .project files. The same goes for preference names. So if we change these, all users will have to do their settings again. Sadly, but, I don't know any reasonable way to avoid that problem. Ciao, Leif >> So the >> only acceptable way to do this would be to do it in one go, and tell all >> users about the break in compatibility, so that they can migrate their >> projects (and have it to do only once). >> > > Agreed. > > Cheers, > > Thiago Arrais > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://sel.as-us.falkag.net/sel?cmd=k&kid3432&bid#0486&dat1642 > _______________________________________________ > eclipsefp-develop mailing list > ecl...@li... > https://lists.sourceforge.net/lists/listinfo/eclipsefp-develop > |