Re: [eclipsedarcs-develop] Fix for Flyspray #11
Status: Alpha
Brought to you by:
radoslawg
|
From: <rad...@gm...> - 2007-03-18 10:51:54
|
2007/3/18, Leif Frenzel <lei...@go...>: > > > > > > > > > > > > The ***DARCS*** Line is explicitly added in > > > > RecordOperation.prepareLogFile () method. I was about to remove it > > > > anyway as I thought this was some kind of debug. > > > > If I remember correcty, it was deliberate. I was mimicking the thing that > Darcs does when it calls an external editor for the long comment. But it > seems that this works now different, or strictly speaking, they use now > '***END OF DESCRIPTION***' instead of '***DARCS***'. > > > > Hm, I suspect that was a change between some earlier Darcs version and > 1.0.8. > > > > But that would mean that we have to change our code to '***END OF > DESCRIPTION***' and declare explicitely that Darcs 1.0.8 should be used with > EclipseDarcs, right? > Hm, I verified, with Darcs 1.0.2 it's '***DARCS***'. It's '***END OF > DESCRIPTION***' with Darcs 1.0.5RC1, I haven't checked the versions in > between. > > Wow, it's always a bit frightening how time flies ;-) > > So this means we don't have to worry. We should be able to simply use > '***END OF DESCRIPTION***'. Doesn't that mean that we should not worry about it at all? We don't need to put any text at the end of the file. Or do we? Time showed that putting there anything may in future result in another changed comment. This is temp file, completly under our command without user interaction with it, darcs accept it and correctly parse it without any termination text. Cheers! Radek. |