Re: [eclipsedarcs-develop] Fix for Flyspray #11

[<rad...@gm...>]

2007/3/18, Leif Frenzel <lei...@go...>:
> On 3/18/07, Leif Frenzel <lei...@go...> wrote:
> >
> >
> > > It turns out it is because usage of quote (") characters in darcs
> > > invocation. If I use
> > >
> > > createNameValueParam( PARAM_LOGFILE, logFile.toString() ) ;
> > >
> > > instead of
> > >
> > > createNameQuotedValueParam( PARAM_LOGFILE, logFile.toString() ) ;
> > >
> > > everything works ok. Any ideas why? Is it safe to substitute it? Anyone?
> >
> > I'd say so. But I will do some safety checks.
> Hm, looks good to me.
>
>
> >
> >
> > Btw: there is some other thing that I noticed: if one does a record with a
> long comment, at least under Windows, and one does _not_ do a line break at
> the end, the comment gets screwed up in the Darcs changes output. I'll have
> a look at that and perhaps get it fixed at the same time :-)
> Strange enough, this happens also if one _does_ enter a line break. Any long
> comment gets a '***DARCS***' appended. E.g.
>
> [snip]
> C:\temp\junk\edws\test>darcs changes --last=3
> Sun Mar 18 11:18:07 Westeurop[_\e4_]ische Normalzeit 2007  Leif Frenzel
> <lfr...@in...>
>   * 1174213086703
>
> Sun Mar 18 11:16:57 Westeurop[_\e4_]ische Normalzeit 2007  Leif Frenzel <
> lfr...@in...>
>   * 1174213013109
>   a
>   ***DARCS***
>
> Sun Mar 18 11:16:07 Westeurop[_\e4_]ische Normalzeit 2007  Leif Frenzel <
> lfr...@in...>
>   * test
>   test long comment
>
>   ***DARCS***
> [snap]
>
> This has not happened earlier, so it must have sneaked in somewhere in the
> past. Do you see the same effect on Linux?
>

The ***DARCS*** Line is explicitly added in
RecordOperation.prepareLogFile() method. I was about to remove it
anyway as I thought this was some kind of debug.

Cheers!
  Radek.

-- 
Galeria/Gallery: http://zdjecia.zuzia.homelinux.net/
Codeside: http://codeside.org/