#421 Does not build against Eclipse Oxygen

[Mat Booth]

When building against Eclipse Oxygen, you get the errors shown below. This is because the long-time deprecated jface API "org.eclipse.jface.util.ListenerList" was finally removed. You should instead use the implementation from core runtime "org.eclipse.core.runtime.ListenerList"

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.0.0:compile (default-compile) on project net.sf.eclipsecs.ui: Compilation failure: Compilation failure: 
[ERROR] /builddir/build/BUILD/eclipse-cs-git-38600a3c2b01faba76ede3976da733fab453a535/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java:[21] 
[ERROR]         import org.eclipse.jface.util.ListenerList;
[ERROR]                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The import org.eclipse.jface.util.ListenerList cannot be resolved
[ERROR] /builddir/build/BUILD/eclipse-cs-git-38600a3c2b01faba76ede3976da733fab453a535/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java:[50] 
[ERROR]         private final ListenerList checkStateListeners = new ListenerList(3);
[ERROR]                       ^^^^^^^^^^^^
[ERROR] ListenerList cannot be resolved to a type
[ERROR] /builddir/build/BUILD/eclipse-cs-git-38600a3c2b01faba76ede3976da733fab453a535/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java:[50] 
[ERROR]         private final ListenerList checkStateListeners = new ListenerList(3);
[ERROR]                                                              ^^^^^^^^^^^^
[ERROR] ListenerList cannot be resolved to a type
[ERROR] /builddir/build/BUILD/eclipse-cs-git-38600a3c2b01faba76ede3976da733fab453a535/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java:[134] 
[ERROR]         checkStateListeners.add(listener);
[ERROR]         ^^^^^^^^^^^^^^^^^^^
[ERROR] ListenerList cannot be resolved to a type
[ERROR] /builddir/build/BUILD/eclipse-cs-git-38600a3c2b01faba76ede3976da733fab453a535/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java:[171] 
[ERROR]         Object[] array = checkStateListeners.getListeners();
[ERROR]                          ^^^^^^^^^^^^^^^^^^^
[ERROR] ListenerList cannot be resolved to a type
[ERROR] /builddir/build/BUILD/eclipse-cs-git-38600a3c2b01faba76ede3976da733fab453a535/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java:[310] 
[ERROR]         checkStateListeners.remove(listener);
[ERROR]         ^^^^^^^^^^^^^^^^^^^

[Mat Booth]

I submitted a merge request here: https://sourceforge.net/p/eclipse-cs/git/merge-requests/5/

[Mat Booth]

My patch was merged in https://sourceforge.net/p/eclipse-cs/git/ci/8920d29f4a01367aca18c6c5f27a493bafa55b02/

Thanks for merging, not sure how to close this bug though -- I probably don't have permission :-)

[Lars Koedderitzsch]

Thanks again for the patch, Mat!