Menu

#411 Rule group description is not shown in UI

Future
closed
nobody
None
1
2016-11-07
2016-09-03
Eric Milles
No

Checks configuration DTD lists description as an element that rule-group-metadata supports. However, I do not see any support for this element in the code. None of the base groups have descriptions.

<!ELEMENT rule-group-metadata (description?,rule-metadata*)>

Add to MetadataFactory.parseMetadata at end of loop:

                // process description
                String groupDesc = groupEl.elementTextTrim(XMLTags.DESCRIPTION_TAG);
                groupDesc = localize(groupName, metadataBundle);
                group.setDescription(groupDesc);

Add field and accessors in RuleGroupMetadata:

    /** The description of the group. */
    private String mDescription;
    /**
     * Returns the description of the group.
     *
     * @return the description
     */
    public String getDescription() {
        return mDescription;
    }
    public void setDescription(String value) {
        mDescription = value;
    }

working on where this gets shown in the config dialog...

Discussion

  • Eric Milles

    Eric Milles - 2016-09-03

    Guess I can't edit the ticket now... There is a typo in the addition to parseMetadata. It should be
    groupDesc = localize(groupDesc, metadataBundle);.

    Lastly, in the UI plug-in, net.sf.eclipsecs.ui.config.CheckConfigurationConfigureDialog.PageController.selectionChanged(SelectionChangedEvent), within the RuleGroupMetadata block:

    description = ((RuleGroupMetadata) element).getDescription();
    
     
  • Lars Koedderitzsch

    • status: open --> closed
     
  • Lars Koedderitzsch

    Fixed for 7.2.0

     

Log in to post a comment.

MongoDB Logo MongoDB