Here's my fifty cents on maintaining CS / ECLIPSE-CS metadata: I maintain a CS extension called "cs-contrib", and face the same challenge: Provide metadata about my extension to CS and ECLIPSE-CS, and keeping that in sync with the implementation. For exactly this purpose I developed the JAVADOC doclet http://unkrig.de/w/Cs-doclet that generates the following files from the extension's source code: de/unkrig/cscontrib/checks/checkstyle-metadata.properties de/unkrig/cscontrib/checks/checkstyle-metadata.xml...
Hello group. I am new in this forum, and is learning Java Script, and would like by go in a project open-source, for contribute and learning too.
Sorry for the late reply, premises here @SF are largely vacated. The project moved to Github https://github.com/checkstyle/eclipse-cs for project services (Git, Issues) and Bintray for binary downloads. Update site archives starting from version 8.7.0 can be found here: https://bintray.com/eclipse-cs/eclipse-cs/update-site-archive#files/update-site-archive
if this is required please open issue at https://github.com/checkstyle/checkstyle/issues for discussion of requirements
Pardon the post.
Pardon the newbie question. As someone who teaches CS1, I absolutely LOVE Checkstyle. However students often find themselves getting new machines as the term progresses, so using the built-in Eclipse feature to get the latest and greatest version isn't really practical (because often times, newer releases will not work with my configuration file) My workaround was simple, I have the students visit the SourceForge page at: https://sourceforge.net/projects/eclipse-cs/files/Eclipse%20Checkstyle%20Plug-in/...
I work on a project with a custom Checkstyle configuration, which is run both through an Ant build and via the Eclipse plugin. The following happens to me fairly frequently: Install new version of Eclipse plugin, just because it popped up in the list of plugin updates Eclipse plugin shows errors or Checkstyle violations of various sorts due to backward-incompatible changes to Checkstyle Figure out how to update our configuration/code to work with the new version of the Eclipse plugin and the existing...
Great solution with moving to the checkstyle organization, and much better than my initial suggestion. I've deleted the temporary eclipsecs organization account on github to not cause any confusion.
Thanks for the quick reply. Please check the attachment.
@Ashis please attach your checkstyle configuration file
I have the checkstyle version 8.5.1 and i still have the same issue. Error i am getting. Unable to create a Checker: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of SuppressionCommentFilter I have added SuppressionCommentFilter module inside Treewalker module. Please help me in this.
You are probably right, as long as CS (Core) only throws you (eclipse-cs) a general CheckstyleException, it will be very difficult for you to distinguish a parsing error from "honest bugs in Checkstyle core" ... I guess the "right" way would be for CS Core to throw a CheckstyleSourceParseException kind of thing instead a CheckstyleException if the cause is a MismatchedTokenException, and others like that?
Eric Milles and Bananeweizen you are very welcome to become contributors/maintainers of eclipse-cs please create issues on github to request RW access and start sharing knowledge transfer from Lars. Fact eclipse-cs is hosted under checkstyle organization does not mean that checkstyle maintainers could maintain it too. Checkstyle core library have about 20 active PRs each day, that waiting to be merged or other feedback. Checkstyle team can not keep up even with core project. Please be welcome to...
Eric Milles and Bananeweizen you are very welcome to become contributors/maintainers of eclipse-cs please create issues on github to request RW access and start sharing knowledge transfer from Lars. Fact eclipse-cs is hosted under checkstyle organization doe snot mean that checkstyle maintainers could maintain it too. Checkstyle core library have about 20 active PRs each day, that waiting to be merged or other feedback. Checkstyle team can not keep up even with core project. Please be welcome to...
FYI the move of eclipse-cs sources to Github as a first measure is a go, see https://github.com/checkstyle/eclipse-cs Thanks to @Bananeweizen for suggesting and to @Roman for taking it under the wings of the Checkstyle organisation at Github
Thanks for the update. A great way to start the new year. :D
I feel rather Checkstyle itself should expose all the necessary metadata I agree but we had a discussion about this and we have not come to a conclusion on what data should be in the metadata and how it should be stored. One point of discussion was: https://github.com/checkstyle/regression-tool/issues/29 I suggest you bring it up again in an issue in main project and keep asking for a solution from us. I imagine sevntu metadata is maintained alongside the checks, so whenever you change something...
I imagine sevntu metadata is maintained alongside the checks, so whenever you change something (add a property, new check etc.) you will update the eclipse-cs metadata accordingly? For eclipse-cs this is not the case. Instead once in a while I need to check all changes in Checkstyle for their relevance to the metadata. For example: a new check is added a check gets a new property an existing property is changed - for instance changes to allowed or default tokens addition of new message keys * or...
I am unsure how this can help with eclipse-cs metadata maintenance. As I understand I would still need to meticulously check all changes in a Checkstyle release, whether they have any relevance for the metadata. Could you give an example of something you think would have to be manually done and couldn't be automated? I can only speak from my experience with sevntu's eclipse-cs files. Even if you can't automate everything, doing some should alleviate some of the stress. The most complete documentation...
I am unsure how this can help with eclipse-cs metadata maintenance. As I understand I would still need to meticulously check all changes in a Checkstyle release, whether they have any relevance for the metadata. Could you give an example of something you think would have to be manually done and couldn't be automated? I can only speak from my experience with sevntu's eclipse-cs files. The most complete documentation we have is in the xdocs where we have another junit to make sure it has required sections,...
First a Hello to all, this is my first posting here! I have a problem with eclipse-cs when upgrading from Neon.3 to Oxygen.R. (I use Eclipse on Windows 10-1703) Minimal steps from scratch to demonstrate the problem: 1. Downloading eclipse-jee-oxygen-R-win32-x86_64.zip from eclipse.org 2. Unpacking the zip file. 3. Starting eclipse.exe with option -vm pointing to C:/My path/jre1.8.0_131/bin and accepting the newly created empty default workspace. 4. Installing Checkstyle plugin from Update Site: http://eclipse-cs.sourceforge.net/update/...
@Roman - thanks and agreed, hosting eclipse-cs sources under the Checkstyle organisation in Github would be the best course. I'll send you a private message shortly. @Richard - interesting, although I am unsure how this can help with eclipse-cs metadata maintenance. As I understand I would still need to meticulously check all changes in a Checkstyle release, whether they have any relevance for the metadata. Ideally Checkstyle itself would expose this metadata (e.g. via annotations) to integration...
Most of the time the bulk of work is hunting down Checkstyle changes which require metadata changes using the Checkstyle release notes. I assume you mean the metadata files that define checks, properties, and they descriptions, values, etc... like \net.sf.eclipsecs.checkstyle\metadata... Have you though of automating most of it? Sevntu automates it's eclipse-cs files using junits that tell when something is wrong or missing in the file. We use reflection and our inner utils to identify checks and...
Hi Lars, thanks a lot for your help through may years to keep project up todate. I could recommend to move source to github - https://github.com/checkstyle , to our organization . You and Eric and Bananeweizen could have RW access to repository to keep it moving, any other contributors are welcome too. I already did suh a proposal to you few years ago ;) . I managed to setup good practices in development workflow in checkstyle repo and amount of Pull requests is far above I can process, but we keep...
Hi Lars, thanks a lot for your help through may years to keep project up todate. I could recommend to move source to github - https://github.com/checkstyle , to our organization . You and Eric and Bananeweizen could have RW access to repository to keep it moving, any other contributors are welcome too. I already did suh a proposal to you few years ago ;) . I managed to setup good practices in development workflow in checkstyle repo and amount of Pull requests is far above I can process, but we keep...
Lars, I am willing to help with bug fixes and releases. If you don't want to write up the release steps, you could demonstrate everything in my WebEx channel and I could record it and write the steps from that. That way I could ask questions along the way and possibly have stuff repeated for clarity. Let me know.
What about having an organizational (not individual) account at github to host the sources? This works well for a lot of projects and allows more easy contributions by others than the Sourceforge system. I just created https://github.com/eclipsecs as a placeholder to showcase this. However, I will happily transfer ownership of that account to you (or delete it, if you want to do something similar on your own). Just to be clear: I do not intend to become a new lead for this project. I'm willing to...
Hey Eric. There is effort required for actually updating the plugin to the latest Checkstyle version. Most of the time the bulk of work is hunting down Checkstyle changes which require metadata changes using the Checkstyle release notes. The build itself is automated via Maven/Tycho, however, getting a release out is a multi-stepped, non-automated process. For instance updating the plugin from 8.0 to 8.5 took me about a day of work for updating and releasing. If I had updated to all intermediary...
Thanks for the quick fix!
Oh, how did that slip through... Fixed now and new version 8.5.1 made available.
Configuration via dialog no longer possible with version 8.5
Prepare 8.5.1 release
#429 Configuration via dialog no longer possible with version 8.5
Configuration via dialog no longer possible with version 8.5
I can confirm: It is working, thank you!
Hi Lars. Thanks for all your hard work over the years. I have been using eclipse-cs for many years now. Just wondering how much effort is required (aka how much is automated in terms of operations)?
that's a nice Christmas gift, thanks Lars :)
The problem still exists, but thanks for your efforts. I'll turn to the core project.
If this is still an issue for you, please report this to the Checkstyle core project, over at https://github.com/checkstyle/checkstyle
eclipse-cs 8.5.0 based on Checkstyle 8.5 has been released.
eclipse-cs 8.5.0 based on Checkstyle 8.5 has been released.
Site fix
Disable jgit build timestamp since it appears not to be working correctly - different timestamps for the subprojects
Did you also manage to get rid of the warning I mentioned? Ah, yes I did, see https://sourceforge.net/p/eclipse-cs/bugs/428/ :-)
Latest changes are in this branch: https://sourceforge.net/p/eclipse-cs/git/ci/adopt_checkstyle_8.5/tree/ Good to know. With your additional information I was able to reproduce and fix the issue. Awesome. Thanks. Did you also manage to get rid of the warning I mentioned? (Commands should really have a category: plug-in='net.sf.eclipsecs.ui', id='CheckstylePlugin.PurgeCaches', categoryId='net.sf.eclipsecs')
ClassCastException: net.sf.eclipsecs.ui.actions.PurgeCachesAction cannot be cast to org.eclipse.core.commands.IHandler
Latest changes are in this branch: https://sourceforge.net/p/eclipse-cs/git/ci/adopt_checkstyle_8.5/tree/ With your additional information I was able to reproduce and fix the issue.
#420 Fix ClasscastException with Quick access bar
Use Checkstyle 8.5
Prepare 8.5.0 release
#424 Fix for potential NPE
#427 Clean Checkstyle markers on Clean-Action
Please try 8.5.0 once it's out. FYI, I tried building the current master (fcc935d3ed4e66cbd6777cd48535fb2c24ca449c; it’s still at version 8.0.0, correct?), installed from the locally build update site, and the problem still occurs under Photon M4.
To reproduce: Go to the Quick Access bar in the upper right and enter some text. This causes Eclipse to load the command defintions and triggers the exception, logged as an error in the Error Log. I also get a warning in the Error Log that might be related, as the same command is referenced: Commands should really have a category: plug-in='net.sf.eclipsecs.ui', id='CheckstylePlugin.PurgeCaches', categoryId='net.sf.eclipsecs'
Still seeeing this under Eclipse Photon M4 with Eclipse Checkstyle Plugin 8.0.0.201707161819. STATUS pluginId org.eclipse.ui pluginVersion 3.109.100.v20171116-2149 code 0 severity 4 message The proxied handler was the wrong class fingerprint 8b7964d9ec64027a6f6ae85132aa1083 Exception:java.lang.ClassCastException: net.sf.eclipsecs.ui.actions.PurgeCachesAction cannot be cast to org.eclipse.core.commands.IHandler at org.eclipse.ui.internal.handlers.HandlerProxy.loadHandler(HandlerProxy.java:350) at...
ClassCastException: net.sf.eclipsecs.ui.actions.PurgeCachesAction cannot be cast to org.eclipse.core.commands.IHandler
I don't seem to hit this error with Oxygen.1a and the latest plugin code. Please try 8.5.0 once it's out.
Hey there! You might have noticed - or even been disappointed - by the slow rate of recent updates to this project. After nearly 13 years of maintaining eclipse-cs I noticed that I am losing interest and updating this project is becoming a chore. Also I have been taking up different interest in my spare time, like playing guitar or getting a bit back in shape - which leaves even less time. If you're interested in keeping this project afloat and more regularly updated - and want to lend a hand - please...
Hey there! You might have noticed - or even been disappointed - by the slow rate of recent updates to this project. After nearly 13 years of maintaining eclipse-cs I noticed that I am losing interest and updating this project is becoming a chore. Also I have taking up different interest in my spare time, like playing guitar or getting a bit back in shape - which leaves even less time. If you're interested in keeping this project afloat and more regularly updated - and want to lend a hand - please...
Support CustomImportOrder in eclipse formatter.
Unhandled exception on every file that gets opened
Closing for housekeeping.
NPE on SuppressWarningsHolder
Closing for housekeeping, this issue had been fixed in Checkstyle core (quite) a while back.
Closing for housekeeping, please take it up with Checkstyle core, if this is still an issue for you.
WriteTag warnings do not work when severity is ignore
If this would be done (it could, presumably), how would one discern those exceptions from honest bugs in Checkstyle core? Back in the day, eclipse-cs used to pop up an error dialog, which was truly disturbing. Nowadays it just logs an Checkstyle error, like "hey, something unexpected happened, please check the error log if you care" - which I think is pretty unobtrusive, while still retaining all the information needed for bug hunting. How would you propose to solve this?
'Purge Checkstyle caches' toolbar action violates Eclipse UX standards
This had been improved upon in release 7.6.0 already, sorry for not closing the bug. The toolbar item should now be consistently hidden to start with. Users asking for this feature can un-hide the item by configuring the perspective actionsets accordingly. The button remains ugly, however, but at least the tooltip is more informative.
java.lang.NullPointerException when trying to run checkstyle
I couldn't reproduce the issue with your configuration file, however, I put some safeguards in place to prevent the NPE at the affected position. Fix will be in upcoming 8.5.0
I couldn't reproduce the issue with you configuration file, however, I put some safeguards in place to prevent the NPE at the affected position. Fix will be in upcoming 8.5.0
Great! Thanks a lot.
Error initializing TreeWalker
@Nonnull annotation before ellipsis operator causes exception
This is a problem in Checkstyle core, which might have been fixed already. Please try eclipse-cs 8.5.0 once it's out. If the problem persists please report this to the Checkstyle core project (https://github.com/checkstyle/checkstyle).
Project / Clean operation doesn't remove checkstyle warnings
Project / Clean operation doesn't remove checkstyle warnings
Will be fixed with upcoming 8.5.0
Warnings in Eclipse Console when starting RCP application due to missing category for commands
Fixed for upcoming 8.5.0 release
Hey Lars, hey Manuel, I know this ticket is like one decade old (it's exactly 10 years since last answer! :D) but I could really use this feature. Is there any progress on this? Otherwise I'll have a look at it. Regards, Alex
Hey Lars, hey Manuel, I know this ticket is like one decade old (it's exactly 10 years since last answer! :D) but I could really use this feature. Is there any progress on this? Otherwise I'll have a look on it. Regards, Alex
Warnings in Eclipse Console when starting RCP application due to missing category for commands
Project / Clean operation doesn't remove checkstyle warnings
Checkstyle released fix for https://github.com/checkstyle/checkstyle/issues/4916 . Lars, please upgrade to latest version of checkstyle to allow third-party checks.
I am hoping the find the time for the update during my christmas vacation. Apart from that patches/pull requests are certainly welcome. The bulk of work for the upgrade lies in updating the XML metadata for Checkstyle modules the plugin uses to provide the configuration editor.
Apart from that patches/pull requests are certainly welcome. The bulk of work for the upgrade lies in updating the XML metadata for Checkstyle modules the plugin uses to provide the configuration editor.
I'm hoping to find the time for an update during my christmas vacation. Beyond that patches/pull requests are certainly welcome. The bulk of work for the upgrade lies in updating the XML metadata for Checkstyle modules the plugin uses to provide the configuration editor.
This lack of update is really annoying. It completely prevent the tool to be used: Eclipse complains that there is an error in checkstyle configuration (because the configuration had to be changed for the newest versions), and does not run at all. The plugin is useless as is, but was really a great help when it could be used, months ago. What could we do to help?
No, I have not found a solution - other than just performing checkstyle checks with maven on the command line. But we would really like to see this implemented in the eclipse plugin as it is much faster to fix the problems when we are writing the code. I was hoping that the maintainer of the plugin could reply with some sort of ETA. I tried looking into forking and upgrading the plugin myself, hoping it was as simple as bumping the checkstyle version in a pom file somewhere - but the version number...
I have seen a pull request which might fix the problem: https://github.com/checkstyle/checkstyle/pull/5245
@Nonnull annotation before ellipsis operator causes exception
Can't start Checkstyle in Eclipse Version: Oxygen.1a Release (4.7.1a)
I have the same problem too. Did you find a resolution to this?