#94 Automatic diff when checking in files

ui
closed-fixed
clearcase (41)
5
2012-02-23
2011-09-28
No

Sine we have started to have mandatory comments when checking in files I always do a diff before I do a check in to see what have been changed.
It would be extremely nice if the window where I write my check in comment would have an diff between the checked out version and the previous version above the field where you write your check in comment. I guess not all people would like that feature so it should probably be an option. I guess this should not be that hard to fix now when there is an internal ClearCase diff. The internal diff just needs to be integrated with the check in dialog.

Discussion

  • Mikael Petterson

    Hi,

    This feature is already available in Eclipse. If you double click on the file you are about to checkin then you should see a diff.
    Let me know if you have any trouble performing the operation.
    br,

    //mike

     
  • Mikael Petterson

    • assigned_to: nobody --> eraonel
    • milestone: --> ui
    • labels: --> clearcase
    • status: open --> pending-remind
     
  • Stefan Rystedt

    Stefan Rystedt - 2011-10-05

    The check in dialog blocks all other windows in eclipse so there is no way to do an diff when checking in a file. Now I have to do an diff first write my comments some where else and the do the checking and copy my comments to the checkin dialog.

    I am used to the emacs clearcase plugin where you can get an automatic diff when you do an checking which I really like. This merge two task into one which means I need to click less things (or use less keyboard short cuts).

    I am not sure when or where you want me to double click the file. Double clicking a file only opens up the editor. I using an icon in eclipse to do the diff right now. I can of course not double click anything when the checking dialog is opened since it blocks all other windows.

     
  • Stefan Rystedt

    Stefan Rystedt - 2011-10-05
    • status: pending-remind --> open-remind
     
  • Mikael Petterson

    Hi,

    Thanks for your interest in the plug-in and I make my best to compete with emacs ( which I really like)...

    It could be that I this feature only exists for cvs/svn check-in. I will make a quick check tomorrow morning.
    Thanks for the very good description.

    br,

    //mike

     
  • Mikael Petterson

    Hi,

    I have checked it. And it is cvs that has ( for sure) this function and not in cc plugin.
    I think it is a good feature and I can fix that.

    br,

    //mike

     
  • Mikael Petterson

    • status: open-remind --> open-accepted
     
  • Mikael Petterson

    I did some checking and it is not as easy done as said but manageable.
    As it is now I am working on UCM support and when that is fixed I will start with your feature request. Hope that you can wait :-)

    br,

    //mike

     
  • Mikael Petterson

    I have stared working on this. However not as simple as indicated by submitter :-)

    br,

    //mike

     
  • Mikael Petterson

    • status: open-accepted --> pending-accepted
     
  • Mikael Petterson

    First version will be in 2.2.13 release date today :-)

    //mike

     
  • Stefan Rystedt

    Stefan Rystedt - 2012-02-17

    Thanks for quick fix for this request. It is unfortunately very seldom thinks are as easy to implement as it looks in the beginning.

    I have tested the new version and the diff works. But there are some things that I think could be done better. One Thing is the dialog where you should write the comment. The size of the comment field seems to be fixed because it does not change when I do resize the dialog.

    The diff window is implemented as an none resizeable dialog window. It would be nice if it was resizeable.

    You see this is the problem with implementing request then the user just wants more and more :-)

     
  • Stefan Rystedt

    Stefan Rystedt - 2012-02-17
    • status: pending-accepted --> open-accepted
     
  • Mikael Petterson

    Hi Stefan!

    Thanks for testing it and providing feedback. I really appreciate the feedback. That makes me going :-) I think the feedback that you provided is most relevant and I will implemented to next release ( it is actually in my backlog for this task). So I will make a new release asap with your suggested enhancements.

    //mike

     
  • Stefan Rystedt

    Stefan Rystedt - 2012-02-21

    It seems that it does not remember my check in comments any more. after the upgrade. Only my old check in comments is shown.

    Should create an bug report for this?

     
  • Mikael Petterson

    Hi,

    Yes please file a bug report on this so it will not be missed.

    br,

    //mike

     
  • Mikael Petterson

    Just one minor question:

    You say that it does not remember your comments anymore but then you say that your old comments are shown. Can you attach a snapshot and/or clarify which comments does not show.

    //mike

     
  • Mikael Petterson

    Found the problem.

    //mike

     
  • Mikael Petterson

    We can consider this implemented now. If any changes needed please file a bug report.

    //mike

     
  • Mikael Petterson

    • status: open-accepted --> closed-fixed
     

Log in to post a comment.