Menu

#145 mis-spelling transitionTimerManager.class name

v3.1.1-beta
open
sipservlet (76)
5
2012-04-11
2012-04-11
No

need to investigate and possibly modify behavior of echarts/e4ss when the class name specified for the JVM property org.echarts.system.transitionTimerManager.class is mis-spelled

currently e4ss sets the value of the timer manager class system property during servlet initialization so it is no longer necessary to specify the timer manager on the command line

in any case, e4ss should emit a warning message when there is an attempt to set the timer manager class (mis-spelled or not) on the command line - this approach is now deprecated since the timer manager is now set by the e4ss runtime

from echarts perspective, we should re-examine if the messages output when a timer class name is mis-spelled are adequate i.e., will they be noticed by the developer?

Discussion

  • Gregory W Bond

    Gregory W Bond - 2012-04-11

    from an exchange between tom and greg:

    On Apr 11, 2012, at 4:12 PM, Gregory Bond wrote:

    > i was thinking that e4ss could check if there was anything other than the default timer set as the value of the system property
    >
    > On Apr 11, 2012, at 4:05 PM, Tom Smith wrote:
    >
    >>> in any case, e4ss should emit a warning message when there is an attempt to set the timer manager class (mis-spelled or not) on the command line - this approach is now deprecated since the timer manager is now set by the e4ss runtime
    >>
    >> Not sure how E4SS can do this, since ECharts reads and acts on those JVM properties. Or am I missing your point?

     
  • Gregory W Bond

    Gregory W Bond - 2012-05-23

    if there is evidence that the timer manager has been changed, then the logger should emit an ERROR message - note that the logger needs to be initialized first, so careful attention should be paid to the relative order of timer manager initialization and logger initialization in the servlet init() method

     

Log in to post a comment.