Re: [Ebtables-devel] [PATCH] selective IP NATing on a bridge (like NETMAP)

[Bart De S. <bds...@pa...>]

Op ma, 19-12-2005 te 04:55 +0100, schreef Carl-Daniel Hailfinger:
> Please find two patches attached (to avoid whitespace mangling):
> - lindent of the files I worked on
> - functional changes only.
> Patches are against 2.6.15-rc5 and are compile tested only.
> 
> What do you think?

I don't like the lindenting:
- In the kernel code, structs almost always have their '{' on a new
line.
- Changes that only make the code 2 lines longer aren't good
- The one-space nitpicking isn't worth the diff overhead
- The alterations in struct arpt_target just make it look worse

Did you try if this code works? I don't think it will. Unless something
recently changed, you can't register 2 targets with the same name in
arptables. Iptables solved this by introducing the versioning
(revision). Doing this in arptables will imply rewriting some code in
arp_tables.c, and I don't think it's worth it (as I said before). Unless
someone finds the time to actually do those changes and test them of
course. That's why I referred you to that mail (which got outdated
w.r.t. the way to do it in iptables now). If you really want to be sure
what approach to take, you should ask David Miller, as he's the kernel
maintainer of arptables and your patch will have to be approved by him.

cheers,
Bart