Menu

#7 src/libepub/linklist.c:140]: (style) Suspicious condition

v1.0 (example)
open
nobody
None
5
2016-05-03
2016-05-03
dcb
No

book-tools-0.2.2/src/libepub/linklist.c:140]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if ((Compare = (List->compare)(List->Current->Data, Data) != 0))

Maybe better code

if ((Compare = (List->compare)(List->Current->Data, Data)) != 0)

Discussion


Log in to post a comment.