#19 match "wildcastle" and "nocastle" names to "wild/[012]"

closed-fixed
None
5
2007-01-14
2007-01-13
Anonymous
No

Similiar to SF #1632083, this patches matches two more variant names from the winboard v2 spec [0] to the FICS designation:
wild/0, wild/1 -> "wildcastle" [1]
wild/2 -> "nocastle"

Another change is to position.cc: the if before checkCastlingPossibility didn't check for WILDFR, which is obviously bad, as checkCastlingPossibility doesn't account for different initial positions than the standard one.

[0] http://www.tim-mann.org/xboard/engine-intf.html
[1] wild/0 is the same as wildcastle, but with a single known initial position, so it's presented as wildcastle with the apporpriate FEN. FICS does the same for engines: http://www.freechess.org/Help/HelpFiles/new_features.html (1.25.5)

Discussion

  • Nobody/Anonymous

    patch to add "wildcastle" and "nocastle"

     
  • Felipe Bergo

    Felipe Bergo - 2007-01-13

    Logged In: YES
    user_id=23863
    Originator: NO

    will test and eventually commit in the next hours.

     
  • Felipe Bergo

    Felipe Bergo - 2007-01-13
    • assigned_to: nobody --> bergo
    • status: open --> open-accepted
     
  • Felipe Bergo

    Felipe Bergo - 2007-01-14
    • status: open-accepted --> closed-fixed
     
  • Felipe Bergo

    Felipe Bergo - 2007-01-14

    Logged In: YES
    user_id=23863
    Originator: NO

    applied to the CVS with minor changes.

     
  • Nobody/Anonymous

    Logged In: NO

    // nitpicking: contra the Changelog, the PGN standard does not even define the "Variant" tag. These changes are to comply with the winboard v2 standard, as engines (and xboard) use the same standard variant names when reading PGNs and when accepting the "variant" command.

     
  • Nobody/Anonymous

    Logged In: NO

    one more thing: there's an error in eboard.h namely:
    #define IS_NOT_WILD(v) (((v)!=WILD)&&((v)==WILDFR)&&((v)!=WILDCASTLE)&&((v)!=WILDNOCASTLE))

    where it should be (v)!=WILDFR, of course. I don't understand what's wrong with:
    #define IS_NOT_WILD(v) (!(IS_WILD(v))

     
  • Felipe Bergo

    Felipe Bergo - 2007-01-14

    Logged In: YES
    user_id=23863
    Originator: NO

    fixed. No real good reason for writing one way or the other.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks