Re: [Ebib-users] ebib unstable 57f8af86d3 fails on 'ebib-edit-field'

[Robbie M. <ro...@ac...>]

Hi Joost

Your two last emails are stripped together below.

------------------------------------------------------------
To:           ebi...@li...
Subject:      Re: [Ebib-users] ebib unstable 57f8af86d3 fails on
'ebib-edit-field'
Message-ID:  <201...@pc...>
From:         Joost Kremers <joo...@fa...>
Date:         Tue, 21 Aug 2012 15:07:55 +0200
------------------------------------------------------------

> On Tue, Aug 21, 2012 at 02:54:40PM +0200, Joost Kremers wrote:
>
>> in the mean time, i'll see whether i can add some
>> code to make ebib compatible with 23.1.
>
> i just created a compat branch that should fix this
> issue for you. try it and see if it works.

  $ git checkout compat
  Branch compat set up to track remote branch compat from origin.
  Switched to a new branch 'compat'

Yes, it works as before (with the tarball 1.9.1).

  $ git tag
  v1.9.0
  v1.9.1

That works too!

> --
> Joost Kremers
> Life has its moments
> _______________________________________________
> Ebib-users mailing list
> Ebi...@li...
> https://lists.sourceforge.net/lists/listinfo/ebib-users

------------------------------------------------------------
To:           ebi...@li...
Subject:      Re: [Ebib-users] ebib unstable 57f8af86d3 fails on
'ebib-edit-field'
Message-ID:  <201...@pc...>
From:         Joost Kremers <joo...@fa...>
Date:         Tue, 21 Aug 2012 14:54:40 +0200
------------------------------------------------------------

> Hi Robbie,
>
> On Wed, Aug 22, 2012 at 12:01:02AM +1200, Robbie Morrison wrote:

[snip: emacs versions]

> ok, that explains it then. i thought you'd been using
> the git version all along. version 1.9.1 used the
> function interactive-p to determine if
> ebib-edit-field was called interactively. that
> function has been made obsolete in emacs 23.2 so i
> changed it to called-interactive-p, as per the
> recommendation. this function apparently exists in
> emacs 23.1, but it doesn't take any arguments. in
> 24.1 it takes one.

True.  For 23.1:

  (called-interactively-p)

  Return t if the function using this was called with
  `call-interactively'.  This is used for implementing
  advice and other function-modifying features of
  Emacs.

  The cleanest way to test whether your function was
  called with `call-interactively' is by adding an
  extra optional argument, and making the `interactive'
  spec specify non-nil unconditionally for that
  argument.  (`p' is a good way to do this.)

> the quickest fix for you is probably to remove the
> 'any argument from all calls to
> called-interactively-p in ebib.el (there are
> three). in the mean time, i'll see whether i can add
> some code to make ebib compatible with 23.1.

Or are you going to make 23.2 or better a requirement?

That would seems a bit limiting.

[snip: tags]

> best,
>
> joost
>
> --
> Joost Kremers
> Life has its moments
> _______________________________________________
> Ebib-users mailing list
> Ebi...@li...
> https://lists.sourceforge.net/lists/listinfo/ebib-users

---
Robbie Morrison
PhD student -- policy-oriented energy system simulation
Institute for Energy Engineering (IET)
Technical University of Berlin (TU-Berlin), Germany
University email (redirected) : mor...@ie...
Webmail (preferred)           : ro...@ac...
[from Webmail client]