Re: [Ebib-users] 'ebib-file-search-dirs' documentation suggestion

[Joost K. <joo...@fa...>]

Hi Robbie,

On Wed, Aug 15, 2012 at 11:50:43AM +1200, Robbie Morrison wrote:
> Possible improvement -- code like this would protect
> against this kind of user mistake (and yes I know I
> could have used Configure):
> 
>   (unless (listp ebib-file-search-dirs)
>     (warn "configuration variable ebib-file-search-dirs must be a list"))
> 
>   also for 'ebib-preload-bib-files'
> 
> Otherwise 'ebib' gives the following somewhat
> misleading error message:
> 
>   "No valid filename found in field `file'"
> 
> Just a suggestion.  No strong feeling on this.

I see your point, but to be consistent, I'd have to include similar checks
for all customizable variables. However, one of the reasons for using
Customize is that it makes sure the variables have proper values, so
there's really no need for such checks, IMHO.

On the other hand, the error message isn't helpful at all, I agree. I'll
have to think about the best way to make the code more robust, though.

Best,

Joost


-- 
Joost Kremers
Life has its moments