Menu

#20 BytesRead be renamed

closed-fixed
Bug Report (11)
5
2006-10-31
2006-10-20
Yongzhi Pan
No

EasyBMP is great! Thank you Paul! I'll tell my story later.

In EasyBMP.cpp (version 1.04), at line 1174 there is

int BytesRead;

Then at line 1177 and below there is

BytesRead = (int) fread( buffer , size , number
, fp );
if( BytesRead < number )

Here BytesRead is in fact not the number of bytes read,
but the number of blocks read. I suggest BytesRead be
renamed to ItemsRead or anything else more appropriate.

This is trivial, but it confused me at the first glance. :p

Discussion

  • Paul Macklin

    Paul Macklin - 2006-10-27

    Logged In: YES
    user_id=1202584

    Hello, and thanks for taking the time to provide feedback.

    This is a good point, and I'll give it a good look in the
    next release. Thanks. :-) -- Paul

     
  • Paul Macklin

    Paul Macklin - 2006-10-27
    • status: open --> closed-later
     
  • Paul Macklin

    Paul Macklin - 2006-10-31

    Logged In: YES
    user_id=1202584

    I agree with the user comment, and changed the variable name
    in Version 1.05 accordingly.

     
  • Paul Macklin

    Paul Macklin - 2006-10-31
    • status: closed-later --> closed-fixed
     

Log in to post a comment.