#2 Data scaling (chds) support

closed
None
7
2008-07-18
2008-06-24
No

This patch adds support for the data scaling parameter (chds) requested in feature request 1939362.

Discussion

  • Niklas Therning

    Niklas Therning - 2008-06-24
     
  • Niklas Therning

    Niklas Therning - 2008-06-24

    Logged In: YES
    user_id=1101005
    Originator: YES

    Found a bug in my patch. The lines

    if (scales.length < scaleIndex) {
    min = scales[scaleIndex];
    max = scales[scaleIndex + 1];
    } else {
    min = scales[scales.length - 2];
    max = scales[scales.length - 1];
    }

    should be

    if (scaleIndex < scales.length) {
    min = scales[scaleIndex];
    max = scales[scaleIndex + 1];
    } else {
    min = scales[scales.length - 2];
    max = scales[scales.length - 1];
    }

     
  • Niklas Therning

    Niklas Therning - 2008-06-25

    Logged In: YES
    user_id=1101005
    Originator: YES

    Found some more bugs in my previous patch. Using min != 0 in chds didn't work as expected. I'm attaching a new patch which I think will work better.
    File Added: chds2.patch

     
  • Niklas Therning

    Niklas Therning - 2008-06-25
     
  • David Gilbert

    David Gilbert - 2008-07-14

    Logged In: YES
    user_id=112975
    Originator: NO

    This looks pretty good. While studying the existing data parsing code, I decided on some refactoring which I'm in the middle of doing at the same time as integrating this patch. I'll keep you posted.

    Regards,

    Dave

     
  • David Gilbert

    David Gilbert - 2008-07-14
    • priority: 5 --> 7
    • assigned_to: nobody --> mungady
     
  • David Gilbert

    David Gilbert - 2008-07-18

    Logged In: YES
    user_id=112975
    Originator: NO

    This has gone into 1.1.0 which I released just now. Hopefully my refactoring didn't break anything!

    Regards,

    Dave

     
  • David Gilbert

    David Gilbert - 2008-07-18
    • status: open --> closed
     

Log in to post a comment.