SourceForge has been redesigned. Learn more.
Close

#293 Open SUB ignores 'require'

v0.5.x
closed-fixed
Editor (234)
5
2006-09-04
2006-08-31
LeO
No

I see that in change log 1306168 now overrules 810926
which makes me now :(

I can somehow follow the arguments posted in 1306168,
nevertheless the Perl-project I am working with has a
lot of 'require' in it and reference as well to them
(in a static way). Therefore I implemented 810926 and
would have expected that code-fixing means fixing the
code instead of getting rid of it.

Since the 'require' worked I see it as a Bug not having
this Feature any longer (as before: in static ways).
And opening only local Sub-Definitions does not seem
very efficient at all.

BTW: Why is the Keyboard-shortcut F3 not any longer there?

Discussion

  • Jan Ploski

    Jan Ploski - 2006-08-31

    Logged In: YES
    user_id=86907

    Fixed in CVS for 'stable' (waiting for release) and in
    'testing' 0.5.2 (just released). I extended the original
    algorithm to also cope with "require Foo::Bar;" besides of
    "require 'Foo/Bar.pm';".

    I don't understand your remark that "opening only local Sub-
    Definitions does not seem very efficient at all". The
    search starts from the current file and proceeds through
    all the 'use'd modules. Now it also goes through the
    'require'd files (recursively).

    The F3 key works fine for me (and is defined as a shortcut
    in plugin.xml), so it's something to do with your local
    configuration.

     
  • LeO

    LeO - 2006-09-01

    Logged In: YES
    user_id=703323

    Uhu,

    Since I can install only via remote, I have downloaded the
    new package, uninstall and new install, but after this the
    version remains as 0.5.1. Any ideas?

    The main reason why I claim this issue, is the developement
    is remote on a Unix, ie. the 'use' makes not much sense to
    search on that remote machine.

    F3 is configured, but does not work. Any idea what to check
    additionally? In the Preferences - General - Keys there is
    no Category Perl Source, and on Modify it does not show
    anything. As well as in the 'Name' it does not propose
    anything useful. Any ideas?

     
  • Jan Ploski

    Jan Ploski - 2006-09-01

    Logged In: YES
    user_id=86907

    I'm not sure what you have downloaded... If you cannot (?)
    install through the remote update site, you can download
    the contents of http://e-p-i-c.sf.net/updates/testing/
    * (including the 'plugins' and 'features' subdirectories -
    actually, you only need to download the newest version of
    each plug-in and the newest version of the feature), place
    them in some local directory and point the update manager
    to it as a 'local update site'. After a successful
    installation the version of both the feature and the
    org.epic.editor plug-in should be 0.5.2.

    As for the F3 shortcut, the only thing I can imagine is
    that some other software (for example, the window manager)
    is intercepting the key stroke. You should try to assign
    another key and see if it works to test this hypothesis.
    The "Open Declaration" action appears in category
    "Navigate". In my setup, it is assigned "F3" as Key
    Sequence and When is set to "In Windows". This same
    shortcut works both in Perl and in Java code. BTW, the
    category "Perl Source" is also there.

    I'd also like to point out the hyperlink feature (hold down
    Ctrl and click = Open SUB Declaration), which I prefer. A
    matter of taste, but the hyperlinks are nice because they
    ca be extended some day to also navigate into modules (via
    point-and-click on a module name).

     
  • Jan Ploski

    Jan Ploski - 2006-09-02

    Logged In: YES
    user_id=86907

    I just released stable 0.4.5 including this fix.

     
  • LeO

    LeO - 2006-09-04
    • status: open --> closed-fixed
     
  • LeO

    LeO - 2006-09-04

    Logged In: YES
    user_id=703323

    ThX for THAT quick fix + update :)

    I'm using it most of the time in Office and the Firewall
    suX. I was as well unable to committ to CVS and currently I
    didn't figure out, how to configure the
    Eclipse-plugins-update-site correctly. I guess after some
    hours of pain, probably :|

    About the Keyassignments: I have not figured out how to
    correct the F3-issue. But I see it as minor priority since
    this wonderful feature Ctrl+Left-Mouse-Click works GREAT :)

     

Log in to post a comment.