From: Kevin <ke...@ke...> - 2003-05-17 13:18:10
|
Sorry this is a long one I should have split it in two e-mails. "Raymond Irving" <xw...@ya...> wrote: > Firstly, it's awesome! An absolutely amazing concept! > Using IE with tabmanager2 demo I feel as though I'm > using a windows app. The DataSource & FocusManager > integrates well with the examples. It's Perfectly > Amazing! > > Very nice work Kevin. Two-Thumbs up for the TabManager Thanks. It did take some time to get working. > My comments are as follows: > > 1) I think you should also post a copy using the > sourceforge patch system. If you don't have CVS access > (can't see why not) I can upload these changes by > weekend. I have read access to CVS. I don't really want write access as I may break things. If TabManager is tested on a mac and all is well please add it to CVS. > 2) Any (quick ref) documentation on how to use the new > features? If I can. Is there a quick ref html auto generation system that works from definition lists? > 3) Is the callSubmitFn() necessary? I see where you're > already using the onsubmit event which in my opion > will make the callSubmitFn redundant. I don't understand? Say we have 10 menus x 8 tab buttons (like my Acronyms datasource + 9 other data tables). Now the onsubmit event listener neatly changes the tab color for all 80 buttons but how would it know what action to take? Say the event was from the tab that refered to datasource instance 7 and required a call to the moveLast method. A big if () ... else if() ... else if() ... 80 times? 1) the user can add a unique name to each tab and do a big if statement for all tab instances in the onsubmit event listener 2) addSubmitFn('dsInstanceN.methodN()') to each tab and one src.callSubmitFn() in the event listener 3) add a unique name to each tab that defines the action (only simple callbacks and '-' replaces the '.') tabNM.setID('dsInstanceN-methodM()') This is used in the Acronyms datasource example. I had hoped that a page of many datasource menus could be auto generated with attributes defined in <style> .. tags. Then as in 3 above object style #dsInstanceN-methodM { left:x; ..} would give the correct callback. > Please see below for other comments: Yes I have replied below. > --- Kevin <ke...@ke...> wrote: > > Hi, > > > > Here is the TabManager code and a couple of > > demonstrations. > > Unpack in the dynapi3x root directory. > > > > Is there a dependency between IOElement/DataSource > > and > > functions. I didn't think I'd have to explicitly > > include it. > > Yes, there is a dependency between the IOElement and > DataSource libraries. By including DataSource > IOElement will be automatically included. I was refering to functions not automatically included. I like the dependency chain. So DataSource includes IOElement which the functions either need? > > Also > > a fix for problems with the _destroy system. > > Ok > > > Thanks for the comments about my BorderManager > > updates. > > I don't have much time to work on it at the moment. > > Understand. We'll try to see how best we can merge the > two together. > > > Anyway > > have fun with TabManager. I've given up with any > > real use of > > style sheets as it would require several changes to > > the api and > > getting agreement for this would be difficult. > > I thought the getElmWidth resolved all that? Mmm maybe! This was just w,h if I remember right. IMO left,top,width,height,clip,visibility,z-index, background-color,background-image etc. may have their default values set in head <style> ... </style> tags. The api setting z-index=1, w,h=0, visible=true etc. is passed through to getOuterHTML messes style sheet defaults. The api shouldn't touch. When the element is rendered does _assignElement need to look at css and fill in the null attributes of the DynLayer instance. If it does it should do it for all values that could have come from style sheets. I have tried most of this then to find various quirks in NS4. Also how to get at css values in Mozilla they are blank if set in <style> ... </style> and ok if set in style=" " (we have currentStyle in IE). Anyway that was it so I gave up :( - Kevin > Keep up the good work. > > -- > Raymond Irving > > > - > > Kevin. > > > > > ATTACHMENT part 2 application/x-zip-compressed > name=tabmanager-update.zip > _______________________________________________ > Dynapi-Dev mailing list > Dyn...@li... > http://www.mail-archive.com/dyn...@li.../ |