From: Benoit M. <mar...@ma...> - 2003-05-15 00:31:21
|
Very nice !! See my comments bellow. On Wednesday, May 14, 2003, at 01:14 PM, Kevin wrote: > > "Raymond Irving" <xw...@ya...> wrote: > >> Kevin, >> >> Nice work! It looks great! I have a few suggestions: >> >> 1) DynLayer(html,x,y,w,h,color,image) - Some time ago >> DynLayer had so many arguments that it was very >> difficult to work with. With 2.9 Dan took the >> initiative to only use the most commonly used >> arguments. I would suggest that we keep only 6 >> arguments inside the constructor in order to try and >> keep it simple, but since we already have background >> color I think it's only fitting to have background >> image as part of the constructor. Agree? Can we stop >> at seven? > > Ok stop at 7 but 10 is a nice number ;-) and we can have > the full set with anchor, visible and z-index? > >> 2) Highlighter(x,y,w,h,color,image) - the same as >> above. For Skins() "image" is already part of the >> dictionary object. > > I nearly added anchor to the constructor but stopped > Though I dropped x,y from Skin as it uses anchors. > >> 3) Another name for setBorder2 could be >> setSkinBorder()? > > Fine. One thing I was going to add was a borderBasic. > i.e. Just 2 layers container and content. So container is > set to border color and content is center anchored. I agree that if you happens to have all borders of equal size and color, it would be more efficient. But this should be an implementation detail hidden in the setBorder method rather than a new api. Also it's kind of an internal class, I'm not sure Skin is a right name for what is really a frame part. I have used png image files with alpha transparencies (for drop shadows) , and unfortunately, the most supported way for a proper rendering of the alpha transparency is to use the image in a tag IMG. If you use such a file as a div background image, it doesn't render as expected. Which means that if the image files are png, a special case should be made and then use the html for the different borders using a png. Which means that when the size change, the html has to be re written to stretch the png so se, it works fine for drop shadows where I had to do this. Why couldn't we have one setBorder ? or setFrame() ? Then we either automatically pass a dictionary that describes the frame, and that dictionary could cover all configuration about individual borders size/color/image, or do a Frame class with different subclasses ? I'm worried about the hierachy (neat by the way) manipulation implied by the setBorder() in term of performances. If you can also do it the other way, creating a frame and adding the content, you can have the same result and less manipulations I would think. Then setBorder() could take a Frame instance as an argument. Which means that if you need a special kind of frame, you would subclass Frame and that's all, which sounds easier than overriding setBorder. I really need to finish the drag additions, and I'll do a corner resizable frame as an example ! Feedback ? Benoit > > - > Kevin. > > >> >> Keep up the good work >> >> >> PS. Have to tested the creation speed of say 100 >> layers with skinned borders? >> >> >> -- >> Raymond Irving >> >> >> --- Kevin <ke...@ke...> wrote: >>> Hello all, >>> >>> Raymond, I hope you don't mind me extending you >>> ideas. I've had a go at presenting my >>> thoughts on borders which are similar to Benoit's. >>> Please unpack the attached file in the >>> latest dynapi3x root folder/directory. In principle: >>> >>> 1) Images in highlighters (just auto repeat >>> background image). >>> 2) Have 1 content layer + 4 sides + 4 corners + 1 >>> container. >>> 3) Moving container moves all (no group manager >>> needed). >>> 4) Border2 is DOM2 spec' i.e. border is outside >>> element width (border won't clip content). >>> 5) Offer flexibility to have different skin widths >>> (perhaps someone can complete this?) >>> 6) Let transparent gifs with background colors be >>> defaulted and configurable (unfinished). >>> >>> There is so much more work to do on this I thought >>> I'd stop here and see if it's close! >>> >>> Could someone change the example to show how to use >>> preloaded images from cache >>> rather than strings. Does <layer background=img.src >>> ..> do it for ns4? These updates >>> have been tested on Linux NS4/Mozilla. Please help >>> and offer the fix if it doesn't work >>> on your browser. >>> >>> - >>> Kevin. >>> >>> >>>> Hello Everyone, >>>> >>>> I've completed the BorderManager and Highligther >>>> classes as promised >>>> >>>> You can see a live demo here: >>>> >>>> >>> >> http://www24.brinkster.com/dyntools/next/examples/ >> dynapi.gui.bordermanager.html >>>> >>>> >>> >> http://www24.brinkster.com/dyntools/next/examples/ >> dynapi.gui.highlighter.html >>>> >>>> >>> >> http://www24.brinkster.com/dyntools/next/examples/ >> dynapi.gui.focusmanager.html >>>> >>>> Note: The setBorder() function now requires the >>>> BorderManager Class >>>> >>>> >>>> Any comments? Can I go ahead and upload these >>> changes >>>> to CVS? >>>> >>>> >>>> PS. Files are attached >>>> >>>> -- >>>> Raymond Irving >>>> >>>> >>>> >>>> __________________________________ >>>> Do you Yahoo!? >>>> The New Yahoo! Search - Faster. Easier. Bingo. >>>> http://search.yahoo.com >> >>> ATTACHMENT part 2 application/x-zip-compressed >> name=border-update.zip >> >> >> >> __________________________________ >> Do you Yahoo!? >> The New Yahoo! Search - Faster. Easier. Bingo. >> http://search.yahoo.com >> >> >> ------------------------------------------------------- >> Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara >> The only event dedicated to issues related to Linux enterprise >> solutions >> www.enterpriselinuxforum.com >> >> _______________________________________________ >> Dynapi-Dev mailing list >> Dyn...@li... >> http://www.mail-archive.com/dyn...@li.../ > > > ------------------------------------------------------- > Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara > The only event dedicated to issues related to Linux enterprise > solutions > www.enterpriselinuxforum.com > > _______________________________________________ > Dynapi-Dev mailing list > Dyn...@li... > http://www.mail-archive.com/dyn...@li.../ > |