RE: [Dynapi-Help] New List, Label and Window Widgets

[Daniel T. <de...@ti...>]

Hi Andrew!

I have looked throught your code and i will make the changes to the
stacker, and aswell the ";" to the window :)

However i dont really understand the change you did to the window. Do
you want the content layer to set the size of the window? Or am i out of
the game?

Regards
Daniel

-----Original Message-----
From: dyn...@li...
[mailto:dyn...@li...] On Behalf Of Andrew
Gillett
Sent: den 3 oktober 2003 05:15
To: dyn...@li...
Subject: Re: [Dynapi-Help] New List, Label and Window Widgets


Daniel Tiru wrote:
> Great, atleast someone except me think its useful then :)

Hi Daniel,

I have been looking at your stacker and window widgets, and I also think
they are excellent.

I have a couple of very minor issues that you may like to look at:

- stacker.js has various methods that use the variable 'i' for a loop
counter without declaring the variable to be local.  I had some very
strange side-effects when I used a for-loop with iterator 'i' to add
windows to the stacker.  I think that the remove(), move(), and
generate() methods all need a "var i;" declaration.

- I have made a sub-class of Window that sets the height of the content
layer to the natural height of content HTML.  But to do this, I had to
make a couple of minor tweaks to  the Window constructor.  A "diff" for
my changes is below.

  Firstly, I put most of the constructor code into an
"if(arguments.length>0)" block.  This allows the constructor to be
called without any arguments, which is necessary if you want to set
Window as the prototype of a sub-class.
  Next, I added an "if(this.h)" test before the line that sets the
content height.  This is purely for my purposes as I didn't want to
explicitly set the height of the content layer.
  Finally, I added a semi-colon on line 27 to keep the compressor happy
:)


$ cvs diff window.js
Index: window.js
===================================================================
RCS file: /cvsroot/dynapi/dynapi3x/src/gui/window.js,v
retrieving revision 1.1
diff -r1.1 window.js
27c27
<       this._tmpcnt=0
---
>       this._tmpcnt=0;
28a29
>       if (arguments.length>0){
44c45,46
<       this.content.setHeight(this.h-this._mnuheight);
---
>       if (this.h)
>               this.content.setHeight(this.h-this._mnuheight);
51a54
>       }


I hope you don't mind me posting these changes.  If you would like to
see my sub-class (it's not much), just let me know.

Thank you for these widgets, and keep up the good work!

regards,
Andrew Gillett


> 
> Regards
> Daniel
> 
> -----Original Message-----
> From: dyn...@li...
> [mailto:dyn...@li...] On Behalf Of Brian 
> Hayes
> Sent: den 2 oktober 2003 12:00
> To: dyn...@li...
> Subject: RE: [Dynapi-Help] New List, Label and Window Widgets
> 
> 
> Stacker.js is preaty cool..
> 
> -----Original Message-----
> From: dyn...@li...
> [mailto:dyn...@li...] On Behalf Of Raymond 
> Irving
> Sent: Wednesday, October 01, 2003 11:54 PM
> To: DynApi-Help
> Subject: [Dynapi-Help] New List, Label and Window Widgets
> 
> Hi,
> 
> Check out cvs for some of really cool new widgets for DynAPI 3
> 
> 
> --
> Raymond Irving
> 




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dynapi-Help mailing list
Dyn...@li...
https://lists.sourceforge.net/lists/listinfo/dynapi-help