Menu
▾
▴
dynapi-dev
|
From: <no...@so...> - 2001-01-28 22:28:14
|
Bug #130357, was updated on 2001-Jan-28 14:27
Here is a current snapshot of the bug.
Project: DynAPI 2
Category: Core - Widgets
Status: Open
Resolution: None
Bug Group: None
Priority: 5
Submitted by: marstr
Assigned to : nobody
Summary: small typo in list.js
Details: there's a small typo (i think) in list.js line 76
if (this.selected=b) {
should be
if (this.selected==b) {
right?
For detailed info, follow this link:
http://sourceforge.net/bugs/?func=detailbug&bug_id=130357&group_id=5757
|
|
From: <no...@so...> - 2001-01-29 01:50:51
|
Bug #130357, was updated on 2001-Jan-28 14:27
Here is a current snapshot of the bug.
Project: DynAPI 2
Category: Core - Widgets
Status: Closed
Resolution: Fixed
Bug Group: None
Priority: 5
Submitted by: marstr
Assigned to : rainwater
Summary: small typo in list.js
Details: there's a small typo (i think) in list.js line 76
if (this.selected=b) {
should be
if (this.selected==b) {
right?
Follow-Ups:
Date: 2001-Jan-28 17:50
By: rainwater
Comment:
Doh! Its been updated in CVS. Closing this bug.
-------------------------------------------------------
For detailed info, follow this link:
http://sourceforge.net/bugs/?func=detailbug&bug_id=130357&group_id=5757
|
|
From: Michael P. <mp...@ph...> - 2001-01-30 13:32:08
|
please put the "typo" back. What is does is set the value of this.selected
to b and then evaluates the returned value (the new value of
this.selected). It is needed to change the selected state of the item.
no...@so... wrote:
> Bug #130357, was updated on 2001-Jan-28 14:27
> Here is a current snapshot of the bug.
>
> Project: DynAPI 2
> Category: Core - Widgets
> Status: Closed
> Resolution: Fixed
> Bug Group: None
> Priority: 5
> Submitted by: marstr
> Assigned to : rainwater
> Summary: small typo in list.js
>
> Details: there's a small typo (i think) in list.js line 76
>
> if (this.selected=b) {
>
> should be
>
> if (this.selected==b) {
>
> right?
>
> Follow-Ups:
>
> Date: 2001-Jan-28 17:50
> By: rainwater
>
> Comment:
> Doh! Its been updated in CVS. Closing this bug.
> -------------------------------------------------------
>
> For detailed info, follow this link:
> http://sourceforge.net/bugs/?func=detailbug&bug_id=130357&group_id=5757
>
> _______________________________________________
> Dynapi-Dev mailing list
> Dyn...@li...
> http://lists.sourceforge.net/lists/listinfo/dynapi-dev
--
Michael Pemberton
mp...@ph...
ICQ: 12107010
|
|
From: Cameron H. <ca...@bi...> - 2001-01-30 13:45:21
|
perhaps it would be safer to assign the value first and then test the
condition...
-----Original Message-----
From: dyn...@li...
[mailto:dyn...@li...]On Behalf Of Michael
Pemberton
Sent: 30 January 2001 13:28
To: dyn...@li...
Subject: Re: [Dynapi-Dev] [Bug #130357] small typo in list.js
please put the "typo" back. What is does is set the value of
this.selected to b and then evaluates the returned value (the new value of
this.selected). It is needed to change the selected state of the item.
no...@so... wrote:
Bug #130357, was updated on 2001-Jan-28 14:27
Here is a current snapshot of the bug.
Project: DynAPI 2
Category: Core - Widgets
Status: Closed
Resolution: Fixed
Bug Group: None
Priority: 5
Submitted by: marstr
Assigned to : rainwater
Summary: small typo in list.js
Details: there's a small typo (i think) in list.js line 76
if (this.selected=b)
should be
if (this.selected==b)
right?
Follow-Ups:
Date: 2001-Jan-28 17:50
By: rainwater
Comment:
Doh! Its been updated in CVS. Closing this bug.
-------------------------------------------------------
For detailed info, follow this link:
http://sourceforge.net/bugs/?func=detailbug&bug_id=130357&group_id=5757
_______________________________________________
Dynapi-Dev mailing list
Dyn...@li...
http://lists.sourceforge.net/lists/listinfo/dynapi-dev
--
Michael Pemberton
mp...@ph...
ICQ: 12107010
|
|
From: Doug M. <do...@cr...> - 2001-01-30 15:31:21
|
That just plain silly.
It's perfectly valid coding technique.
perhaps it would be safer to assign the value first and then test the =
condition...
-----Original Message-----
From: dyn...@li... =
[mailto:dyn...@li...]On Behalf Of Michael =
Pemberton
Sent: 30 January 2001 13:28
To: dyn...@li...
Subject: Re: [Dynapi-Dev] [Bug #130357] small typo in list.js
please put the "typo" back. What is does is set the value of =
this.selected to b and then evaluates the returned value (the new value =
of this.selected). It is needed to change the selected state of the =
item.=20
no...@so... wrote:=20
Bug #130357, was updated on 2001-Jan-28 14:27=20
Here is a current snapshot of the bug.=20
Project: DynAPI 2=20
Category: Core - Widgets=20
Status: Closed=20
Resolution: Fixed=20
Bug Group: None=20
Priority: 5=20
Submitted by: marstr=20
Assigned to : rainwater=20
Summary: small typo in list.js=20
Details: there's a small typo (i think) in list.js line 76=20
if (this.selected=3Db) {=20
should be=20
if (this.selected=3D=3Db) {=20
right?=20
Follow-Ups:=20
Date: 2001-Jan-28 17:50=20
By: rainwater=20
Comment:=20
Doh! Its been updated in CVS. Closing this bug.=20
-------------------------------------------------------=20
For detailed info, follow this link:=20
=
http://sourceforge.net/bugs/?func=3Ddetailbug&bug_id=3D130357&group_id=3D=
5757=20
_______________________________________________=20
Dynapi-Dev mailing list=20
Dyn...@li...=20
http://lists.sourceforge.net/lists/listinfo/dynapi-dev
--=20
Michael Pemberton=20
mp...@ph...=20
ICQ: 12107010=20
=20
|
|
From: Robert R. <rra...@ya...> - 2001-01-30 16:20:57
|
Come to think of it, the line is not correct anyway.
If the item is selected then there is no reason to set it.
if (this.selected==b) return;
--
// Robert Rainwater
On 1/30/2001, 1:28:49 PM EST, Doug wrote about "[Dynapi-Dev] [Bug #130357] small typo in list.js":
> That just plain silly.
> It's perfectly valid coding technique.
> perhaps it would be safer to assign the value first and then test the condition...
> -----Original Message-----
> From: dyn...@li... [mailto:dyn...@li...]On Behalf Of Michael Pemberton
> Sent: 30 January 2001 13:28
> To: dyn...@li...
> Subject: Re: [Dynapi-Dev] [Bug #130357] small typo in list.js
> please put the "typo" back. What is does is set the value of this.selected to b and then evaluates the returned value (the new value of this.selected). It is needed to change the selected
> state of the item.
> no...@so... wrote:
> Bug #130357, was updated on 2001-Jan-28 14:27
> Here is a current snapshot of the bug.
> Project: DynAPI 2
> Category: Core - Widgets
> Status: Closed
> Resolution: Fixed
> Bug Group: None
> Priority: 5
> Submitted by: marstr
> Assigned to : rainwater
> Summary: small typo in list.js
> Details: there's a small typo (i think) in list.js line 76
> if (this.selected=b) {
> should be
> if (this.selected==b) {
> right?
> Follow-Ups:
> Date: 2001-Jan-28 17:50
> By: rainwater
> Comment:
> Doh! Its been updated in CVS. Closing this bug.
> -------------------------------------------------------
> For detailed info, follow this link:
> http://sourceforge.net/bugs/?func=detailbug&bug_id=130357&group_id=5757
> _______________________________________________
> Dynapi-Dev mailing list
> Dyn...@li...
> http://lists.sourceforge.net/lists/listinfo/dynapi-dev
> --
> Michael Pemberton
> mp...@ph...
> ICQ: 12107010
----------------------
DynAPI Snapshots: http://dynapi.sourceforge.net/snapshot/
DynAPI Homepage: http://dynapi.sourceforge.net/
|
|
From: Raides J. <ra...@te...> - 2001-01-30 13:47:41
Attachments:
ns6test.zip
|
Michael Pemberton wrote:
>
> please put the "typo" back. What is does is set the value of this.selected to
> b and then evaluates the returned value (the new value of this.selected). It
> is needed to change the selected state of the item.
>
> > if (this.selected=b) {
> >
> > should be
> >
> > if (this.selected==b) {
> >
> > right?
I will answer both for NS6's sake:
This is indeed a bug in NS6 and prevents normal execution of the rest of the
code. It should read:
this.selected=b
if(this.selected){
...
}else{
...
}
I have done this kind of changes all around my local dynapi distribution and
those pesky errors that NS6 throwed at me and their side effect of code not
executing in that function anymore disappeared. Other special perso-NS6-ality of
this browser is that if you want to dynamically resize an image, you have to do
it TWICE, using a setTimeout to delay appropiately (30 millisecs are enough) the
effect. The code I use to test NS6 comes with this mail. It is spanish code and
HTML, poorly documented but that can be executed in IE4.0 and above with no
changes at all and some errors due to their different underlying model.
Raides J. |
|
From: Doug M. <do...@cr...> - 2001-01-30 15:32:46
|
Well I'll be...
I shoulda known 'perfectly valid coding technique' and
NS6 don't belong in the same sentance.
> Michael Pemberton wrote:
> >
> > please put the "typo" back. What is does is set the value of
this.selected to
> > b and then evaluates the returned value (the new value of
this.selected). It
> > is needed to change the selected state of the item.
> >
>
> > > if (this.selected=b) {
> > >
> > > should be
> > >
> > > if (this.selected==b) {
> > >
> > > right?
>
> I will answer both for NS6's sake:
>
> This is indeed a bug in NS6 and prevents normal execution of the rest of
the
> code. It should read:
>
> this.selected=b
> if(this.selected){
> ...
> }else{
> ...
> }
>
> I have done this kind of changes all around my local dynapi distribution
and
> those pesky errors that NS6 throwed at me and their side effect of code
not
> executing in that function anymore disappeared. Other special
perso-NS6-ality of
> this browser is that if you want to dynamically resize an image, you have
to do
> it TWICE, using a setTimeout to delay appropiately (30 millisecs are
enough) the
> effect. The code I use to test NS6 comes with this mail. It is spanish
code and
> HTML, poorly documented but that can be executed in IE4.0 and above with
no
> changes at all and some errors due to their different underlying model.
>
> Raides J.
|
|
From: Robert R. <rra...@ya...> - 2001-01-30 15:50:08
|
Either way, we shouldn't be using if (this.selected=b). That's not
very proper.
--
// Robert Rainwater
On 1/30/2001, 8:47:21 AM EST, Raides wrote about "[Dynapi-Dev] [Bug #130357] small typo in list.js":
> Michael Pemberton wrote:
>>
>> please put the "typo" back. What is does is set the value of this.selected to
>> b and then evaluates the returned value (the new value of this.selected). It
>> is needed to change the selected state of the item.
>>
>> > if (this.selected=b) {
>> >
>> > should be
>> >
>> > if (this.selected==b) {
>> >
>> > right?
> I will answer both for NS6's sake:
> This is indeed a bug in NS6 and prevents normal execution of the rest of the
> code. It should read:
> this.selected=b
> if(this.selected){
> ...
> }else{
> ...
> }
> I have done this kind of changes all around my local dynapi distribution and
> those pesky errors that NS6 throwed at me and their side effect of code not
> executing in that function anymore disappeared. Other special perso-NS6-ality of
> this browser is that if you want to dynamically resize an image, you have to do
> it TWICE, using a setTimeout to delay appropiately (30 millisecs are enough) the
> effect. The code I use to test NS6 comes with this mail. It is spanish code and
> HTML, poorly documented but that can be executed in IE4.0 and above with no
> changes at all and some errors due to their different underlying model.
> Raides J.
----------------------
DynAPI Snapshots: http://dynapi.sourceforge.net/snapshot/
DynAPI Homepage: http://dynapi.sourceforge.net/
|
|
From: Doug M. <do...@cr...> - 2001-01-30 15:53:13
|
I've just had that conversation with a co-worker.
Can anyone tell me why this is not proper?
The best my co-worker could come up with was 'it doesn't feel right'
....
> Either way, we shouldn't be using if (this.selected=b). That's not
> very proper.
>
> --
> // Robert Rainwater
>
> On 1/30/2001, 8:47:21 AM EST, Raides wrote about "[Dynapi-Dev] [Bug
#130357] small typo in list.js":
>
> > Michael Pemberton wrote:
> >>
> >> please put the "typo" back. What is does is set the value of
this.selected to
> >> b and then evaluates the returned value (the new value of
this.selected). It
> >> is needed to change the selected state of the item.
> >>
>
> >> > if (this.selected=b) {
> >> >
> >> > should be
> >> >
> >> > if (this.selected==b) {
> >> >
> >> > right?
>
> > I will answer both for NS6's sake:
>
> > This is indeed a bug in NS6 and prevents normal execution of the
rest of the
> > code. It should read:
>
> > this.selected=b
> > if(this.selected){
> > ...
> > }else{
> > ...
> > }
>
> > I have done this kind of changes all around my local dynapi
distribution and
> > those pesky errors that NS6 throwed at me and their side effect of code
not
> > executing in that function anymore disappeared. Other special
perso-NS6-ality of
> > this browser is that if you want to dynamically resize an image, you
have to do
> > it TWICE, using a setTimeout to delay appropiately (30 millisecs are
enough) the
> > effect. The code I use to test NS6 comes with this mail. It is spanish
code and
> > HTML, poorly documented but that can be executed in IE4.0 and above with
no
> > changes at all and some errors due to their different underlying model.
>
> > Raides J.
>
>
> ----------------------
> DynAPI Snapshots: http://dynapi.sourceforge.net/snapshot/
> DynAPI Homepage: http://dynapi.sourceforge.net/
>
>
>
> _______________________________________________
> Dynapi-Dev mailing list
> Dyn...@li...
> http://lists.sourceforge.net/lists/listinfo/dynapi-dev
|
|
From: Cameron H. <ca...@bi...> - 2001-01-30 16:21:53
|
according to the ecmascript-262 spec (i'm being a trainspotter here!), an
assignment should return the assigned value. so ns6 is not doing the right
thing.
the real point of changing this line is if the api is to be cross-browser it
has to work around faults in all the browsers (and lets face it, there's a
lot of them!).
> -----Original Message-----
> From: dyn...@li...
> [mailto:dyn...@li...]On Behalf Of Doug Melvin
> Sent: 30 January 2001 18:51
> To: dyn...@li...
> Subject: Re: Re[2]: [Dynapi-Dev] [Bug #130357] small typo in list.js
>
>
> I've just had that conversation with a co-worker.
> Can anyone tell me why this is not proper?
> The best my co-worker could come up with was 'it doesn't feel right'
> ....
>
>
> > Either way, we shouldn't be using if (this.selected=b). That's not
> > very proper.
> >
> > --
> > // Robert Rainwater
> >
> > On 1/30/2001, 8:47:21 AM EST, Raides wrote about "[Dynapi-Dev] [Bug
> #130357] small typo in list.js":
> >
> > > Michael Pemberton wrote:
> > >>
> > >> please put the "typo" back. What is does is set the value of
> this.selected to
> > >> b and then evaluates the returned value (the new value of
> this.selected). It
> > >> is needed to change the selected state of the item.
> > >>
> >
> > >> > if (this.selected=b) {
> > >> >
> > >> > should be
> > >> >
> > >> > if (this.selected==b) {
> > >> >
> > >> > right?
> >
> > > I will answer both for NS6's sake:
> >
> > > This is indeed a bug in NS6 and prevents normal
> execution of the
> rest of the
> > > code. It should read:
> >
> > > this.selected=b
> > > if(this.selected){
> > > ...
> > > }else{
> > > ...
> > > }
> >
> > > I have done this kind of changes all around my local dynapi
> distribution and
> > > those pesky errors that NS6 throwed at me and their side
> effect of code
> not
> > > executing in that function anymore disappeared. Other special
> perso-NS6-ality of
> > > this browser is that if you want to dynamically resize an image, you
> have to do
> > > it TWICE, using a setTimeout to delay appropiately (30 millisecs are
> enough) the
> > > effect. The code I use to test NS6 comes with this mail. It is spanish
> code and
> > > HTML, poorly documented but that can be executed in IE4.0 and
> above with
> no
> > > changes at all and some errors due to their different
> underlying model.
> >
> > > Raides J.
> >
> >
> > ----------------------
> > DynAPI Snapshots: http://dynapi.sourceforge.net/snapshot/
> > DynAPI Homepage: http://dynapi.sourceforge.net/
> >
> >
> >
> > _______________________________________________
> > Dynapi-Dev mailing list
> > Dyn...@li...
> > http://lists.sourceforge.net/lists/listinfo/dynapi-dev
>
>
> _______________________________________________
> Dynapi-Dev mailing list
> Dyn...@li...
> http://lists.sourceforge.net/lists/listinfo/dynapi-dev
|
|
From: <th...@je...> - 2001-01-30 17:16:37
|
----- Original Message -----=20
From: Doug Melvin <do...@cr...>
To: <dyn...@li...>
Sent: Tuesday, January 30, 2001 19:50
Subject: Re: Re[2]: [Dynapi-Dev] [Bug #130357] small typo in list.js
> I've just had that conversation with a co-worker.
> Can anyone tell me why this is not proper?
> The best my co-worker could come up with was 'it doesn't feel right'
> ....
>=20
>=20
> > Either way, we shouldn't be using if (this.selected=3Db). That's =
not
> > very proper.
> >
> > --
> > // Robert Rainwater
> >
> > On 1/30/2001, 8:47:21 AM EST, Raides wrote about "[Dynapi-Dev] [Bug
> #130357] small typo in list.js":
> >
> > > Michael Pemberton wrote:
> > >>
> > >> please put the "typo" back. What is does is set the value of
> this.selected to
> > >> b and then evaluates the returned value (the new value of
> this.selected). It
> > >> is needed to change the selected state of the item.
> > >>
> >
> > >> > if (this.selected=3Db) {
> > >> >
> > >> > should be
> > >> >
> > >> > if (this.selected=3D=3Db) {
> > >> >
> > >> > right?
> >
> > > I will answer both for NS6's sake:
> >
> > > This is indeed a bug in NS6 and prevents normal execution =
of the
> rest of the
> > > code. It should read:
> >
> > > this.selected=3Db
> > > if(this.selected){
> > > ...
> > > }else{
> > > ...
> > > }
> >
> > > I have done this kind of changes all around my local =
dynapi
> distribution and
> > > those pesky errors that NS6 throwed at me and their side effect of =
code
> not
> > > executing in that function anymore disappeared. Other special
> perso-NS6-ality of
> > > this browser is that if you want to dynamically resize an image, =
you
> have to do
> > > it TWICE, using a setTimeout to delay appropiately (30 millisecs =
are
> enough) the
> > > effect. The code I use to test NS6 comes with this mail. It is =
spanish
> code and
> > > HTML, poorly documented but that can be executed in IE4.0 and =
above with
> no
> > > changes at all and some errors due to their different underlying =
model.
> >
> > > Raides J.
> >
> >
> > ----------------------
> > DynAPI Snapshots: http://dynapi.sourceforge.net/snapshot/
> > DynAPI Homepage: http://dynapi.sourceforge.net/
> >
> >
> >
> > _______________________________________________
> > Dynapi-Dev mailing list
> > Dyn...@li...
> > http://lists.sourceforge.net/lists/listinfo/dynapi-dev
>=20
>=20
>=20
>=20
>=20
|
|
From: Jared N. <ja...@aa...> - 2001-01-30 15:59:18
|
Some people will tell you it is improper. some people will say it is fine. I think the only improper thing about it is a lack of comment next to it. Because it is an unothorodox coding technique (as far as most are concerned) a simple comment can alleviate any question as to where it was done purposely. |
|
From: <no...@so...> - 2001-01-30 23:55:24
|
Bug #130357, was updated on 2001-Jan-28 14:27
Here is a current snapshot of the bug.
Project: DynAPI 2
Category: Core - Widgets
Status: Closed
Resolution: Fixed
Bug Group: None
Priority: 5
Submitted by: marstr
Assigned to : rainwater
Summary: small typo in list.js
Details: there's a small typo (i think) in list.js line 76
if (this.selected=b) {
should be
if (this.selected==b) {
right?
Follow-Ups:
Date: 2001-Jan-30 15:55
By: rainwater
Comment:
See patch at
http://sourceforge.net/patch/index.php?func=detailpatch&patch_id=103520&group_id=5757
-------------------------------------------------------
Date: 2001-Jan-28 17:50
By: rainwater
Comment:
Doh! Its been updated in CVS. Closing this bug.
-------------------------------------------------------
For detailed info, follow this link:
http://sourceforge.net/bugs/?func=detailbug&bug_id=130357&group_id=5757
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X