From: Todd P. <tp...@mv...> - 2004-12-20 21:52:30
|
Amit Choudhary wrote: > Hi, > > I have a suggestion for the DPM patch. All the changes should be covered > under #ifdef CONFIG_DPM ... #endif. So, that if I can use the same kernel > with and without DPM support. As of now, once I have included the DPM patch, > there is no way of compiling without the DPM support. It gives errors if I > try to compile after unchecking the DPM option. Hi, I've fixed one known problem with compilation when CONFIG_DPM=n using latest patches, have been waiting for 2.6.10 to release new patches. If there's a compilation problem with CONFIG_DPM=n then it's a bug, send the details and I'll make sure it's fixed. For better or worse, various power management related things for embedded systems are finding their way into the patches, including things not tied to the core DPM currently selected with CONFIG_DPM (such as kernel-to-userspace power event notifiers). Most of the non-DPM-specific stuff is selected with CONFIG_PM, which should be generally appropriate, although deviations from upstream PM code could be configured separately. The drivers/base/power/power-dpm.o file does contain things that are supposed to be present with use of the DPM core and is selected with CONFIG_PM, some of which is temporary while potentially community-acceptable designs are being formulated. For now I'm fixing the bugs as they arise. Thanks, -- Todd |