Re: [Dxr3plugin-users] [patch] fixes for vdr-1.7.14

[Ville S. <vil...@ik...>]

On Tuesday 24 August 2010, Luca Olivetti wrote:
> Al 24/08/10 17:58, En/na Ville Skyttä ha escrit:
> > I ended up reverting the PTS related changes and it fixes the subtitles
> > timing issue and does not cause any problems with fast forward/rewind
> > with VDR 1.6.0-2 (PES only naturally).
> 
> But that's not going to work with ts recordings :-(

Yes, that's what I gathered from previous messages in this thread.  That's too 
bad, but this is the "stable" branch of the dxr3 plugin, and its primary 
target is the current stable VDR.  Which in my (strong) opinion means that 
things added solely for VDR development releases' needs must not come at the 
expense of regressions (at least this big ones) when used with the current 
stable VDR.

I already had some concerns about missing audio when moving cut marks caused 
by some portions of this patch, but it also makes things better with some 
channels with higher than usual bitrates (e.g. SuomiTV was pretty much 
unwatchable for me before these changes) so I'm willing to accept that 
tradeoff within 1.6.x functionality.  These may be due to different parts of 
the patch but it's hard to tell given the size of it (and my lack of 
competence in this area); it should have really been split into different 
changesets that each do one self-contained thing so it would have been sanely 
possible to bisect regressions.  (BTW patches that bring back audio when 
moving cut marks are still welcome.)

At least now the PTS reversion changeset can be retrieved separately from CVS 
with cvsps and looking at that it's probably easier for someone who's 
interested to work on an implementation that fixes things for VDR 1.7.x 
without causing 1.6.x regressions.