Menu

#105 dvdbackup error ripping chapters

open
nobody
None
5
2003-12-13
2003-12-13
Chuck Moss
No

There seem to be a bug in the process of ripping
individual chapters.

When I get to the a chapter that spans a VOB the ripped
chapter size goes
way off and it rips 2.1G for that chapter before
outputting an error.

e.g.
./dvdbackup -i /dev/dvd -t 1 -s 9 -e 9 -n tmp_title -o
dvdbackup.debug/chapter9

The code at line 401 looks like this:

if ( cell_end_sector[f] > offset ) {
leftover = cell_end_sector[f] - offset + 1;
} else {
size = cell_end_sector[f] -
cell_start_sector[f] + 1;
}

It appears that when cell_end_sector[f] > offset you
figure that the
chapter is part of two VOB files. The amount of extra
space is the
"leftover" value. Size is never set in that case. I
think you always want
to set size when you get to that point in the code.
I changed the code to read:

size = cell_end_sector[f] -
cell_start_sector[f] + 1;
if ( cell_end_sector[f] > offset ) {
leftover = cell_end_sector[f] - offset + 1;
}

Not sure if this is a permanent fix bit it seems to
solve one problem I was having. I am not a coder so I
may have overlooked problems with the change.

Discussion


Log in to post a comment.